Fix two SciTE bugs

[mozers]

Hello Scite-interest,
I propose to fix two SciTE bugs:

[1]. Dialogue "Parameters" does not allow to enter national characters.
To fix this bug, replace the line 152 in file SciTEWinDlg.cxx from
> -----------------------------
if (!menuKey && ::IsDialogMessage(reinterpret_cast<HWND>(wParameters.GetID()), pmsg))
> -----------------------------
to
> -----------------------------
if (!menuKey && DialogHandled(wParameters.GetID(), pmsg))
> -----------------------------
(Author: neo4max)

[2]. "Open Selected Filename" (Ctrl+Shift+O) does not work if in the file name there are national characters.
To fix this bug, replace the line 1257 in file SciTEBase.cxx from
> -----------------------------
SString SciTEBase::SelectionFilename() {
return SelectionExtend(&SciTEBase::isfilenamecharforsel);
}
> -----------------------------
to
> -----------------------------
SString SciTEBase::SelectionFilename() {
return EncodeString(SelectionExtend(&SciTEBase::isfilenamecharforsel));
}
> -----------------------------

Both improvements are successfully working in SciTE-Ru.

--
mozers
<http://scite.net.ru>

[Neil Hodgson]

mozers:

> [1]. Dialogue "Parameters" does not allow to enter national characters.
> To fix this bug, replace the line 152 in file SciTEWinDlg.cxx from
>> -----------------------------
> if (!menuKey && ::IsDialogMessage(reinterpret_cast<HWND>(wParameters.GetID()), pmsg))
>> -----------------------------
> to
>> -----------------------------
> if (!menuKey && DialogHandled(wParameters.GetID(), pmsg))
>> -----------------------------

OK.

> [2]. "Open Selected Filename" (Ctrl+Shift+O) does not work if in the file name there are national characters.
> To fix this bug, replace the line 1257 in file SciTEBase.cxx from
>> -----------------------------
> SString SciTEBase::SelectionFilename() {
>        return SelectionExtend(&SciTEBase::isfilenamecharforsel);
> }
>> -----------------------------
> to
>> -----------------------------
> SString SciTEBase::SelectionFilename() {
>        return EncodeString(SelectionExtend(&SciTEBase::isfilenamecharforsel));
> }

EncodeString changes the text to the encoding of the document, not
your platform encoding.

Neil

[mozers]

Thursday, January 7, 2010, 1:04:37 PM, Neil wrote:

>> � � � �return EncodeString(SelectionExtend(&SciTEBase::isfilenamecharforsel));

> EncodeString changes the text to the encoding of the document, not
> your platform encoding.

Yes. This works only if the encoding of the document coincides with the platform encoding.
If we do not work in unicode, it is often - the truth.
I agree, this is an incomplete solution, but in any case it is better than the current implementation.

--
mozers
<http://scite.net.ru>