Error when building from git - scikit-image

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion Error when building from git
Received-SPF: pass (google.com: domain of tsy...@gmail.com designates 74.125.82.42 as permitted sender) client-ip=74.125.82.42;
MIME-Version: 1.0
In-Reply-To: <CABDkGQkqERmOWudUTkL9-oZB6f+8dHdH=7WL7mGjyFwGyb99Ww@mail.gmail.com>
References: <e36f20f0-9e2c-445d-8f7c-4ba9fc1fa3ae@t5g2000yqk.googlegroups.com>
	<CABDkGQkAo91Ve5gc7UA8tezE4jnm0q7eBuUbp9GZABvTt2Y...@mail.gmail.com>
	<20120210185857.GB3...@phare.normalesup.org>
	<CABDkGQkqERmOWudUTkL9-oZB6f+8dHdH=7WL7mGjyFwGyb9...@mail.gmail.com>
Date: Sat, 11 Feb 2012 17:07:21 -0500
Message-ID: <CAEym_HoqEZTgDZ23Rf7gknZnunCvRjoqqY0oAVRK6UUV837...@mail.gmail.com>
Subject: Re: Error when building from git
From: Tony Yu <tsy...@gmail.com>
To: scikits-image@googlegroups.com
Content-Type: multipart/alternative; boundary=f46d043be0062b1de204b8b7786e

--f46d043be0062b1de204b8b7786e
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2012/2/11 St=E9fan van der Walt <ste...@sun.ac.za>

> Hi Emmanuelle
>
> On Fri, Feb 10, 2012 at 10:58 AM, Emmanuelle Gouillart
> <emmanuelle.gouill...@nsup.org> wrote:
> > isn't it possible to test which version of numpy is used, and remove
> > float16 from the list if numpy.__version__ < 1.6? It looks like a small
> > cost in order to be be able to support numpy 1.5. I can do the change i=
f
> > there is no opposition to this.
>
> If we can stay compatible with 1.5 with minor changes, that's probably
> worth it.  Can you also check the dtype conversion code to make sure
> it all works? (Running the unit tests should be enough of an
> indication)
>

I'd be in favor of supporting numpy 1.5. Just note that the `convert`
function uses `np.promote_types`, which is also new to numpy 1.6.

-Tony

> As I see things, it would be great if people could use skimage with the
> > dependencies provided by a recent version of Ubuntu, say the most recen=
t
> > LTS, or the latest release of Ubuntu. We will lose many users if they
> > have to install a new numpy (which also means that they will have to
> > install non-packaged matplolib, and scipy). If you disagree with this
> > philosophy, please tell me :-).
>
> I understand the challenges of running on an older platform, but I
> also wonder: if a user can recompile scikits-image, what's stopping
> them from also building the latest (stable) numpy?  I certainly have
> the expectation that software should run with the available stable
> versions of dependencies on the date of release.  That said, any
> benefit we can get with little effort is worth it, and there's no
> reason to purposefully make it harder for users than need be.  So
> please, keep the PRs coming for backwards compatibility, as long as
> they are not too disruptive.
>
> Regards
> St=E9fan
>

--f46d043be0062b1de204b8b7786e
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<br><br><div class=3D"gmail_quote">2012/2/11 St=E9fan van der Walt <span di=
r=3D"ltr">&lt;<a href=3D"mailto:ste...@sun.ac.za">ste...@sun.ac.za</a>&gt;<=
/span><br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bord=
er-left:1px #ccc solid;padding-left:1ex">
Hi Emmanuelle<br>
<div class=3D"im"><br>
On Fri, Feb 10, 2012 at 10:58 AM, Emmanuelle Gouillart<br>
&lt;<a href=3D"mailto:emmanuelle.gouill...@nsup.org">emmanuelle.gouillart@n=
sup.org</a>&gt; wrote:<br>
&gt; isn&#39;t it possible to test which version of numpy is used, and remo=
ve<br>
&gt; float16 from the list if numpy.__version__ &lt; 1.6? It looks like a s=
mall<br>
&gt; cost in order to be be able to support numpy 1.5. I can do the change =
if<br>
&gt; there is no opposition to this.<br>
<br>
</div>If we can stay compatible with 1.5 with minor changes, that&#39;s pro=
bably<br>
worth it. =A0Can you also check the dtype conversion code to make sure<br>
it all works? (Running the unit tests should be enough of an<br>
indication)<br></blockquote><div><br></div><div>I&#39;d be in favor of supp=
orting numpy 1.5. Just note that the `convert` function uses `np.promote_ty=
pes`, which is also new to numpy 1.6.</div><div><br></div><div>-Tony</div>
<div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex=
;border-left:1px #ccc solid;padding-left:1ex"><div class=3D"im">
&gt; As I see things, it would be great if people could use skimage with th=
e<br>
&gt; dependencies provided by a recent version of Ubuntu, say the most rece=
nt<br>
&gt; LTS, or the latest release of Ubuntu. We will lose many users if they<=
br>
&gt; have to install a new numpy (which also means that they will have to<b=
r>
&gt; install non-packaged matplolib, and scipy). If you disagree with this<=
br>
&gt; philosophy, please tell me :-).<br>
<br>
</div>I understand the challenges of running on an older platform, but I<br=
>
also wonder: if a user can recompile scikits-image, what&#39;s stopping<br>
them from also building the latest (stable) numpy? =A0I certainly have<br>
the expectation that software should run with the available stable<br>
versions of dependencies on the date of release. =A0That said, any<br>
benefit we can get with little effort is worth it, and there&#39;s no<br>
reason to purposefully make it harder for users than need be. =A0So<br>
please, keep the PRs coming for backwards compatibility, as long as<br>
they are not too disruptive.<br>
<br>
Regards<br>
<span class=3D"HOEnZb"><font color=3D"#888888">St=E9fan<br>
</font></span></blockquote></div><br>

--f46d043be0062b1de204b8b7786e--
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
