Logging

14 views
Skip to first unread message

David Kocher

unread,
Aug 25, 2011, 6:27:54 AM8/25/11
to sardi...@googlegroups.com
There are some places in Sardine where things fail silently but some logging would be appropriate to resolve issues. A good example is a server sending URIs that are not encoded in a propfind response. See SardineImpl#list(url) catching URISyntaxException.

Would it be welcomed if a logging dependency would be introduced; or logged to java.util.logging?

-
David

Jon Stevens

unread,
Aug 25, 2011, 12:52:12 PM8/25/11
to sardi...@googlegroups.com
I generally go for slf4j. I'm totally fine with that. If you don't have slf4j in cyberduck, then JUL is fine too.

jon

Mirko Friedenhagen

unread,
Aug 25, 2011, 1:35:31 PM8/25/11
to sardi...@googlegroups.com

I think slf4j-api is lightweight enough to be used instead of using jul directly. I already have it in my "fork" as it was a dependency of async-httpclient in the first place.

Regards Mirko

David Kocher

unread,
Aug 28, 2011, 8:46:17 AM8/28/11
to sardi...@googlegroups.com
Done. Hopefully httpclient will at dome point remove the commons-logging dependency.

-
David

Reply all
Reply to author
Forward
0 new messages