patch for error when exporting slinkees with slashes
Nicola Fankhauser
it was nice meeting you at teched munich!
today, I stumbled upon an error when trying to export a slinkee with
slashes in the resulting filename (e.g. happens with registered
namespaces). a patch is attached, it's againts the most current trunk
(rev 262).
hope you can include it soon. maybe there are some other cases I did not
treat or places same things could happen I did not find. :)
regards
nicola
Hans Senden
i had a problem with creating a new nudget. It results in a dump, so i
put some extra code in subroutine PUTONMACHINE to remove the incorrect
characters in the filename.
FORM putonmachine USING fullpath TYPE string xmlstring TYPE string.
*rrq: issue 43--> replace binary with char table
*old code removed, use subversion for recovery
TYPES: BEGIN OF t_char,
maxchar(65535) TYPE c,
END OF t_char.
DATA: temptable_char TYPE TABLE OF t_char.
* begin INS dump on creating new nugget, because of invalid filename
REPLACE ALL OCCURRENCES OF '.*)|' IN fullpath WITH space.
* end INS
IF retuseract = 0.
SPLIT xmlstring AT cl_abap_char_utilities=>newline
INTO TABLE temptable_char.
CALL METHOD cl_gui_frontend_services=>gui_download
EXPORTING
filename = fullpath
filetype = 'DAT'
CHANGING
data_tab = temptable_char.
ENDIF.
*<--rrq: issue 43
ENDFORM. "putOnMachine
regards,
Hans
On Oct 25, 11:44 am, Nicola Fankhauser <nicola.fankhau...@variant.ch>
wrote:
> [PROG_ZSAPLINK.slnk.diff]--- PROG_ZSAPLINK.slnk 2007-10-25 11:08:22.726631500 +0200
> +++ PROG_ZSAPLINK_corrected.slnk 2007-10-25 11:18:50.037991000 +0200
> @@ -1,5 +1,5 @@
> <?xml version="1.0" encoding="iso-8859-1"?>
> -<PROG NAME="ZSAPLINK" VARCL="X" DBAPL="S" DBNA="D$" SUBC="1" APPL="S" CNAM="EWH" CDAT="20060903" UNAM="USEWH90" UDAT="20070205" VERN="000167" RMAND="321" RLOAD="E" FIXPT="X" SDATE="20070205" STIME="140744" IDATE="20070205" ITIME="140744" LDBNAME="D$S" UCCHECK="X">
> +<PROG NAME="ZSAPLINK" VARCL="X" DBAPL="S" DBNA="D$" SUBC="1" APPL="S" CNAM="EWH" CDAT="20060903" UNAM="ITENFR" UDAT="20071025" VERN="000169" RMAND="321" RLOAD="E" FIXPT="X" SDATE="20071025" STIME="111826" IDATE="20071025" ITIME="111826" LDBNAME="D$S" UCCHECK="X">
> <textPool>
> <language SPRAS="D">
> <textElement ID="I" KEY="NGA" ENTRY="Objekt zum Nugget hinzufügen" LENGTH="28 "/>
> @@ -806,6 +806,7 @@
> xml = zsapLink=>convertIxmlDoctoString( ixmlDocument ).
>
> concatenate plugin '_' _objName '.slnk' into defFilename.
> + replace all occurrences of '/' in deffilename with '-'.
> clear errorFlag.
> perform downloadXMLtoLM using defFilename xml
> changing errorFlag.
Nicola Fankhauser
Hans Senden wrote:
> i had a problem with creating a new nudget. It results in a dump, so i
> put some extra code in subroutine PUTONMACHINE to remove the incorrect
> characters in the filename.
see, that's what I meant. :)
furthermore I observed that you saplink-guys seem to hate
pretty-printing; ZSAPLINK is a mixture between 'all lowercase' and
'lower case, keywords upper case' etc.
could we settle in this project with a standard, preferably (like SAP
mostly does and a lot of other coders do too) 'lower case, keywords
upper case' with indentation?
this is especially a PITA when trying to create minimal patches... :(
regards
nicola