Sahanathon Project Request

2 views
Skip to first unread message

ashwyn sharma

unread,
Feb 19, 2012, 12:04:23 AM2/19/12
to sahan...@googlegroups.com
Hi Fran,
I have gone through the available tasks in the list provided for the Sahanathon.And i find the project listed as :"Community Management Tool:Subscribe to Ticket Categories: Subscription" of interest to me .
It will be really great if you could direct me on how to approach this project and how i could get involved.Hope i could contribute asap.
Thanks.
Regards,
-Ashwyn

On Friday, February 17, 2012, Fran Boon wrote:
On 16 February 2012 19:32, Michael Howden <mic...@sahanafoundation.org> wrote:
>> Currently the Sahanathon tasks are in a gSpreadsheet in the right format
>> to import into an Eden instance. If there are any bugs in Trac *which are
>> relevant to the Sahanathon* (of which I'm unaware of any) then they can be
>> added to this spreadsheet....however the Sahanathon is not (as far as I'm
>> aware) a general bugfixing.
> I would hope that this would happen as we start testing the solution.

Only modules relevant for the community management tool will be being
tested...of course there may be the odd bug in the core & there can
certainly be UI suggestions which are cross-module. Since our focus
for the weekend will be on this system then all issues relevant to
this system should be logged here (1 place to look)
Post-event we definitely need to again have only 1 place to look, so
either we agree to move the open Trac issues to the Eden instance or
vice versa.
> we can't rely on everyone arriving at time, but I hope that most people
> will (look at the roster). I'm sure that there will still be tasks for those
> who join later.

Yes, I'm sure there will :)
Just want to be sure that those ppl have suitable 'getting started'
materials available rather than the whole focus for that being a
synchronous meeting...

>>> Review - We share what we've done&  check where the gaps are.
>> So this is Sunday morning, right?
> See the roster. 2200 Saturday Night.
>> Again, I'm not sure if everyone will be able to attend, but am keen
>> for a core group to do this indeed.
> I'm aware that not everyone will be able to attend,
>> We might need to have more than one of these - I'd be keen for perhaps
>> 2 on Sat&  2 on Sun.
> Really? I guess that these could be quick check-ins. Are you saying 2 in
> total? or 4?

I'm saying 4 - yes I see the need for more frequent quick check-ins of
the core team, which can include 'how's the process going?' not just
'how's the product going?' .
I guess there is also value in a more public wider review & this can
mark a nice break between the focus on building to the focus on
testing/polish.
Although I suspect that Mark (& maybe some others) will be working on
Testing before that though...

F

--
You received this message because you are subscribed to the Google Groups "Sahana-Eden" group.
To post to this group, send email to sahan...@googlegroups.com.
To unsubscribe from this group, send email to sahana-eden...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/sahana-eden?hl=en.

Fran Boon

unread,
Feb 19, 2012, 4:58:01 AM2/19/12
to sahan...@googlegroups.com
On 19 February 2012 05:04, ashwyn sharma <ashwy...@gmail.com> wrote:
> I have gone through the available tasks in the list provided for the
> Sahanathon.And i find the project listed as :"Community Management
> Tool:Subscribe to Ticket Categories: Subscription" of interest to me .
> It will be really great if you could direct me on how to approach this
> project and how i could get involved.Hope i could contribute asap.

Hi Ashwyn,

Great to see you keen to get started already :)

So this is Row 17.
The proposal that I put forward for this instance was to have a group
per Category & then what is needed for this task would be to provide a
simple UI whereby someone can manage their own group memberships (for
these subscription groups).
Whilst this would work, I'm not actually sure now that this is the
best approach.
We have a 'Saved Search & Subscription' functionality whereby (if the
deployment_setting is enabled) *every* search form includes an option
to Save the search, so that each person can provide a list of
personalised searches on data that interest them. Each of these Saved
Searches can then be Subscribed to by the user so that they can
receive notifications whenever any new record is added to this Search
result set.
Since we have this functionality already, and it's a lot more flexible
than hard-coded groups, then I would propose that we use that for this
functionality.

However, having said that we have it already, as far as I know it
hasn't been tested recently and there have been some significant
changes which may have broken something.
Also, even if it is working, the Usability could well do with
improving (I've not personally tested this end-to-end so am not sure).
So where I'd start is to get a local development environment setup
(Trunk will do just fine) & run through this process - configure the
deployment_settings to enable Saved Searches, configure Email (&
SMS/Twitter too if you like!) & run through the process, including as
a non-Admin user. See if it works, see if is easy/pleasant to use &
report back.
Any UserGuidelines or Selenium Tests (maybe starting with simple IDE)
that you care to develop would be great along the way.

PS I see you've added your name to the list, but you've not yet marked
your expected availability (I know there's no Legend - simply add Grey
to the timeboxes you are likely to manage):
https://docs.google.com/spreadsheet/ccc?key=0AuNG6ihli0CudDFCWXc4MVc5bVk1YnhUUEJGenllMkE#gid=0

Best Wishes,
Fran.

ashwyn sharma

unread,
Feb 20, 2012, 1:37:14 AM2/20/12
to sahan...@googlegroups.com

Hi Fran,
Thanks for the info.I ll start with it straight-away. I have added my availability time slots  on the list as well.Looking forward to contribute as much as possible.
Regards
-Ashwyn

On 19-Feb-2012 3:28 PM, "Fran Boon" <franc...@gmail.com> wrote:

On 19 February 2012 05:04, ashwyn sharma <ashwy...@gmail.com> wrote:

> I have gone through the ava...

--
You received this message because you are subscribed to the Google Groups "Sahana-Eden" group.

...

ashwyn sharma

unread,
Feb 22, 2012, 1:06:43 PM2/22/12
to sahan...@googlegroups.com
Hi Fran,
With reference to our last conversation regarding the "Saved searches and subscriptions" usability (row 17 of ssf eden tasks for sahanathon), I have deployed and configured the functionality.And it seems to be working fine.
However,a few improvements in the UI are certainly required according to me.
--one of them is that the value of the saved search(i.e. the string that was searched for is not visible in the saved searches tab when the user clicks on "View and Subscribe to Saved Searches Here"
I am also trying to put up a few selenium tests.It will be great if you could give me heads up so as how to approach this from now on.
I will be ready to discuss all other issues as when and you want me to do them.
Thanks
Regards,
-Ashwyn

Fran Boon

unread,
Feb 22, 2012, 1:14:39 PM2/22/12
to sahan...@googlegroups.com
On 22 February 2012 18:06, ashwyn sharma <ashwy...@gmail.com> wrote:
> With reference to our last conversation regarding the "Saved searches and
> subscriptions" usability (row 17 of ssf eden tasks for sahanathon), I have
> deployed and configured the functionality.And it seems to be working fine.

Great, well done :)

> However,a few improvements in the UI are certainly required according to me.
> --one of them is that the value of the saved search(i.e. the string that was
> searched for is not visible in the saved searches tab when the user clicks
> on "View and Subscribe to Saved Searches Here"

That would indeed seem pretty useful, if not essential :)

> I am also trying to put up a few selenium tests.It will be great if you
> could give me heads up so as how to approach this from now on.
> I will be ready to discuss all other issues as when and you want me to do
> them.

I suggest that you try to fix the issue you identified & submit a Pull
request on GitHub.

If you'd like to write up a little list of any other issues &
potential solutions then that would be great too :)

Best Wishes,
Fran.

ashwyn sharma

unread,
Mar 7, 2012, 9:23:12 AM3/7/12
to sahan...@googlegroups.com
Hi Fran,

I have tested the "saved searches and subscriptions" functionality and it seems to be working fine.Though i have identified a few issues and rather feature enhancements that may help improve the utility.

--The saved searches table in the saved searches tab in personal details should also show the value of search_vars.I am putting up a code snippet here to show the possible change that could be made along with the screenshot of the enhancement(see attachment).I have here proposed to put up a new function give_search_vars() in the pr.py controller.However, as you told me on the IRC to try incorporate it in the existing REST implemetation.I am still trying to figure it out.

def give_search_vars():    #this function returns the string valued "search_vars" field in pr_save_search table.
   var = {}
   var["load"] = request.args[0]
   table = s3db.pr_save_search
   rows = db(table.id == request.args[0]).select(table.ALL)
   import cPickle
   for row in rows:
       search_vars = cPickle.loads(row.search_vars)
       break

   return search_vars["criteria"]["org_search_text_advanced"]

--Also i noticed that due to recent changes,even the search criteria is not visible in the same table, as pratyush has logged in the trac.Though he tells me that he has figured out the problem so that is fine.

--Subscription seems to be working fine also,though i have not tested that rigorously.

--While working on this functionality, i have also figured out a few issues with the inbound mail as i reported once on the IRC.Though i will try figuring it out a little more,after discussing it out with some other community members.
 
 Now,this was mainly about "Community management tool" project from sahanathon eden tasks(row 17 in [1]).As i have reported
the working condition of saved searches and subscription, it will be great if you can elaborate on how do you plan to use it for "subscription to ticket categories" project.Anything else that you would like me to do, i will love to work it out.
Regards
-Ashwyn

[1]- https://docs.google.com/spreadsheet/ccc?key=0AgESuewSG-wodDlmSWNfZ3lLYVlkUVVKOF9NYVlvZ0E#gid=0  
> --
> You received this message because you are subscribed to the Google Groups "Sahana-Eden" group.
savedsearch_existing.PNG
savedsearch_enhancement.PNG

Pratyush Nigam

unread,
Mar 8, 2012, 2:58:17 AM3/8/12
to Sahana-Eden
Hi Ashwyn,

It is really nice to see that you are coming up with some good hacks
and also testing it all along :) . However, I notice that the code
snippet that you have pasted here is going to work only if the module
for which the search is saved is "org". Also, the text searched and
advanced filters should be there along with the Resource and Module in
the Search Criteria column, as without them the user will not be able
to distinguish between two different search done on the same module
and resource.

Let me know if you might need any help. I will try and reply as quick
as I can.

Regards,
Pratyush
> [1]-https://docs.google.com/spreadsheet/ccc?key=0AgESuewSG-wodDlmSWNfZ3lL...
>
>
>
>
>
>
>
>
>
> On Wednesday, February 22, 2012, Fran Boon <francisb...@gmail.com> wrote:
>  savedsearch_existing.PNG
> 50KViewDownload
>
>  savedsearch_enhancement.PNG
> 51KViewDownload

ashwyn sharma

unread,
Mar 8, 2012, 4:51:11 AM3/8/12
to sahan...@googlegroups.com
Hi Pratyush,

 However, I notice that the code
snippet that you have pasted here is going to work only if the module
for which the search is saved is "org".

Ah yes, i figured it out in the beginning itself.I just showed it for the org only.I have found 'em out for all the modules(i have tried to cover all :), if any are left i will do it for them also) that employ the saved searches functionality. I am listing the keys for other modules below.

------------
assets:
search_vars["criteria"]["asset_search_text"]

hrm:
search_vars["criteria"]["human_resource_search_simple_simple"]

org/office:
search_vars["criteria"]["office_search_text"]

hrm/training_event:
search_vars["criteria"]["training_event_search_simple"]

hrm/training:(for searching training participants)
search_vars["criteria"]["training_search_simple"]

inv/warehouse:
search_vars["criteria"]["warehouse_search_text"]

inv/inv_item:(for searching warehouse stock)
search_vars["criteria"]["inv_item_search_text"]

inv/recv:
search_vars["criteria"]["recv_search_text_simple"]

supply/catalog_item:
search_vars["criteria"]["catalog_item_search_simple_simple"]

gis/location:
search_vars["criteria"]["location_search_text_simple"]

vehicle/vehicle:
search_vars["criteria"]["vehicle_search_text"]

hms/hospital:
search_vars["criteria"]["hospital_search_advanced"]

irs/ireport:
search_vars["criteria"]["incident_search_simple"]

dvi/body:
search_vars["criteria"]["body_search_simple"]

mpr:
search_vars["criteria"]["person_search_simple"]
---------------


 Also, the text searched and
advanced filters should be there along with the Resource and Module in
the Search Criteria column, as without them the user will not be able
to distinguish between two different search done on the same module
and resource.


Yes,exactly.And that's why making the searched text visible in the table will make it easier to distinguish for the user.
However, i am not sure using a hard coded function like this is the best approach,but it will certainly deliver what is required.
Any suggestions you have on this will really help me understand more about the working of this utility.
Thanks.
Regards,
-Ashwyn
Reply all
Reply to author
Forward
0 new messages