bug in new version of notebook source browser

11 views
Skip to first unread message

William Stein

unread,
Feb 10, 2012, 3:23:14 PM2/10/12
to sage-notebook
Hi,

When preparing for class just now, I think I found a bug in the flask
sage notebook file browser.

Visit http://test.sagenb.org/src/libs and click on a directory or up.
In both cases "/src/" vanishes from the URL. Basically all the links
in the source browser are missing /src, which wrecks browse-ability.

-- William

--
William Stein
Professor of Mathematics
University of Washington
http://wstein.org

William Stein

unread,
Feb 10, 2012, 3:26:22 PM2/10/12
to sage-notebook
Another, much worse bug is that pxd files are displayed all messed up:

http://test.sagenb.org/src/rings/integer.pxd

I think this is a significant new regression in the notebook, which
wasn't in the old version.

Jason Grout

unread,
Feb 10, 2012, 6:09:55 PM2/10/12
to sage-n...@googlegroups.com
On 2/10/12 2:26 PM, William Stein wrote:
> Another, much worse bug is that pxd files are displayed all messed up:
>
> http://test.sagenb.org/src/rings/integer.pxd
>
> I think this is a significant new regression in the notebook, which
> wasn't in the old version.

This is a one-character (nay, a one-bit) typo in flask_version/base.py
(it says 'pyd', but should say 'pxd').

I'll look into the /src problem...

Thanks,

Jason

Jason Grout

unread,
Feb 11, 2012, 7:43:37 AM2/11/12
to sage-n...@googlegroups.com
On 2/10/12 2:23 PM, William Stein wrote:
> Hi,
>
> When preparing for class just now, I think I found a bug in the flask
> sage notebook file browser.
>
> Visit http://test.sagenb.org/src/libs and click on a directory or up.
> In both cases "/src/" vanishes from the URL. Basically all the links
> in the source browser are missing /src, which wrecks browse-ability.

Okay, both this bug and the pxd bug are fixed and live on sagenb.org.
The problem with the /src/ URL was that the autoindex documentation was
wrong. It said that it defaulted to not creating any URLs, but in fact
the code defaults to creating mappings for /. That meant that the
generated URLs used / instead of /src.

Both of these bugs were fixed in
https://github.com/sagemath/sagenb/commit/2a6f2726822e0537bf0947a426500f8fc9a186ee

Thanks,

Jason

Reply all
Reply to author
Forward
0 new messages