[test by ...] byline in trac

0 views
Skip to first unread message

mabshoff

unread,
Oct 17, 2007, 11:10:07 PM10/17/07
to sage-devel
Hello,

recently we have started using [tested by ..] in trac. This seems to
have lead to some misunderstanding, see http://www.sagetrac.org/sage_trac/ticket/910
[but I have fixed that now, see check out the log toward the end]

The idea behind [tested by ...] is not that the original author of a
patch tested it with "-testall" [that ought to be generally assumed I
hope], but that it was tested with the combined other patches targeted
for a particular milestone, in order to flush out side effects with
the other patches. For 2.8.7 Carl Witty volunteered to do that, so
that is why a lot of the patches for 2.8.7 carry the byline [tested by
cwitty]. Hope that clears things up, I plan to spend at least some
time during Bug Day 4 to get the text from my presentation about trac
from SD5 ready for inclusion in the documentation.

Does anybody have suggestions where this should go? At least some of
it should end up in the wiki to have a page where I keep a log of what
has been changed and updated.

Cheers,

Michael

William Stein

unread,
Oct 17, 2007, 11:16:37 PM10/17/07
to sage-...@googlegroups.com
On 10/17/07, mabshoff > recently we have started using [tested by ..]

in trac. This seems to
> have lead to some misunderstanding, see http://www.sagetrac.org/sage_trac/ticket/910
> [but I have fixed that now, see check out the log toward the end]
>
> The idea behind [tested by ...] is not that the original author of a
> patch tested it with "-testall" [that ought to be generally assumed I
> hope], but that it was tested with the combined other patches targeted
> for a particular milestone, in order to flush out side effects with
> the other patches. For 2.8.7 Carl Witty volunteered to do that, so
> that is why a lot of the patches for 2.8.7 carry the byline [tested by
> cwitty]. Hope that clears things up, I plan to spend at least some

It was something he and I just made up on the fly when working
on the 2.8.7 release. It's not surprising it is causing confusion, though.
Thanks for clarifying our intention, which you understand correctly.

> time during Bug Day 4 to get the text from my presentation about trac
> from SD5 ready for inclusion in the documentation.
>
> Does anybody have suggestions where this should go? At least some of
> it should end up in the wiki to have a page where I keep a log of what
> has been changed and updated.

I think something should also go in the programming guide:

http://sagemath.org/doc/html/prog/index.html

You can send patches against that by editing
SAGE_ROOT/devel/doc/prog/prog.tex

and doing hg_docs.ci()


William

Reply all
Reply to author
Forward
0 new messages