Removing sage/structure/element_verify.py?

30 views
Skip to first unread message

Jeroen Demeyer

unread,
Sep 25, 2012, 3:14:56 PM9/25/12
to sage-devel
I bumped by chance on the file sage/structure/element_verify.py

This file:
1) is ophaned, i.e. nothing else in Sage depends on it
2) isn't mentioned in a single Trac ticket
3) hasn't seen any serious modifications since its creation in 2006
4) doesn't have any doctest

So my guess is that it isn't used for anything anymore and should be
removed. Any opinions?

David Roe

unread,
Sep 25, 2012, 3:59:34 PM9/25/12
to sage-...@googlegroups.com
I agree that this file should be removed.  The verification that it's doing should be performed by TestSuite now.  We should ensure that all of the conditions checked in this file are still checked when running the TestSuite on ring elements, module elements, etc.
David


--
You received this message because you are subscribed to the Google Groups "sage-devel" group.
To post to this group, send email to sage-...@googlegroups.com.
To unsubscribe from this group, send email to sage-devel+...@googlegroups.com.
Visit this group at http://groups.google.com/group/sage-devel?hl=en.



kcrisman

unread,
Sep 25, 2012, 4:02:24 PM9/25/12
to sage-...@googlegroups.com, roed...@gmail.com


On Tuesday, September 25, 2012 3:59:59 PM UTC-4, David Roe wrote:
I agree that this file should be removed.  The verification that it's doing should be performed by TestSuite now.  We should ensure that all of the conditions checked in this file are still checked when running the TestSuite on ring elements, module elements, etc.
David

Note also that it still refers to sagex - a sure sign of something not in much use. 
Reply all
Reply to author
Forward
0 new messages