Except setting testing in FLINT off!
Jaap
It takes like 2-3 hours to run on some of my build machines, nearly
doubling the time of building Sage from source.
> In Sage 4.0 I will hopefully have a more flexible system for testing
> so that people who don't want to run the "mandated" testing can turn
> it off more easily.
What's wrong with the current SAGE_CHECK (or whatever) system where
spkg-check is run only if a certain environment variable is set?
>
> Originally FLINT 1.2.5 was supposed to go into 3.4.2, but while
> testing it I saw a doctest failure in some cohomology code and I did
> not feel like tracking this down since the main change in FLINT 1.2.5
> was the update to zn_poly 0.9 (which contained a fix that was supposed
> to resolve the problem completely). The issue that popped up might
> also be a padics problem since 2/3 of the doctest failure has been
> resolved by the new zn_poly, I guess we might find out in Sage 4.0 or
> 4.0.x. ;)
>
Good.
This testing feels ok for alpha and rc releases, but not on a final
source release. IIRC this was standard procedure.
Jaap
Agreed, but how often did you get feedback from failures in the FLINT
library from users of the 'real' releases in the field?
> You wouldn't consider running the test suite a waste of time either I
> assume. If someone really wants to we can introduce a special
> SAGE_CHECK_OVEWRITE flag that completely turns off all checks if
> anyone does thing this is really desirable, but I am hesitant to do
> so. Testing makes software better and way too often has a point
> upgrade that was supposedly safe introduced problems, so I am always
> in favor of testing.
>
+1 for the last sentence.
On relative slow hardware it looks like a good idea to make
installation of ATLAS and e.g. FLINT less time consuming.
Jaap
On Fedora 9, 32 bit upgraded from alpha0 -> rc0-> sage-3.4.2
and on Fedora 10, 32 bit upgraded from rc0 I get tons
of failures with prime_pi, e.g.:
sage -t "devel/sage/sage/functions/prime_pi.pyx"
**********************************************************************
File "/home/jaap/Download/sage-3.4.2.rc0/devel/sage/sage/functions/prime_pi.pyx", line 74:
sage: prime_pi(7)
Exception raised:
Traceback (most recent call last):
File "/home/jaap/Download/sage-3.4.2.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/home/jaap/Download/sage-3.4.2.rc0/local/bin/sagedoctest.py", line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
File "/home/jaap/Download/sage-3.4.2.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_3[2]>", line 1, in <module>
prime_pi(Integer(7))###line 74:
sage: prime_pi(7)
File "prime_pi.pyx", line 175, in sage.functions.prime_pi.PrimePi.__call__ (sage/functions/prime_pi.c:1101)
NotImplementedError: computation of prime_pi() greater 2**40 not implemented
**********************************************************************
File "/home/jaap/Download/sage-3.4.2.rc0/devel/sage/sage/functions/prime_pi.pyx", line 76:
sage: prime_pi(100)
Exception raised:
Jaap
I'm ready to give this patch a positive review :)
./sage -t "devel/sage/sage/functions/prime_pi.pyx"
sage -t "devel/sage/sage/functions/prime_pi.pyx"
[48.1 s]
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 48.1 seconds
Jaap
>
> Good. I tested on 32 and 64 bit and it works for me, too. The patch is
> formally up and the ticket is also open against 3.4.2, so feel free to
> review. I will wait for all my other build tests to finish doctesting
> before pushing out the new tarball (just in case something else pops
> up).
>
As a follow up: on Fedora 9 and Fedora 10, 32 bit all tests passed
after applying the patch.
Jaap
>
> Hello folks,
>
> the final release for 3.4.2 is done and sources, the upgrade bits and
> a sage.math binary are in the usual place at
>
> http://sage.math.washington.edu/home/mabshoff/release-cycles-3.4.2/
Built on Mac OS X, 10.5.6 (Dual Quad Xeon) with no problems.
Before patch #5981, I got these failures:
sage -t "devel/sage/sage/combinat/sloane_functions.py"
sage -t "devel/sage/sage/functions/prime_pi.pyx"
sage -t "devel/sage/sage/functions/transcendental.py"
sage -t "devel/sage/sage/numerical/optimize.py"
sage -t "devel/sage/sage/tests/book_stein_ent.py"
After applying the patch, I reran all the tests, and all passed.
Justin
--
Justin C. Walker, Curmudgeon at Large
Director
Institute for the Enhancement of the Director's Income
-----------
Nobody knows the trouble I've been
-----------
For this reason I would love to be able to be able to make a selective upgrade
and say something like "upgrade everything except for ATLAS this time"
(for example, assume that the last ATLAS has some fixes that are only
for another
architecture...
Pablo