Tweaking the sagenb spkg install script for Cygwin

[Jean-Pierre Flori]

Hi all,

Dima spotted a problem while installing the new sagenb on Cygwin.
To get things quickly in, I'll take care of this by tweaking the spkg-install script, but don't know if  there is some special procedure as this is related to the new notebook.

Should I just open a ticket on Sage's Trac and post an updated spkg?
Or is this file included in the sagenb github and so I should clone the repo and modify some files there?

Best,
JP

[Dima Pasechnik]

On Sunday, 5 August 2012 22:56:05 UTC+8, Jean-Pierre Flori wrote:

Hi all,

Dima spotted a problem while installing the new sagenb on Cygwin.
To get things quickly in, I'll take care of this by tweaking the spkg-install script, but don't know if  there is some special procedure as this is related to the new notebook. 

Should I just open a ticket on Sage's Trac and post an updated spkg?

Please see #13344. The bug is elsewhere, imho; some package moves on Cygwin everything that looks like "lib" to SAGELOCAL/lib/. I doubt sagenb is guilty here...

[Jean-Pierre Flori]

On Sunday, August 5, 2012 6:17:51 PM UTC+2, Dima Pasechnik wrote:

On Sunday, 5 August 2012 22:56:05 UTC+8, Jean-Pierre Flori wrote:

Hi all,

Dima spotted a problem while installing the new sagenb on Cygwin.
To get things quickly in, I'll take care of this by tweaking the spkg-install script, but don't know if  there is some special procedure as this is related to the new notebook. 

Should I just open a ticket on Sage's Trac and post an updated spkg?

Please see #13344. The bug is elsewhere, imho; some package moves on Cygwin everything that looks like "lib" to SAGELOCAL/lib/. I doubt sagenb is guilty here...

I agree.
And this should be easy to fix and to integrate in the latest Singular spkg at #13237.

But, for future purposes, could someone enlighten us on how spkg-install should be modified?

[Jeroen Demeyer]

On 2012-08-05 18:24, Jean-Pierre Flori wrote:
> But, for future purposes, could someone enlighten us on how spkg-install
> should be modified?

See http://sagemath.org/doc/developer/sagenb/index.html
for instructions for Sage Notebook development.

[Jean-Pierre Flori]

I've read that and hopefully I understand how to replace the sagenb directory in an existing sage install with a git clone of the repo.
But what if I want to distribute some tar file of a source Sage distribution, with a sagenb-*.spkg file within it?
And more specifically, what if I would like to get a patch to spkg-install integrated upstream (which seems to be part of Sage, or of the "spkg", rather than of sagenb).
Does this file belong to the notebook (let's understand that as all the files within the git repo) or not?
I'd say no.
It seems to me that within the sagenb*.spkg, the git repo is cloned in ./src/sagenb and that all that is above that does not belong to the repo.
Therefore if I want to modify these pieces (for example, modifying spkg-install), I'd say that I should post a ticket on Sage's trac with an updated spkg.
Is that correct?
Or is there some sagenb-spkg repo somewhere?

[leif]

On 5 Aug., 22:05, Jean-Pierre Flori <jpfl...@gmail.com> wrote:
> But what if I want to distribute some tar file of a source Sage
> distribution, with a sagenb-*.spkg file within it?
> And more specifically, what if I would like to get a patch to spkg-install
> integrated upstream (which seems to be part of Sage, or of the "spkg",
> rather than of sagenb).

You cannot patch spkg-install, at least not directly, as it is created
each time you run spkg-dist, which is the way you create a new SageNB
spkg.

SageNB's spkg-dist is located in devel/sagenb/, although you can of
course just take any existing SageNB spkg, modify src/sagenb/spkg-
dist, and run it to create a new spkg with the "patched" spkg-install
in its top-level directory. (Unfortunately you have to run spkg-dist
from within a Sage subshell IIRC.)

[For testing purposes, you can of course modify spkg-install in the
spkg's top-level directory directly, and use 'tar' to "manually"
create a new spkg.]

> Does this file belong to the notebook (let's understand that as all the
> files within the git repo) or not?
> I'd say no.

I'd say yes... ;-)


-leif

[Jean-Pierre Flori]

SageNB's spkg-dist is located in devel/sagenb/, although you can of
course just take any existing SageNB spkg, modify src/sagenb/spkg-
dist, and run it to create a new spkg with the "patched" spkg-install
in its top-level directory.  (Unfortunately you have to run spkg-dist
from within a Sage subshell IIRC.)

Thanks a lot, that's much clearer.
Maybe the fact that spkg-dist actually generates the spkg (or the directory structure within it or what I did not have the time to look at) should be mentioned on the sagenb development page as well.