No patch applied

[Rolf]

To be honest, I the Sage review process seems cumbersome to me.

Following the instructions (http://www.sagemath.org/doc/developer/
walk_through.html) I cloned a sub directory to hold my newly
implemented gsl probability distributions (binomial and negative
binomial to name only two). These work fine with my system.

Next, I wanted to contribute these new distributions. As there already
exists a patch for the F distribution (http://trac.sagemath.org/
sage_trac/attachment/ticket/9080/trac_9080-rebased.patch), I wanted to
review this first, but following the instructions for 'Reviewing a
patch' [hg_sage.apply("<full-path-and-filename.patch>") etc.] did not
change anything perceptible. The F distribution still is not
available, and hg_sage.log() produces such a long list that even after
several minutes I became tired of scrolling down. When I check the
files that should be affected by the patch, nothing has changed.

[David Roe]

Did you rebuild Sage?  After typing 

hg_sage.apply("<full-path-and-filename.patch>")

you need to quit sage and type

sage -br at the command line.

David

--
To post to this group, send an email to sage-...@googlegroups.com
To unsubscribe from this group, send an email to sage-devel+...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

[Dima Pasechnik]

On Jun 23, 12:14 pm, Rolf <kamha...@googlemail.com> wrote:
> To be honest, I the Sage review process seems cumbersome to me.
>
> Following the instructions (http://www.sagemath.org/doc/developer/
> walk_through.html) I cloned a sub directory to hold my newly
> implemented gsl probability distributions (binomial and negative
> binomial to name only two). These work fine with my system.
>
> Next, I wanted to contribute these new distributions. As there already
> exists a patch for the F distribution (http://trac.sagemath.org/
> sage_trac/attachment/ticket/9080/trac_9080-rebased.patch), I wanted to
> review this first, but following the instructions for 'Reviewing a
> patch' [hg_sage.apply("<full-path-and-filename.patch>") etc.] did not
> change anything perceptible.

Probably you missed out the command to rebuild Sage library (i.e. exit
Sage and then run sage -b)

By the way, IMHO a better way for applying a patch is outside of Sage,
using hg's queues:
http://wiki.sagemath.org/MercurialQueues
http://www.sagemath.org/doc/developer/walk_through.html#being-more-efficient-mercurial-queues

[Rolf]

> Probably you missed out the command to rebuild Sage library (i.e. exit
> Sage and then run sage -b)

No. Of course, I didn't.

> By the way, IMHO a better way for applying a patch is outside of Sage,

> using hg's queues:http://wiki.sagemath.org/MercurialQueueshttp://www.sagemath.org/doc/developer/walk_through.html#being-more-ef...

I'll try that next.
Thanks
R

[kcrisman]

On Jun 23, 8:39 am, Rolf <kamha...@googlemail.com> wrote:
> > Probably you missed out the command to rebuild Sage library (i.e. exit
> > Sage and then run sage -b)
>
> No. Of course, I didn't.
>

Hmm, that is very odd. But your original message indicates something:

http://trac.sagemath.org/sage_trac/attachment/ticket/9080/trac_9080-rebased.patch

That should have given you a message about 'garbage in attachment' or
the like. Try applying

http://trac.sagemath.org/sage_trac/raw-attachment/ticket/9080/trac_9080-rebased.patch

Notice the "raw-attachment". (This is the link on the patch page that
says "Download in other formats: Original Format" at the bottom, or
the little link with a downward-facing arrow next to the main link for
the patch.) I've been tripped up many times by trying to download the
HTML file that is at the main link.

Otherwise this is quite mysterious.

By the way, you may find the ticket http://trac.sagemath.org/sage_trac/ticket/11514
interesting as well.

[Rolf]

Problem solved.
In fact, it was that URL problem.
Thanks for your help
R.