If I understand correctly, patchbot simply attempts every now and then to apply a patch to the most recent sage release. For the ticket http://trac.sagemath.org/sage_trac/ticket/11770, which has now received a positive review, patchbot keeps trying to apply the patches trac_11770_CM_field_functionality.patch and trac_11770_CM_field_functionality_v2.3.patch. However, the former patch is old and it should not be trying to apply it. Only v2.3 should be applied (hence patchbot keeps failing). Is there a way to tell patchbot to only apply v2.3? The person who gave a positive review edited the description to indicate to only apply v2.3, but patchbot doesn't seem to have caught on (though it is skipping v2, 2.1, and 2.2).
> Is there a way to tell patchbot to only > apply v2.3? The person who gave a positive review edited the description to > indicate to only apply v2.3, but patchbot doesn't seem to have caught on > (though it is skipping v2, 2.1, and 2.2).
Yes. First of all, if the ticket depends on another ticket, state it in
the dependency field. And if the ticket has several patches posted, but
only my_fine.patch and my_better.patch are to be applied *in that
order*, then write
Apply my_fine.patch my_better.patch
in some comment.
That's for the patchbot, which only reads the comments, but not the
ticket description.
If you want to help the release manager once the ticket has a positive
review, also state the to-be-applied patches in the ticket description.
On Sunday, September 2, 2012 1:10:36 PM UTC-5, Simon King wrote:
> Hi Rob!
> On 2012-09-02, Rob H. <robert...@gmail.com <javascript:>> wrote: > > ------=_Part_201_17510807.1346607445074 > > Content-Type: text/plain; charset=ISO-8859-1
> > Is there a way to tell patchbot to only > > apply v2.3? The person who gave a positive review edited the description > to > > indicate to only apply v2.3, but patchbot doesn't seem to have caught on > > (though it is skipping v2, 2.1, and 2.2).
> Yes. First of all, if the ticket depends on another ticket, state it in > the dependency field. And if the ticket has several patches posted, but > only my_fine.patch and my_better.patch are to be applied *in that > order*, then write
> Apply my_fine.patch my_better.patch
> in some comment.
> That's for the patchbot, which only reads the comments, but not the > ticket description.
> If you want to help the release manager once the ticket has a positive > review, also state the to-be-applied patches in the ticket description.
> That's for the patchbot, which only reads the comments, but not the
> ticket description.
IMHO, that's still a bug in the patchbot.
> If you want to help the release manager once the ticket has a positive
> review, also state the to-be-applied patches in the ticket description.
I would say: you *must* do this when it's not obvious which patches to
apply. You cannot rely on the fact that the release manager has read all
comments on the ticket. Besides, this also helps potential reviewers who
have not been following the whole history of the ticket.
On Sun, Sep 2, 2012 at 2:10 PM, Simon King <simon.k...@uni-jena.de> wrote:
> And if the ticket has several patches posted, but
> only my_fine.patch and my_better.patch are to be applied *in that
> order*, then write
> Apply my_fine.patch my_better.patch
> in some comment.
Is the "in that order" new? Around mid-July, it seemed to ignore the
order of the patches specified in the Apply directive and applied the
patches in the order in which they get attached *or updated*. At
least, that's what seemed to be happening here:
On Sun, Sep 2, 2012 at 5:19 PM, Jeroen Demeyer <jdeme...@cage.ugent.be> wrote:
> On 2012-09-02 20:10, Simon King wrote:
>> That's for the patchbot, which only reads the comments, but not the
>> ticket description.
> IMHO, that's still a bug in the patchbot.
>> If you want to help the release manager once the ticket has a positive
>> review, also state the to-be-applied patches in the ticket description.
> I would say: you *must* do this when it's not obvious which patches to
> apply. You cannot rely on the fact that the release manager has read all
> comments on the ticket. Besides, this also helps potential reviewers who
> have not been following the whole history of the ticket.
Would it be possible to have a "patches to apply" field on the ticket
(similar to the fields dependencies, keywords, etc.)? Then the release
manager, reviewers and patchbots would easily know where to look.
I've found that it is continually necessary to repost the apply directives for the patchbot. If I don't do this then whenever I update the patches in trac then the patchbot will attempt to apply everything -- I found this to be necessary with the trac tickets #9265 and #13072.
If Franco's suggestion isn't taken up would it be possible to make the patchbot follow the last apply directive given in the comments?
On Monday, 3 September 2012 11:20:11 UTC+10, Franco Saliola wrote:
> On Sun, Sep 2, 2012 at 5:19 PM, Jeroen Demeyer <jdem...@cage.ugent.be<javascript:>> > wrote: > > On 2012-09-02 20:10, Simon King wrote: > >> That's for the patchbot, which only reads the comments, but not the > >> ticket description. > > IMHO, that's still a bug in the patchbot.
> >> If you want to help the release manager once the ticket has a positive > >> review, also state the to-be-applied patches in the ticket description. > > I would say: you *must* do this when it's not obvious which patches to > > apply. You cannot rely on the fact that the release manager has read all > > comments on the ticket. Besides, this also helps potential reviewers who > > have not been following the whole history of the ticket.
> Would it be possible to have a "patches to apply" field on the ticket > (similar to the fields dependencies, keywords, etc.)? Then the release > manager, reviewers and patchbots would easily know where to look.
