2) NotImplementedError in 'Object#rm_r removes a symlink' symlink() function is unimplemented on this machine C:/Users/Luis/Projects/oss/mspec/spec/helpers/fs_spec.rb:142:in `symlink' C:/Users/Luis/Projects/oss/mspec/spec/helpers/fs_spec.rb:142
3) NameError in 'Object#rm_r removes a socket' uninitialized constant UNIXServer C:/Users/Luis/Projects/oss/mspec/spec/helpers/fs_spec.rb:149
3) NotImplementedError in 'Object#rm_r removes a symlink' symlink() function is unimplemented on this machine C:/Users/Luis/Projects/oss/mspec/spec/helpers/fs_spec.rb:142
4) NameError in 'Object#rm_r removes a socket' uninitialized constant UNIXServer C:/Users/Luis/Projects/oss/mspec/spec/helpers/fs_spec.rb:149
A simple approach will be usage of platform_is_not around it, but that seems chicken-egg-dinosaur for me.
Thoughts? -- Luis Lavena AREA 17 - Perfection in design is achieved not when there is nothing more to add, but rather when there is nothing more to take away. Antoine de Saint-Exupéry
You're right, it is a bit of a chicken and egg problem, but we have to
be able to account for Windows differences in the specs. Also, the
platform dependent helper functionality should not involve the code
for platform guards and vice versa.
So for now, let's just use the mspec platform guards in the mspec
specs as necessary. If we run into problems, we can revisit this.
I've pushed fixes to 3 of the 4 failures I had in the mspec specs on
Windows. The fourth failure involves Enumerator not being defined at
top level. This should be defined in 1.8.7+ and I'm using your
installation of 1.8.7p249. Would you be able to track down whether
this is a bug in the Windows version?
Cheers,
Brian
On Jul 23, 6:55 pm, Luis Lavena <luislav...@gmail.com> wrote:
> 2)
> NotImplementedError in 'Object#rm_r removes a symlink'
> symlink() function is unimplemented on this machine
> C:/Users/Luis/Projects/oss/mspec/spec/helpers/fs_spec.rb:142:in `symlink'
> C:/Users/Luis/Projects/oss/mspec/spec/helpers/fs_spec.rb:142
> 3)
> NameError in 'Object#rm_r removes a socket'
> uninitialized constant UNIXServer
> C:/Users/Luis/Projects/oss/mspec/spec/helpers/fs_spec.rb:149
> 3)
> NotImplementedError in 'Object#rm_r removes a symlink'
> symlink() function is unimplemented on this machine
> C:/Users/Luis/Projects/oss/mspec/spec/helpers/fs_spec.rb:142
> 4)
> NameError in 'Object#rm_r removes a socket'
> uninitialized constant UNIXServer
> C:/Users/Luis/Projects/oss/mspec/spec/helpers/fs_spec.rb:149
> A simple approach will be usage of platform_is_not around it, but that
> seems chicken-egg-dinosaur for me.
> Thoughts?
> --
> Luis Lavena
> AREA 17
> -
> Perfection in design is achieved not when there is nothing more to add,
> but rather when there is nothing more to take away.
> Antoine de Saint-Exupéry
On Sat, Jul 24, 2010 at 3:03 PM, Brian Ford <bri...@gmail.com> wrote: > Hi Luis,
> You're right, it is a bit of a chicken and egg problem, but we have to > be able to account for Windows differences in the specs. Also, the > platform dependent helper functionality should not involve the code > for platform guards and vice versa.
> So for now, let's just use the mspec platform guards in the mspec > specs as necessary. If we run into problems, we can revisit this.
> I've pushed fixes to 3 of the 4 failures I had in the mspec specs on > Windows.
You fixes differ from mine, which I forgot to push :-P
I used fmode helper for the IO and used Regexp.escape instead of using inspect due the quotes around it.
> The fourth failure involves Enumerator not being defined at > top level. This should be defined in 1.8.7+ and I'm using your > installation of 1.8.7p249. Would you be able to track down whether > this is a bug in the Windows version?
Investigating this. Will push a fix if needed.
Thank you. -- Luis Lavena AREA 17 - Perfection in design is achieved not when there is nothing more to add, but rather when there is nothing more to take away. Antoine de Saint-Exupéry
On Sat, Jul 24, 2010 at 3:11 PM, Luis Lavena <luislav...@gmail.com> wrote:
>> The fourth failure involves Enumerator not being defined at >> top level. This should be defined in 1.8.7+ and I'm using your >> installation of 1.8.7p249. Would you be able to track down whether >> this is a bug in the Windows version?
> Investigating this. Will push a fix if needed.
Interesting:
Specs says:
ruby_version_is '1.8.7' do it "returns Enumerator in Ruby 1.8.7+" do enumerator_class.should == Enumerator end end
but enumerator_class is this:
def enumerator_class SpecVersion.new(RUBY_VERSION) < "1.9" ? Enumerable::Enumerator : Enumerator end
Which will always return Enumerable::Enumerator with Ruby < 1.9
[ruby-1.8.7-p174] luis@ubuntu86:~/src/mspec$ spec spec/helpers/enumerator_class_spec.rb F
1) NameError in '#enumerator_class returns Enumerator in Ruby 1.8.7+' uninitialized constant Enumerator ./spec/helpers/enumerator_class_spec.rb:17:
Seems to me the spec is wrong? -- Luis Lavena AREA 17 - Perfection in design is achieved not when there is nothing more to add, but rather when there is nothing more to take away. Antoine de Saint-Exupéry
On Jul 24, 11:34 am, Luis Lavena <luislav...@gmail.com> wrote:
> On Sat, Jul 24, 2010 at 3:11 PM, Luis Lavena <luislav...@gmail.com> wrote:
> >> The fourth failure involves Enumerator not being defined at
> >> top level. This should be defined in 1.8.7+ and I'm using your
> >> installation of 1.8.7p249. Would you be able to track down whether
> >> this is a bug in the Windows version?
> > Investigating this. Will push a fix if needed.
> --
> Luis Lavena
> AREA 17
> -
> Perfection in design is achieved not when there is nothing more to add,
> but rather when there is nothing more to take away.
> Antoine de Saint-Exupéry