ActiveRecord errors in a custom FormBuilder

1 view
Skip to first unread message

Sheldon Hearn

unread,
Jan 10, 2007, 11:15:10 AM1/10/07
to Ruby on Rails: Talk
Hi there,

I'm trying to implement Simply Accessible's form error messages advice,
explained here:

http://simplyaccessible.org/article/form-error-messages

I'm trying to produce a custom FormBuilder to accomplish this. It's
based on the TaggedBuilder example in the AWDWR2 book.

Of course, I can't use error_messages_on inside my FormBuilder, so I
rolled my own method to acquire the first error message (if any) for an
ActiveRecord instance, and was stunned into submission by the results.

Could someone explain the cause of the BROKEN comment in my code below,
or suggest another approach?

Thanks,
Sheldon.

# Based on:
# TaggedBuilder from "Agile Web Development with Rails, 2nd Ed."
# We make no guarantees that this code is fit for any purpose.
# Visit http://www.pragmaticprogrammer.com/titles/rails2 for more
# book information.
#
class LabellingFormBuilder < ActionView::Helpers::FormBuilder

def first_error_message_on(label)
""
# BROKEN Debugging shows @object is always nil at this point,
# even though @object_name is set correctly! So we can't
# just do:
#
#errors = @object.errors.on(label)
#errors.respond_to? :first ? errors.first : errors
end

# <div class="labelled-form-input">
# <label for="product_description">
# Description
# <em>is too short</em>
# </label>
# <br/>
# <%= form.text_area 'description' %>
# </div>
def self.create_tagged_field(method_name)
define_method(method_name) do |label, *args|
@template.content_tag("div",
@template.content_tag("label",
label.to_s.humanize +
@template.content_tag("em", first_error_message_on(label)),
for => "#{@object_name}_#{label}") +
"<br/>" +
super,
:class => "labelled-form-input")
end
end

field_helpers.each do |name|
create_tagged_field(name)
end

end

Reply all
Reply to author
Forward
0 new messages