AR Relation docs

[Oscar Del Ben]

Hi guys,

I'm covering this file, and I've noticed that the bang version of the methods are not prefixed by no-doc.

Example:

includes!

preload!

join!

etc.

Should I go ahead and add no-docs to those?

-- 

Oscar Del Ben

[Ryan Bigg]

Depends. How are they different to their non-bang variants?

--
Ryan Bigg

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Documentation" group.
To post to this group, send email to rubyonra...@googlegroups.com.
To unsubscribe from this group, send email to rubyonrails-do...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/rubyonrails-docs?hl=en.

[Oscar Del Ben]

in general, the non bang version allows for empty arguments, and calls the bang version if everything looks good.

Example:

https://github.com/rails/rails/blob/b6ce2306cdbc5b074b75d5a22d6bfdc83a6a037a/activerecord/lib/active_record/relation/query_methods.rb#L181-190

-- 

Oscar Del Ben

Sent with Sparrow

[Ryan Bigg]

In that case then, yeah I would nodoc the bang versions

--
Ryan Bigg

[Oscar Del Ben]

will do

-- 

Oscar Del Ben

Sent with Sparrow