Gmail Calendar Documents Reader Web more »
Recently Visited Groups | Help | Sign in
Google Groups Home
framework gems are automatically marked frozen (even when they're not actually frozen)
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
J.D. Hollis  
View profile  
 More options Jun 24, 3:28 pm
From: "J.D. Hollis" <j...@densityofspace.com>
Date: Wed, 24 Jun 2009 12:28:02 -0700 (PDT)
Local: Wed, Jun 24 2009 3:28 pm
Subject: [PATCH] framework gems are automatically marked frozen (even when they're not actually frozen)
Could someone review my (first ever) patch?

I was running into a problem on 2-3-stable where rmagick is getting
added to the list of @@framework_gems in GemDependency when I run
'rake test'. Best I can tell, this is because rmagick is loaded before
any of the gem dependencies. Because framework_gem? returns true for
rmagick, when GemDependency#add_load_paths is called for rmagick, it
marks the gem as frozen (which it isn't). GemDependency#frozen? is
memoized, so a proper check is never performed.

When I run 'rake test,' I get:

The following gems have native components that need to be built
  rmagick

You're running:
  ruby 1.8.7.174 at /opt/local/bin/ruby
  rubygems 1.3.4 at /Users/jd/.gem/ruby/1.8, /opt/local/lib/ruby/gems/
1.8

Run `rake gems:build` to build the unbuilt gems.

https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2...


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
J.D. Hollis  
View profile  
 More options Jun 29, 5:00 pm
From: "J.D. Hollis" <j...@densityofspace.com>
Date: Mon, 29 Jun 2009 14:00:05 -0700 (PDT)
Local: Mon, Jun 29 2009 5:00 pm
Subject: Re: framework gems are automatically marked frozen (even when they're not actually frozen)
New version of the fix here:
https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/2...

Could someone review this?


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2009 Google