Google Groups Home Help | Sign in
Please review #8049 (PostgreSQL support)
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  10 messages - Collapse all
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
Hongli Lai  
View profile
 More options May 14 2007, 9:16 am
From: Hongli Lai <hongli...@gmail.com>
Date: Mon, 14 May 2007 06:16:13 -0700
Local: Mon, May 14 2007 9:16 am
Subject: Please review #8049 (PostgreSQL support)
Right now I'm working on implementing prepared statements in Ruby on
Rails, but the PostgreSQL unit tests fail, even before I've written
any code, because the PostgreSQL adapter has many problems. Can
someone please review the patch at http://dev.rubyonrails.org/ticket/8049
? This fixes a lot of PostgreSQL problems. It has been open for 2
months but no sign of being reviewed or accepted.

Thanks.


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jonathan Weiss  
View profile
 More options May 14 2007, 10:45 am
From: Jonathan Weiss <j...@innerewut.de>
Date: Mon, 14 May 2007 16:45:01 +0200
Local: Mon, May 14 2007 10:45 am
Subject: Re: [Rails-core] Please review #8049 (PostgreSQL support)
 > It has been open for 2

> months but no sign of being reviewed or accepted.

Yeah, can somebody please commit this. Without it using PostgreSQL 8.2
is really painfull.

Jonathan

--
Jonathan Weiss
http://blog.innerewut.de


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Alexey Verkhovsky  
View profile
 More options May 14 2007, 4:23 pm
From: "Alexey Verkhovsky" <alexey.verkhov...@gmail.com>
Date: Mon, 14 May 2007 14:23:51 -0600
Local: Mon, May 14 2007 4:23 pm
Subject: Re: [Rails-core] Please review #8049 (PostgreSQL support)
On 5/14/07, Hongli Lai <hongli...@gmail.com> wrote:

> Right now I'm working on implementing prepared statements in Ruby on
> Rails, but the PostgreSQL unit tests fail, even before I've written
> any code

Rails continuous build at
http://cruisecontrolrb.thoughtworks.com/builds/RubyOnRails runs
ActiveRecord unit tests with Postgres 8.2.3, among other things. And
it usually passes. Which directly contradicts your above statement.

So I wonder if it points to some error or omission in my build setup.
Can you, please, clarify the problem?

Your friendly build monkey,
Alex Verkhovsky


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mislav Marohnić  
View profile
 More options May 14 2007, 5:00 pm
From: "Mislav Marohnić" <mislav.maroh...@gmail.com>
Date: Mon, 14 May 2007 23:00:03 +0200
Local: Mon, May 14 2007 5:00 pm
Subject: Re: [Rails-core] Re: Please review #8049 (PostgreSQL support)

On 5/14/07, Alexey Verkhovsky <alexey.verkhov...@gmail.com> wrote:

> So I wonder if it points to some error or omission in my build setup.
> Can you, please, clarify the problem?

For me, Postgres only fails on schema creation/ownership tests
(test_schema_postgres.rb) because the user I'm testing with doesn't have
superuser permissions (but, IMO, it has all necessary permissions on the
test database). The setup (CREATE SCHEMA statement) fails, so naturally all
subsequent tests fail also.

    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Hongli Lai  
View profile
 More options May 14 2007, 5:59 pm
From: Hongli Lai <hongli...@gmail.com>
Date: Mon, 14 May 2007 14:59:07 -0700
Local: Mon, May 14 2007 5:59 pm
Subject: Re: Please review #8049 (PostgreSQL support)
On May 14, 10:23 pm, "Alexey Verkhovsky" <alexey.verkhov...@gmail.com>
wrote:

> On 5/14/07, Hongli Lai <hongli...@gmail.com> wrote:
> Rails continuous build athttp://cruisecontrolrb.thoughtworks.com/builds/RubyOnRailsruns
> ActiveRecord unit tests with Postgres 8.2.3, among other things. And
> it usually passes. Which directly contradicts your above statement.

> So I wonder if it points to some error or omission in my build setup.
> Can you, please, clarify the problem?

> Your friendly build monkey,
> Alex Verkhovsky

I'm running Ubuntu Linux 7.04 (Feisty) with PostgreSQL 8.2.4. I
checked out Rails edge (unmodified) from SVN. When I run 'rake
test_postgresql' in the activerecord directory, I get a ton of errors.
You can read them at:
http://izumi.plan99.net/ruby-postgresql-errors.txt

They're mostly related to string escaping. Because of these problems I
cannot use binary columns in Ruby on Rails project, which uses
PostgreSQL.


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Alexey Verkhovsky  
View profile
 More options May 14 2007, 6:13 pm
From: "Alexey Verkhovsky" <alexey.verkhov...@gmail.com>
Date: Mon, 14 May 2007 16:13:34 -0600
Local: Mon, May 14 2007 6:13 pm
Subject: Re: [Rails-core] Re: Please review #8049 (PostgreSQL support)
On 5/14/07, Hongli Lai <hongli...@gmail.com> wrote:

> I'm running Ubuntu Linux 7.04 (Feisty) with PostgreSQL 8.2.4. I
> checked out Rails edge (unmodified) from SVN. When I run 'rake
> test_postgresql' in the activerecord directory, I get a ton of errors.
> You can read them at:
> http://izumi.plan99.net/ruby-postgresql-errors.txt

> They're mostly related to string escaping. Because of these problems I
> cannot use binary columns in Ruby on Rails project, which uses
> PostgreSQL.

All the bitching about string escaping is at the warning level,
corresponding tests actually pass.

Errors all stem from this:
ERROR:  permission denied to create role: CREATE ROLE rails_pg_schema_user1

--
Alex Verkhovsky


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mislav Marohnić  
View profile
 More options May 14 2007, 6:18 pm
From: "Mislav Marohnić" <mislav.maroh...@gmail.com>
Date: Tue, 15 May 2007 00:18:31 +0200
Local: Mon, May 14 2007 6:18 pm
Subject: Re: [Rails-core] Re: Please review #8049 (PostgreSQL support)

On 5/14/07, Hongli Lai <hongli...@gmail.com> wrote:

> When I run 'rake
> test_postgresql' in the activerecord directory, I get a ton of errors.

Correction: you get a ton of warnings. There are no failures, except the
schema/roles one I described in my previous post. These are all because of
the first "ERROR: permission denied to create role".

But I agree that the Postgres adapter for Rails should use the database in a
way that doesn't spawn these warnings.


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mislav Marohnić  
View profile
 More options May 14 2007, 6:20 pm
From: "Mislav Marohnić" <mislav.maroh...@gmail.com>
Date: Tue, 15 May 2007 00:20:45 +0200
Local: Mon, May 14 2007 6:20 pm
Subject: Re: [Rails-core] Re: Please review #8049 (PostgreSQL support)

On 5/15/07, Alexey Verkhovsky <alexey.verkhov...@gmail.com> wrote:

> Errors all stem from this:
> ERROR:  permission denied to create role: CREATE ROLE
> rails_pg_schema_user1

Yes. But I have made sure the test user has create role privileges. It
doesn't help.

    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Hongli Lai  
View profile
 More options May 14 2007, 6:34 pm
From: Hongli Lai <hongli...@gmail.com>
Date: Mon, 14 May 2007 15:34:08 -0700
Local: Mon, May 14 2007 6:34 pm
Subject: Re: Please review #8049 (PostgreSQL support)
On May 15, 12:13 am, "Alexey Verkhovsky" <alexey.verkhov...@gmail.com>
wrote:

> On 5/14/07, Hongli Lai <hongli...@gmail.com> wrote:
> All the bitching about string escaping is at the warning level,
> corresponding tests actually pass.

> Errors all stem from this:
> ERROR:  permission denied to create role: CREATE ROLE rails_pg_schema_user1

Hm, you are correct. After fixing the permissions the unit tests pass,
though they still give the string warnings.
Thanks.

    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Hongli Lai  
View profile
 More options May 14 2007, 6:36 pm
From: Hongli Lai <hongli...@gmail.com>
Date: Mon, 14 May 2007 15:36:00 -0700
Subject: Re: Please review #8049 (PostgreSQL support)
On May 15, 12:20 am, "Mislav Marohnić" <mislav.maroh...@gmail.com>
wrote:

> Yes. But I have made sure the test user has create role privileges. It
> doesn't help.

You need to give it *all* privileges, including superuser.

    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2008 Google