Pull Requests or Patches

15 views
Skip to first unread message

Pan Thomakos

unread,
Mar 11, 2011, 8:37:16 PM3/11/11
to rubyonra...@googlegroups.com
Hi,

I was wondering, is it preferable to create GitHub pull requests or git patches for proposed code additions and bug fixes to the Rails core?

Thanks
Pan Thomakos

Ryan Bigg

unread,
Mar 11, 2011, 8:40:52 PM3/11/11
to rubyonra...@googlegroups.com
Yes it is, the big man himself replies to them as seen here: https://github.com/rails/rails/pull/204

-- 
Ryan Bigg

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To post to this group, send email to rubyonra...@googlegroups.com.
To unsubscribe from this group, send email to rubyonrails-co...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.

iain

unread,
Mar 19, 2011, 5:52:25 PM3/19/11
to Ruby on Rails: Core
Nice! The github pull requests are lovely :)

Should the guide on contributing be changed then?

Iain
Reply all
Reply to author
Forward
0 new messages