ActiveRecord conditions: Symbol or String
The group you are posting to is a
Usenet group . Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
From:
dnagir <dna... @gmail.com> Date: Thu, 19 Apr 2012 20:15:50 -0700 (PDT)
Local: Thurs, Apr 19 2012 11:15 pm
Subject: ActiveRecord conditions: Symbol or String
A quick question: in the query `Company.where(:status => :active)`, is it
It definitely works with no issues at all.
But there's a lot of controversy around that in the squeel: https://github.com/ernie/squeel/issues/67#issuecomment-5237083
Ernie explains that the use of Symbols in ActiveRecord wasn't assumed and
I personally feel a bit lost in this regard and it would be awesome if
Cheers,
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
Michael Koziarski <mich... @koziarski.com> Date: Fri, 20 Apr 2012 16:13:42 +1200
Local: Fri, Apr 20 2012 12:13 am
Subject: Re: [Rails-core] ActiveRecord conditions: Symbol or String
> Hi,
> A quick question: in the query `Company.where(:status => :active)`, is it OK to use the symbol (:active) as a value in the query?
> It definitely works with no issues at all.
I'm not sure I'd consider it a public stable API, but if it works, go wild :).
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
Dmytrii Nagirniak <dna... @gmail.com> Date: Fri, 20 Apr 2012 20:21:44 +1000
Local: Fri, Apr 20 2012 6:21 am
Subject: Re: [Rails-core] ActiveRecord conditions: Symbol or String
On 20/04/2012, at 2:13 PM, Michael Koziarski wrote:
>> Hi,
>> A quick question: in the query `Company.where(:status => :active)`, is it OK to use the symbol (:active) as a value in the query?
>> It definitely works with no issues at all.
> I'm not sure I'd consider it a public stable API, but if it works, go wild :).
So it is not a public API and the symbols were not supposed to be used this way? RIght?
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
Jon Leighton <j... @jonathanleighton.com> Date: Fri, 20 Apr 2012 13:30:16 +0200
Local: Fri, Apr 20 2012 7:30 am
Subject: Re: [Rails-core] ActiveRecord conditions: Symbol or String
On 20/04/12 12:21, Dmytrii Nagirniak wrote:
>>> Hi,
>>> A quick question: in the query `Company.where(:status => :active)`, is it OK to use the symbol (:active) as a value in the query?
>>> It definitely works with no issues at all.
>> I'm not sure I'd consider it a public stable API, but if it works, go wild :).
> So it is not a public API and the symbols were not supposed to be used this way? RIght?
It's not really good Ruby style. See
http://blog.hasmanythrough.com/2008/4/19/symbols-are-not-pretty-strings However I think we'd probably have to add specific code to make it *not*
-- http://jonathanleighton.com/
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
Dmytrii Nagirniak <dna... @gmail.com> Date: Mon, 23 Apr 2012 12:37:00 +1000
Subject: Re: [Rails-core] ActiveRecord conditions: Symbol or String
On 20/04/2012, at 9:30 PM, Jon Leighton wrote:
> On 20/04/12 12:21, Dmytrii Nagirniak wrote:
>>>> Hi,
>>>> A quick question: in the query `Company.where(:status => :active)`, is it OK to use the symbol (:active) as a value in the query?
>>>> It definitely works with no issues at all.
>>> I'm not sure I'd consider it a public stable API, but if it works, go wild :).
>> So it is not a public API and the symbols were not supposed to be used this way? RIght?
> It's not really good Ruby style. See http://blog.hasmanythrough.com/2008/4/19/symbols-are-not-pretty-strings
Do you mind to explain why exactly?
I get the difference between strings and symbols, but in the example of "status" the string is definitely a wrong candidate to me.
It is "internal" to the system.
Although I understand and ok with converting it to a string to query, I don't see why symbol isn't good in this case (`company.status == :active`).
> However I think we'd probably have to add specific code to make it *not* work, so it will probably continue to work in the future. But I wouldn't recommend doing it.
I think you guys have settled that symbols are not "officially supported" here
https://github.com/ernie/squeel/issues/67#issuecomment-5270896 So I'll take it for granted. Thanks a lot for the help.
Cheers.
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
Dmytrii Nagirniak <dna... @gmail.com> Date: Mon, 23 Apr 2012 13:50:45 +1000
Local: Sun, Apr 22 2012 11:50 pm
Subject: Re: [Rails-core] ActiveRecord conditions: Symbol or String
You must
Sign in before you can post messages.
You do not have the permission required to post.
