Client Rails 3.x and Ruby 1.9.3 support

48 views
Skip to first unread message

t.pickett66

unread,
Nov 2, 2012, 3:27:55 PM11/2/12
to rubycas...@googlegroups.com
Greetings list,

Just wanted to open up some dialog about improving rails 3.x support in the client. I've begun the process by partially moving the testing process to the use of a dummy rails app, because of the incompatibilities between 2.3 and the 3.x line it required a lot of hacking on the boot process but we now have all green tests using Ruby 1.8.7-p357 and Rails 2.3. Using Rails 3.x with any version of the interpreter has multiple failures but this isn't entirely unexpected. The mocking of controller calls that was done previously is still in place and this will probably be the next item I attack so we don't have to maintain these.

My work so far can be found in the rails-hydra branch in my company's fork and the pull request I've submitted so we can track comments there if that's the preference.

-Tyler

Matt Campbell

unread,
Nov 3, 2012, 7:10:24 PM11/3/12
to rubycas...@googlegroups.com
Tyler,

Thanks so much for these contributions! I haven't gotten a chance to review them yet, but I am excited, especially about you adding the automated integration tests against dummy rails apps. That has been a major obstacle to moving the the project forward, and removing that would be awesome!

Matt C

Sent from my iPad
--
You received this message because you are subscribed to the Google Groups "RubyCAS" group.
To view this discussion on the web visit https://groups.google.com/d/msg/rubycas-server/-/qprSgHke59cJ.
To post to this group, send email to rubycas...@googlegroups.com.
To unsubscribe from this group, send email to rubycas-serve...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/rubycas-server?hl=en.

t.pickett66

unread,
Nov 6, 2012, 3:19:34 PM11/6/12
to rubycas...@googlegroups.com
Everyone,

I've completed porting the client specs to using a 'real' rails app, the work can be found on GitHub in pull request #57. All of the specs are green under rails 2.3 but there are still some failures under all 3.x versions. The failures are all in the same place and relate to the session storage mechanisms. I've also noticed that the LocalDirTicketStore specs aren't writing the to the filesystem but rather the DB because of the way they are constructed. I'm going to focus on fixing the issues with Rails 3.x first, while I'm doing that someone may want to verify that I'm not missing something regarding the LocalDirTicketStore specs.

t.pickett66

unread,
Nov 7, 2012, 5:16:24 PM11/7/12
to rubycas...@googlegroups.com
All specs are passing with all versions of rails 2.3 - 3.2 with a single additional commit. That single commit is rather silly and shouldn't be necessary but it is.
Reply all
Reply to author
Forward
0 new messages