Gmail Calendar Documents Reader Web more »
Recently Visited Groups | Help | Sign in
Google Groups Home
DRYing a Regex
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  Messages 1 - 25 of 42 - Collapse all  -  Translate all to Translated (View all originals)   Newer >
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
RichardOnRails  
View profile  
 More options Nov 12, 6:00 pm
Newsgroups: comp.lang.ruby
From: RichardOnRails <RichardDummyMailbox58...@USComputerGurus.com>
Date: Fri, 13 Nov 2009 08:00:11 +0900
Local: Thurs, Nov 12 2009 6:00 pm
Subject: DRYing a Regex
I've got a routine that works fine at building an array of upper-case
strings extracted from a string:

aNewList = []
s = StringScanner.new sNewList
upper = /[A-Z]+/
not_upper= Regexp.new(  upper.source.sub( /\[/, '[^' )  )
while not s.eos?
  case
     when s.skip(upper); aNewList << s.matched
     else s.skip(not_upper)
  end
end

But the not_upper Regexp definition is really a kludge.  It somewhat
camouflages what is really /[^A-Z]+/

I'd like to DRY it by expressing it as something like !upper.  I need
something like !~ we use normally with string searches.

Any ideas?
--
Richard


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Caleb Clausen  
View profile  
 More options Nov 12, 6:24 pm
From: Caleb Clausen <vikk...@gmail.com>
Date: Fri, 13 Nov 2009 08:24:15 +0900
Local: Thurs, Nov 12 2009 6:24 pm
Subject: Re: DRYing a Regex
On 11/12/09, RichardOnRails

<RichardDummyMailbox58...@uscomputergurus.com> wrote:
> upper = /[A-Z]+/
> not_upper= Regexp.new(  upper.source.sub( /\[/, '[^' )  )
[snip]
> But the not_upper Regexp definition is really a kludge.  It somewhat
> camouflages what is really /[^A-Z]+/

> I'd like to DRY it by expressing it as something like !upper.  I need
> something like !~ we use normally with string searches.

This is somewhat better, but still not real obvious:
not_upper=/(?:.(?!#{upper}))+/  #untested, tho

Myself, I'd just write not_upper=/[^A-Z]/.... for something this
short, is it really worth trying all that hard to be DRY?


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
James Edward Gray II  
View profile  
 More options Nov 12, 6:50 pm
From: James Edward Gray II <ja...@graysoftinc.com>
Date: Fri, 13 Nov 2009 08:50:09 +0900
Local: Thurs, Nov 12 2009 6:50 pm
Subject: Re: DRYing a Regex
On Nov 12, 2009, at 5:00 PM, RichardOnRails wrote:

Well, you don't really need a StringScanner for this simple task.  Your code really just rebuilds String#scan():

  a_new_list = s_new_list.scan(/[A-Z]+/)

Note that I've also switched your variable naming style to the snake_case that we Rubyists prefer.

Hope that helps.

James Edward Gray II


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Caleb Clausen  
View profile  
 More options Nov 12, 7:34 pm
From: Caleb Clausen <vikk...@gmail.com>
Date: Fri, 13 Nov 2009 09:34:20 +0900
Local: Thurs, Nov 12 2009 7:34 pm
Subject: Re: DRYing a Regex
On 11/12/09, RichardOnRails

<RichardDummyMailbox58...@uscomputergurus.com> wrote:
> I've got a routine that works fine at building an array of upper-case
> strings extracted from a string:

> aNewList = []
> s = StringScanner.new sNewList
> upper = /[A-Z]+/
> not_upper= Regexp.new(  upper.source.sub( /\[/, '[^' )  )
> while not s.eos?
>   case
>      when s.skip(upper); aNewList << s.matched
>      else s.skip(not_upper)
>   end
> end

OTOH, you can rewrite it like this, and not have to even mention the
complement of the match you're interested in:

aNewList = []
s = StringScanner.new sNewList
upper = /[A-Z]+/
aNewList<< s.matched while s.skip_until(upper)

(Not tested real thoroughly, corner cases may break.)


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Caleb Clausen  
View profile  
 More options Nov 12, 7:37 pm
From: Caleb Clausen <vikk...@gmail.com>
Date: Fri, 13 Nov 2009 09:37:20 +0900
Local: Thurs, Nov 12 2009 7:37 pm
Subject: Re: DRYing a Regex
On 11/12/09, James Edward Gray II <ja...@graysoftinc.com> wrote:

> Well, you don't really need a StringScanner for this simple task.  Your code
> really just rebuilds String#scan():

>   a_new_list = s_new_list.scan(/[A-Z]+/)

ooh! that's even better.

    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
RichardOnRails  
View profile  
 More options Nov 13, 1:00 am
Newsgroups: comp.lang.ruby
From: RichardOnRails <RichardDummyMailbox58...@USComputerGurus.com>
Date: Fri, 13 Nov 2009 15:00:09 +0900
Local: Fri, Nov 13 2009 1:00 am
Subject: Re: DRYing a Regex
On Nov 12, 7:37 pm, Caleb Clausen <vikk...@gmail.com> wrote:

> On 11/12/09, James Edward Gray II <ja...@graysoftinc.com> wrote:

> > Well, you don't really need a StringScanner for this simple task.  Your code
> > really just rebuilds String#scan():

> >   a_new_list = s_new_list.scan(/[A-Z]+/)

> ooh! that's even better.

You're right.  I didn't NEED to DRY that simple thing.  I'm just
trying to improve my coding generally, especially to write things that
don't break easily when the inevitable changes are made.

But cutting out 90% of the code, wow!  That's DRY!!

Thank you very much for your ideas.  I haven't tested it yet, but it
looks right to me.

Best wishes,
Richard


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
RichardOnRails  
View profile  
 More options Nov 13, 1:25 am
Newsgroups: comp.lang.ruby
From: RichardOnRails <RichardDummyMailbox58...@USComputerGurus.com>
Date: Fri, 13 Nov 2009 15:25:04 +0900
Local: Fri, Nov 13 2009 1:25 am
Subject: Re: DRYing a Regex
On Nov 12, 6:50 pm, James Edward Gray II <ja...@graysoftinc.com>
wrote:

Hi James,

As I said to Caleb, cutting my 10-liner down to 1 is extreme DRYing!!
Thanks for that.

As far as underscoring vs. Camel-case goes,  I know Rubyists'
preference, but I bow to Shakespeare's notion that "a rose by any
other name is just as sweet."  I spent a couple decades writing/
maintaining Window's application for clients using C and C++, so I've
a fondness for Polish notation (at least that's what I think it was
called.) Typing extra hyphens vs pressing the shift key lets me write
code faster, and the a/s/h prefix for arrays/strings/hashes helps me
avoid a lot of interpreter complaints.  And fellow programmers of
almost any stripe knows what I mean.  Finally,  I retired curmudgeon,
and you know how we old folks are :-)

Seriously,  your insight was very helpful and will help me avoid a
bunch of wasteful code.

Best wishes,
Richard


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
RichardOnRails  
View profile  
 More options Nov 13, 2:35 am
Newsgroups: comp.lang.ruby
From: RichardOnRails <RichardDummyMailbox58...@USComputerGurus.com>
Date: Fri, 13 Nov 2009 16:35:06 +0900
Local: Fri, Nov 13 2009 2:35 am
Subject: Re: DRYing a Regex
Hey Caleb & James,

With your insights,  I was able to cut down 18 lines of somewhat
obscure code to 6 lines that I find very readable.  That's such and
improvement on the quality of the code.

Though I expect you guys are tired ot this thread, I included the new
and old code below, along with results that both of them produce.

Again,  thank you very much for your insights.

Best wishes,
Richard

# Accept a new list as a string; extract an array of contiguous upper-
case letters as stock symbols, ignoring any duplicates (Test data)
# Delete any symbol in the current list that occurs here
sNewList = %{TMxxx CSCO COL INTC BRCM FDX AA CAT BUR FSLR MSFT',
                      PNC HPQ CSCO AMAT ORCL FCX ABX PVTB XHB CSCO TM FDX}

#===============
# New technique
#===============
aRawNewList = sNewList.scan(/[A-Z]+/)
aNewList = Set.new(aRawNewList ).to_a.sort
nDeleted = 0
aNewList.each { |sym| hCurrentList.delete sym and nDeleted += 1  if
hCurrentList[sym] }
show_array( aNewList, 10, "New List (unique:%d, dups:%d, deleted:%s)"
%
  [aNewList.size, aRawNewList.size - aNewList.size, nDeleted] , true)

#============================
# Old technique; No longer used
#============================
aNewList = []
s = StringScanner.new sNewList
upper = /[A-Z]+/
non_upper= Regexp.new(  upper.source.sub( /\[/, '[^' )  )
nNewSyms = nCurrSymsDeleted = 0
while not s.eos?
  case
    when s.skip(upper)
      nNewSyms+=1
      aNewList << s.matched unless aNewList.include? s.matched
      ( hCurrentList.delete s.matched and  nCurrSymsDeleted += 1)  if
          hCurrentList[s.matched]
     else
       s.skip(non_upper)
  end
end
show_array( aNewList.sort, 10, "New List (%d unique; %d dups; %d curr.
deleted)" %
  [aNewList.size, nNewSyms - aNewList.size, nCurrSymsDeleted] )

#=======
# Output
#=======
===== New List (unique:19, dups:4, deleted:3) =====
AA ABX AMAT BRCM BUR CAT COL CSCO FCX FDX
FSLR HPQ INTC MSFT ORCL PNC PVTB TM XHB
=====   =====


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Robert Klemme  
View profile  
 More options Nov 13, 5:10 am
From: Robert Klemme <shortcut...@googlemail.com>
Date: Fri, 13 Nov 2009 19:10:31 +0900
Local: Fri, Nov 13 2009 5:10 am
Subject: Re: DRYing a Regex
2009/11/13 RichardOnRails <RichardDummyMailbox58...@uscomputergurus.com>:

> As far as underscoring vs. Camel-case goes,  I know Rubyists'
> preference, but I bow to Shakespeare's notion that "a rose by any
> other name is just as sweet."  I spent a couple decades writing/
> maintaining Window's application for clients using C and C++, so I've
> a fondness for Polish notation (at least that's what I think it was
> called.)

I believe you mean Hungarian Notation:
http://en.wikipedia.org/wiki/Polish_notation

> Typing extra hyphens vs pressing the shift key lets me write
> code faster, and the a/s/h prefix for arrays/strings/hashes helps me
> avoid a lot of interpreter complaints.  And fellow programmers of
> almost any stripe knows what I mean.

There's always something to be said for conventions.  The issue with
your notation is that it seems to be far less used among Ruby
programmers than the snake case.  Snake case for variables and methods
also has the added advantage that classes and modules stand out
immediately.

Side note: with modern IDE's I believe there is not much reason to use
Hungarian Notation any more.  I personally find it more difficult to
spot certain variables when all variables of the same type start with
the same letter.  For me, PN actually _reduces_ readability.

>  Finally,  I retired curmudgeon,
> and you know how we old folks are :-)

LOL

Cheers

robert

--
remember.guy do |as, often| as.you_can - without end
http://blog.rubybestpractices.com/


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mark Thomas  
View profile  
 More options Nov 13, 7:30 am
Newsgroups: comp.lang.ruby
From: Mark Thomas <m...@thomaszone.com>
Date: Fri, 13 Nov 2009 21:30:16 +0900
Local: Fri, Nov 13 2009 7:30 am
Subject: Re: DRYing a Regex
On Nov 13, 2:34 am, RichardOnRails

<RichardDummyMailbox58...@USComputerGurus.com> wrote:
> Hey Caleb & James,

> With your insights,  I was able to cut down 18 lines of somewhat
> obscure code to 6 lines that I find very readable.  That's such and
> improvement on the quality of the code.

I believe you can go further. For example, these three lines:

  sNewList = %{TMxxx CSCO COL INTC BRCM FDX AA CAT BUR FSLR MSFT',
               PNC HPQ CSCO AMAT ORCL FCX ABX PVTB XHB CSCO TM FDX}
  aRawNewList = sNewList.scan(/[A-Z]+/)
  aNewList = Set.new(aRawNewList ).to_a.sort

can be replaced by one:

  aNewList = %W{TMxxx CSCO COL INTC BRCM FDX AA CAT BUR FSLR MSFT',
                PNC HPQ CSCO AMAT ORCL FCX ABX PVTB XHB CSCO TM FDX}

(you can add .sort to the end but I don't think you need it)

also, consider something like this:

  hCurrentList.delete_if { |key,v| aNewList.include?key }

-- Mark.


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Robert Klemme  
View profile  
 More options Nov 13, 9:17 am
From: Robert Klemme <shortcut...@googlemail.com>
Date: Fri, 13 Nov 2009 23:17:39 +0900
Local: Fri, Nov 13 2009 9:17 am
Subject: Re: DRYing a Regex
2009/11/13 Mark Thomas <m...@thomaszone.com>:

I don't think so because that appears to be input from the outside
which is provided as single String.

> (you can add .sort to the end but I don't think you need it)

> also, consider something like this:

>  hCurrentList.delete_if { |key,v| aNewList.include?key }

Basically the question is which of the two is larger.  But if you do
it this way round (i.e. iterate the Hash and check for existence in
the new list then that should definitively be a Set).

Here's my suggestion

require 'set'

# dumy base
current = {"CSCO" => 1, "COL" => 2, "INTC" => 3, "BRCM" => 4, "FOO" => 99}

# user input
input = %{TMxxx CSCO COL INTC BRCM FDX AA CAT BUR FSLR MSFT
  PNC HPQ CSCO AMAT ORCL FCX ABX PVTB XHB CSCO TM FDX}

# algorithm
symbols = input.scan(/[A-Z]+/)
deduped = symbols.to_set

old_size = current.size
deduped.each {|sym| current.delete sym}

p(deduped.sort,
  10,
  sprintf("New List (unique:%d, dups:%d, deleted:%s)",
    deduped.size,
    symbols.size - deduped.size,
    old_size - current.size),
  true)

p current

Cheers

robert

--
remember.guy do |as, often| as.you_can - without end
http://blog.rubybestpractices.com/


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "Naming conventions -- was: Re: DRYing a Regex" by Marnen Laibow-Koser
Marnen Laibow-Koser  
View profile  
 More options Nov 13, 11:11 pm
Newsgroups: comp.lang.ruby
From: Marnen Laibow-Koser <mar...@marnen.org>
Date: Sat, 14 Nov 2009 13:11:07 +0900
Local: Fri, Nov 13 2009 11:11 pm
Subject: Naming conventions -- was: Re: DRYing a Regex
RichardOnRails wrote:

[...]

> As far as underscoring vs. Camel-case goes,  I know Rubyists'
> preference, but I bow to Shakespeare's notion that "a rose by any
> other name is just as sweet."  

It doesn't work that way in programming.  Good naming practices are an
important part of readable code.  This is particularly so in a language
like Ruby, in which "literate" interfaces are common.

I spent a couple decades writing/

> maintaining Window's application for clients using C and C++, so I've
> a fondness for Polish notation (at least that's what I think it was
> called.)

Polish Notation is Łukasiewicz-style prefix notation, rather like what's
used in Lisp.  You mean Hungarian Notation.

But in any case, *you've been had*.  Hungarian Notation as developed by
Charles Simonyi is extremely useful in non-OO code (I've used it in PHP
with great success).  Hungarian Notation as the term is usually
understood is a very stupid thing indeed, which has unfortunately been
foisted by Microsoft on huge numbers of Windows programmers who really
should know better. :)  It is (at best) marginally useful in statically
typed languages like C, and downright misleading in dynamically typed
languages like Ruby.

The difference is that Simonyi's original concept encodes information
*outside the scope* of the variable's type (which, after all, the
interpreter or compiler already knows about).  For example, in a mapping
system, you might have kmDistance and ftCorrection.  It's entirely clear
from those names that kmDistance + ftCorrection would be adding
kilometers and feet without a conversion, and thus it's immediately
clear that that operation is wrong.

OTOH, legions of misled Windows developers would simply call those two
variables intDistance and intCorrection, incorporating no new useful
information and making the names harder to read.

For more on the misuse of Hungarian Notation, please see
http://www.joelonsoftware.com/articles/Wrong.html (Simonyi's original is
there called Apps Hungarian, while the popular perversion is called
Systems Hungarian).  There's also some interesting discussion at
http://c2.com/cgi/wiki?HungarianNotation , if you can wade through the
disorganization.

Systems Hungarian, BTW, is bad enough in C, where you should be able to
refer to your variable declarations.  If your functions are so long that
you can't refer easily to declarations, then you need to refactor to
shorter methods for overall readability anyway -- methods should be
short.  Systems Hungarian has no use at all in Ruby, since although
objects are typed, variables are not, so it's perfectly possible to do
intValue = 1
# later
intValue = {:foo => 'bar'}

Even Apps Hungarian is not a great idea in OO code.  Instead, just use
the type system, so that distance would be a Kilometer object and
correction would be a Foot object.  Kilometer.+(foot) could then either
raise an exception or invoke a conversion.

In summary, then, Hungarian Notation of either sort is inappropriate in
Ruby.  Drop the habit.

> Typing extra hyphens vs pressing the shift key lets me write
> code faster, and the a/s/h prefix for arrays/strings/hashes helps me
> avoid a lot of interpreter complaints.  

If you care about removing characters from variable names, start with
removing the Hungarian warts.  As I explained above, they serve no
useful purpose in Ruby at all.  And I have to say, I don't find
wordsRunTogether as easy to read as words_with_underscores -- the
underscores look more like spaces and delineate the words better to my
eye.  WouldYouRatherReadThisClauseHere, or
would_you_rather_read_this_clause_here?

In any case, "snake_case" is the prevailing style in Ruby, and virtually
every Ruby library uses it (including the standard library and Rails) --
your code will look strange if you don't follow suit.  The examples in
Programming Ruby tend to use camelCase, but that's more of a flaw in the
book than an indicator of Ruby practice.

> And fellow programmers of
> almost any stripe knows what I mean.  Finally,  I retired curmudgeon,
> and you know how we old folks are :-)

Age is not an excuse.  If you're going to learn a language, take the
time to learn the idioms and the "spirit" of the language, not just the
bare essentials of syntax.  I've seen far too many people try to write
C, Java, or PHP in Ruby -- avoid the temptation!

> Seriously,  your insight was very helpful and will help me avoid a
> bunch of wasteful code.

> Best wishes,
> Richard

Best,
--
Marnen Laibow-Koser
http://www.marnen.org
mar...@marnen.org
--
Posted via http://www.ruby-forum.com/.

    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
James Edward Gray II  
View profile  
 More options Nov 13, 11:21 pm
From: James Edward Gray II <ja...@graysoftinc.com>
Date: Sat, 14 Nov 2009 13:21:13 +0900
Local: Fri, Nov 13 2009 11:21 pm
Subject: Re: Naming conventions -- was: Re: DRYing a Regex
On Nov 13, 2009, at 10:11 PM, Marnen Laibow-Koser wrote:

> RichardOnRails wrote:
> [...]
>> As far as underscoring vs. Camel-case goes,  I know Rubyists'
>> preference, but I bow to Shakespeare's notion that "a rose by any
>> other name is just as sweet."  

> It doesn't work that way in programming.  Good naming practices are an
> important part of readable code.

As the saying goes, "When in Rome, do as the Romans do."  You're speaking our language now and you want to learn to speak it like us, even with our slang.  That allows you to communicate with us better so we can learn from each other.

> Even Apps Hungarian is not a great idea in OO code.  Instead, just use
> the type system, so that distance would be a Kilometer object and
> correction would be a Foot object.  Kilometer.+(foot) could then either
> raise an exception or invoke a conversion.

I would like to see us move away from considering classes to be types at all in Ruby.  Who knows what modules an object has mixed into it and who knows what singleton methods are defined on it.  A class, which is what people traditionally take for the type, is just one piece of an object's identity.

James Edward Gray II


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Marnen Laibow-Koser  
View profile  
 More options Nov 13, 11:27 pm
Newsgroups: comp.lang.ruby
From: Marnen Laibow-Koser <mar...@marnen.org>
Date: Sat, 14 Nov 2009 13:27:51 +0900
Local: Fri, Nov 13 2009 11:27 pm
Subject: Re: Naming conventions -- was: Re: DRYing a Regex
James Edward Gray II wrote:
[...]

>> Even Apps Hungarian is not a great idea in OO code.  Instead, just use
>> the type system, so that distance would be a Kilometer object and
>> correction would be a Foot object.  Kilometer.+(foot) could then either
>> raise an exception or invoke a conversion.

> I would like to see us move away from considering classes to be types at
> all in Ruby.  Who knows what modules an object has mixed into it and who
> knows what singleton methods are defined on it.

Do you make much use of singleton mixins or singleton methods in your
code?  I know I don't.

>  A class, which is what
> people traditionally take for the type, is just one piece of an object's
> identity.

You're right.  But with a proper class system, my point about not
needing Apps Hungarian in Ruby still stands, I think.  Do you disagree?

> James Edward Gray II

Best,
--
Marnen Laibow-Koser
http://www.marnen.org
mar...@marnen.org
--
Posted via http://www.ruby-forum.com/.

    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
David Turnbull  
View profile  
 More options Nov 13, 11:39 pm
From: David Turnbull <dsturnb...@gmail.com>
Date: Sat, 14 Nov 2009 13:39:45 +0900
Local: Fri, Nov 13 2009 11:39 pm
Subject: Re: Naming conventions -- was: Re: DRYing a Regex
On 14/11/2009, at 15:21, James Edward Gray II <ja...@graysoftinc.com>  
wrote:

>> Even Apps Hungarian is not a great idea in OO code.  Instead, just  
>> use
>> the type system, so that distance would be a Kilometer object and
>> correction would be a Foot object.  Kilometer.+(foot) could then  
>> either
>> raise an exception or invoke a conversion.

> I would like to see us move away from considering classes to be  
> types at all in Ruby.  Who knows what modules an object has mixed  
> into it and who knows what singleton methods are defined on it.  A  
> class, which is what people traditionally take for the type, is just  
> one piece of an object's identity.

I would still look immediately to the class of the object in order to  
find out what it's supposed to do. From there, the class definition  
will probably list it's module inclusions prominently.

As a vim user, with very limited interactive debugging, my primary  
exploration technique will usually consist of at most a couple of  
'obj.methods.grep' calls followed by grepping ~/gems which seems to  
emphasize the actual reading of the source for object identity info.

Python's integrated documentation would be really welcome in this  
case, i think. :)

I'm curious what you think the most correct way is to discover object  
identity.


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Marnen Laibow-Koser  
View profile  
 More options Nov 13, 11:43 pm
Newsgroups: comp.lang.ruby
From: Marnen Laibow-Koser <mar...@marnen.org>
Date: Sat, 14 Nov 2009 13:43:25 +0900
Local: Fri, Nov 13 2009 11:43 pm
Subject: Re: Naming conventions -- was: Re: DRYing a Regex

David Turnbull wrote:
> On 14/11/2009, at 15:21, James Edward Gray II <ja...@graysoftinc.com>
> wrote:
>> class, which is what people traditionally take for the type, is just  
>> one piece of an object's identity.

> I would still look immediately to the class of the object in order to
> find out what it's supposed to do.

I would too.  James is correct that it isn't the whole story, but it's
the best place to start.

> From there, the class definition
> will probably list it's module inclusions prominently.

> As a vim user, with very limited interactive debugging,

What?  You can use ruby-debug interactively in a console session.  I
often do.

> my primary
> exploration technique will usually consist of at most a couple of
> 'obj.methods.grep' calls followed by grepping ~/gems which seems to
> emphasize the actual reading of the source for object identity info.

> Python's integrated documentation would be really welcome in this
> case, i think. :)

WTF?  Aren't you familiar with RDoc?  And didn't you know that running
"gem server" will start a Web server with gem RDoc pages on port 8808?

> I'm curious what you think the most correct way is to discover object
> identity.

Object identity?  Well, for that, you need object_id.  That's something
different than object type.
--
Posted via http://www.ruby-forum.com/.

    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Bill Kelly  
View profile  
 More options Nov 14, 1:23 am
From: "Bill Kelly" <bi...@cts.com>
Date: Sat, 14 Nov 2009 15:23:04 +0900
Local: Sat, Nov 14 2009 1:23 am
Subject: Re: Naming conventions -- was: Re: DRYing a Regex

From: "David Turnbull" <dsturnb...@gmail.com>

> On 14/11/2009, at 15:21, James Edward Gray II <ja...@graysoftinc.com>  
> wrote:
>> I would like to see us move away from considering classes to be  
>> types at all in Ruby.  Who knows what modules an object has mixed  
>> into it and who knows what singleton methods are defined on it.  A  
>> class, which is what people traditionally take for the type, is just  
>> one piece of an object's identity.

> I would still look immediately to the class of the object in order to  
> find out what it's supposed to do. From there, the class definition  
> will probably list it's module inclusions prominently.

A human looking to documentation to find out what an object
of a partiular class is supposed to *do*, is one thing.  But
then there's the programmatic flipside where one could code
a method to select between different behaviors based on the
class-type of a given argument-object.

  def foo(bar)
    if bar.is_a? Array
      do_array_thing(bar)
    elsif bar.is_a? String
      do_string_thing(bar)
    else
      ... # ?
    end
  end

I believe it's (variations on) the above that are viewed
as unreasonably restrictive in ruby.

It's challenging, too, because even :respond_to? can be
misleading.

I like Og (Object Graph), an Object Relational Mapping
library in ruby providing high-level database access.

  require 'og'

  class Address
    property :name, String
    property :company, String
    property :dept, String
    property :addr1, String
    property :addr2, String
    property :city, String
    property :state, String
    property :zip, String
    property :country, String
    belongs_to :order, Order
  end

When Og is initialized, it searches ObjectSpace for
classes like the above, and detects that they are
intended to be Og-managed classes, and imbues them
with certain basic features.  (It also generates the
SQL needed to create the database tables
corresponding to such classes.)

An example is that, given nothing more than the above
Address class declaration... I could now say:

  result = Address.find_by_name_and_state("Bob Jones", "CA")

But..! The Address.find_by_name_and_state doesn't even
exist until the time that it is called.  Part of the
magic with which an Og-managed class is imbued, is
some method_missing logic which looks for particular
method signatures, like /find_by_(.*)/ , and, at the
moment such a method is called, is tested against the
following, behind the scenes:

  def method_missing(sym, *args, &block)
    if match = /find_(all_by|by)_([_a-zA-Z]\w*)/.match(sym.to_s)
      return find_by_(match, args, &block)
    elsif match = /find_or_create_by_([_a-zA-Z]\w*)/.match(sym.to_s)
      return find_or_create_by_(match, args, &block)
    else
      super
    end
  end

(Note: In this case, it appears Og _always_ handles the
request via method_missing.  But I've seen other code
in Og (or maybe Nitro) that did *define* the method when
it was first called, such that on subsequent invocations
the method would now already be existing.)

. . . Anyway, the point being, Ruby is pretty dynamic.

:)

> Python's integrated documentation would be really welcome in this  
> case, i think. :)

I seem to recall mention awhile back on ruby-talk of
a gem or module that integrated `ri` into `irb`, such
that one could pull up the documentation from within
irb.  (I don't have any links for that, sorry.)

Regards,

Bill


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "elsif" by Ralph Shnelvar
Ralph Shnelvar  
View profile  
 More options Nov 14, 7:03 am
From: Ralph Shnelvar <ral...@dos32.com>
Date: Sat, 14 Nov 2009 21:03:06 +0900
Local: Sat, Nov 14 2009 7:03 am
Subject: elsif
BK>     elsif bar.is_a? String

As a newbie I would surely like to know why the language decided on
"elsif" rather than "elseif".

And before anyone accuses me of not doing a Google search on the
subject ... I did.  E.g. http://www.ruby-forum.com/topic/100350

I'm not trying to change the language ... I'm wondering if the
language developer(s) had a reason for it?  Did the want to save the
typing of an 'e'?

- - - -

While we're at it, is there a (undocumented?) compiler switch that says "always check
for then in if/elsif statements"?

And before anyone accuses me of not doing a Google search on the
subject of compiler switches ... I did.  E.g. http://www.zenspider.com/Languages/Ruby/QuickRef.html


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mark Thomas  
View profile  
 More options Nov 14, 8:55 am
Newsgroups: comp.lang.ruby
From: Mark Thomas <m...@thomaszone.com>
Date: Sat, 14 Nov 2009 22:55:09 +0900
Local: Sat, Nov 14 2009 8:55 am
Subject: Re: elsif
On Nov 14, 7:03 am, Ralph Shnelvar <ral...@dos32.com> wrote:

> BK>     elsif bar.is_a? String

> As a newbie I would surely like to know why the language decided on
> "elsif" rather than "elseif".

Because a precedent had been set in Perl. That's one of the
unfortunate Perlisms in Ruby.

At least Matz didn't borrow it from Bash, which uses "elif".


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Todd Benson  
View profile  
 More options Nov 14, 9:27 am
From: Todd Benson <caduce...@gmail.com>
Date: Sat, 14 Nov 2009 23:27:26 +0900
Local: Sat, Nov 14 2009 9:27 am
Subject: Re: elsif

On Sat, Nov 14, 2009 at 6:03 AM, Ralph Shnelvar <ral...@dos32.com> wrote:
> BK>     elsif bar.is_a? String

> As a newbie I would surely like to know why the language decided on
> "elsif" rather than "elseif".

I'm pretty sure it's a Perl artifact.

    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Discussion subject changed to "Naming conventions -- was: Re: DRYing a Regex" by Rick DeNatale
Rick DeNatale  
View profile  
 More options Nov 14, 10:56 am
From: Rick DeNatale <rick.denat...@gmail.com>
Date: Sun, 15 Nov 2009 00:56:05 +0900
Local: Sat, Nov 14 2009 10:56 am
Subject: Re: Naming conventions -- was: Re: DRYing a Regex

I've long (since at least 18 years) been an advocate of divorcing the
notion of type from class in dynamically typed languages:

http://talklikeaduck.denhaven2.com/files/TypesFromTheClientsViewpoint...

IMHO, viewing a variable as a 'role' to be filled with one or more
objects is a powerful technique.

Alastair Cockburn recently told me that he still refers clients to the
reference paper, which I wrote at IBM, when he and l were both there.

The view fits into a general approach to OO design which is called
"responsibility based" or "role based" design.  Rebecca Wirfs-Brock
was one of the authors who published books on the approach

http://www.amazon.com/Rebecca-Wirfs-Brock/e/B001IQXNWC/ref=ntt_athr_d...

This was before the static-typing crowd (starting with C++) took over
the conventional wisdom as to what it meant to be OO, in turn leading
to a proliferation of "methodologies" using static typing.

Those of us in the dynamic typing/roles/responsibility based community
see this as an unfortunate parallel to Gresham's Law.

With the re-birth of interest in dynamically typed languages I think
that the role based view is preferable.

--
Rick DeNatale

Blog: http://talklikeaduck.denhaven2.com/
Twitter: http://twitter.com/RickDeNatale
WWR: http://www.workingwithrails.com/person/9021-rick-denatale
LinkedIn: http://www.linkedin.com/in/rickdenatale


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
James Edward Gray II  
View profile  
 More options Nov 14, 11:27 am
From: James Edward Gray II <ja...@graysoftinc.com>
Date: Sun, 15 Nov 2009 01:27:59 +0900
Local: Sat, Nov 14 2009 11:27 am
Subject: Re: Naming conventions -- was: Re: DRYing a Regex
On Nov 14, 2009, at 12:23 AM, Bill Kelly wrote:

> (Note: In this case, it appears Og _always_ handles the
> request via method_missing.  But I've seen other code
> in Og (or maybe Nitro) that did *define* the method when
> it was first called, such that on subsequent invocations
> the method would now already be existing.)

ActiveRecord from Rails works this way.  If you would like to see the code it starts around line 1830 of this file:

http://github.com/rails/rails/blob/master/activerecord/lib/active_rec...

> I seem to recall mention awhile back on ruby-talk of
> a gem or module that integrated `ri` into `irb`, such
> that one could pull up the documentation from within
> irb.  (I don't have any links for that, sorry.)

Here's what I have in my .irbrc file:

  def ri(*names)
    system(%{ri #{names.join(" ")}})
  end

James Edward Gray II


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
James Edward Gray II  
View profile  
 More options Nov 14, 11:58 am
From: James Edward Gray II <ja...@graysoftinc.com>
Date: Sun, 15 Nov 2009 01:58:03 +0900
Local: Sat, Nov 14 2009 11:58 am
Subject: Re: Naming conventions -- was: Re: DRYing a Regex
On Nov 13, 2009, at 10:27 PM, Marnen Laibow-Koser wrote:

> James Edward Gray II wrote:
> [...]
>>> Even Apps Hungarian is not a great idea in OO code.  Instead, just use
>>> the type system, so that distance would be a Kilometer object and
>>> correction would be a Foot object.  Kilometer.+(foot) could then either
>>> raise an exception or invoke a conversion.

>> I would like to see us move away from considering classes to be types at
>> all in Ruby.  Who knows what modules an object has mixed into it and who
>> knows what singleton methods are defined on it.

> Do you make much use of singleton mixins or singleton methods in your
> code?  I know I don't.

I have been doing a lot more of mixing modules into individual objects, yes.  I have been more than pleased with the results too.  I think it's something we should all try to do more of.  I gave a speech about this at LSRC this year which should show up here someday:

  http://lsrc2009.confreaks.com/

I can give a couple of examples.

I recently ran across some code that had extensions to a core system.  Each extension would reopen the core classes and edit away.  Unfortunately, they had to duplicate a lot of the core code to make little changes to it.  I rewrote the code to allow extensions to register modules with the core classes.  Then when those classes produced objects, they would mix in any registered modules.  This simple eliminated almost all of the duplication, because the modules were in the singleton class *in front of* the methods they were modifying.  They could read the arguments and see if they needed to step in with their modified behavior, or just hand off to super().

I showed another example in my talk where I was trying to create a one instance configuration object.  Originally I did it with a constant and some clever reopening of the singleton class, but that caused problems like not being able to easily document this object's API.  I switched to just creating the one instance I needed and immediately mixing in a module that added the special functionality and it solved all the problems I had.  You can document a module just fine.  (The example is in my slides, if you want to see it:  http://blog.grayproductions.net/articles/lone_star_rubyconf_slides.)

I think we should do more of this.  For example, I think we could return an Array that mixes in a Paginated module instead of a PaginatedCollection object that inherits from Array.  That feels more right to me.  It's an Array and it has some extra functionality added in related to pagination. The uses go on and on.

>> A class, which is what
>> people traditionally take for the type, is just one piece of an object's
>> identity.

> You're right.  But with a proper class system, my point about not
> needing Apps Hungarian in Ruby still stands, I think.  Do you disagree?

I was agreeing with you, yes.  I was saying that adding an a_ or s_ to the beginning of a variable name, assumably to indicate Array or String, is a damaging practice, because that's not necessarily all you need to know about the object.  I think it promotes the wrong kind of thinking about Ruby's types.

James Edward Gray II


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
James Edward Gray II  
View profile  
 More options Nov 14, 12:06 pm
From: James Edward Gray II <ja...@graysoftinc.com>
Date: Sun, 15 Nov 2009 02:06:56 +0900
Local: Sat, Nov 14 2009 12:06 pm
Subject: Re: Naming conventions -- was: Re: DRYing a Regex
On Nov 13, 2009, at 10:39 PM, David Turnbull wrote:

> On 14/11/2009, at 15:21, James Edward Gray II <ja...@graysoftinc.com> wrote:
>>> Even Apps Hungarian is not a great idea in OO code.  Instead, just use
>>> the type system, so that distance would be a Kilometer object and
>>> correction would be a Foot object.  Kilometer.+(foot) could then either
>>> raise an exception or invoke a conversion.

>> I would like to see us move away from considering classes to be types at all in Ruby.  Who knows what modules an object has mixed into it and who knows what singleton methods are defined on it.  A class, which is what people traditionally take for the type, is just one piece of an object's identity.

> I would still look immediately to the class of the object in order to find out what it's supposed to do. From there, the class definition will probably list it's module inclusions prominently.

Sure, it's definitely part of the picture.

> As a vim user, with very limited interactive debugging, my primary exploration technique will usually consist of at most a couple of 'obj.methods.grep' calls followed by grepping ~/gems which seems to emphasize the actual reading of the source for object identity info.

Your use of grep() for methods catches a lot of things a class definition might not tell you.

> I'm curious what you think the most correct way is to discover object identity.

Well, if we just mix modules into objects as I recommended in my previous message, Ruby's type system just naturally handles all of the details.

>> o = Object.new

=> #<Object:0x10037f9f0>
>> module Magical
>>   def inspect
>>     "#<MagicalObject ##{object_id}>"
>>   end
>> end
=> nil
>> o.extend(Magical)

=> #<MagicalObject #2149317880>
>> o.is_a? Object
=> true
>> o.is_a? Magical
=> true
>> class << o; self end.ancestors

=> [Magical, Object, Kernel]

James Edward Gray II


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
David A. Black  
View profile  
 More options Nov 14, 1:21 pm
From: "David A. Black" <dbl...@rubypal.com>
Date: Sun, 15 Nov 2009 03:21:41 +0900
Local: Sat, Nov 14 2009 1:21 pm
Subject: Re: Naming conventions -- was: Re: DRYing a Regex
Hi --

On Sat, 14 Nov 2009, Marnen Laibow-Koser wrote:
> James Edward Gray II wrote:
> [...]
>>> Even Apps Hungarian is not a great idea in OO code.  Instead, just use
>>> the type system, so that distance would be a Kilometer object and
>>> correction would be a Foot object.  Kilometer.+(foot) could then either
>>> raise an exception or invoke a conversion.

>> I would like to see us move away from considering classes to be types at
>> all in Ruby.  Who knows what modules an object has mixed into it and who
>> knows what singleton methods are defined on it.

> Do you make much use of singleton mixins or singleton methods in your
> code?  I know I don't.

I write class methods sometimes (I know those are singleton with an
asterisk next to them, but still), and I think that extending core
objects with modules is a frequently overlooked and very powerful
alternative to reopening core classes and adding methods.

This kind of thing:

   class String
     def method_I_need_once_or_twice
     ...

is almost always overkill. It's sort of the core-functionality
counterpart of using global variables. Extending an object is a much
more precise operation -- and has the additional merit, I find, of
really making you think about whether it's worth bothering to the
extend the object instead of working with what the object can already
do.

David

--
The          Ruby training with D. Black, G. Brown, J.McAnally
Compleat     Jan 22-23, 2010, Tampa, FL
Rubyist      http://www.thecompleatrubyist.com

David A. Black/Ruby Power and Light, LLC (http://www.rubypal.com)


    Reply    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Messages 1 - 25 of 42   Newer >
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2009 Google