[ruby-core:45812] [ruby-trunk - Feature #6637][Open] Add HTML5 support to CGI

4 views
Skip to first unread message

stomar (Marcus Stollsteimer)

unread,
Jun 23, 2012, 6:00:23 PM6/23/12
to ruby...@ruby-lang.org

Issue #6637 has been reported by stomar (Marcus Stollsteimer).

----------------------------------------
Feature #6637: Add HTML5 support to CGI
https://bugs.ruby-lang.org/issues/6637

Author: stomar (Marcus Stollsteimer)
Status: Open
Priority: Normal
Assignee:
Category:
Target version:


=begin
The attached patch adds support for HTML 5, providing
the doctype <!DOCTYPE html> and the tag helpers for the
new HTML elements (article, section, ...).

Changes were made in
* `lib/cgi/core.rb'
* `lib/cgi/html.rb'

Tests were added to
* `test/cgi/test_cgi_core.rb'

((*Notice:*)) the new HTML5 `header' element has ((*not*)) been added,
because it collides with the already defined CGI#header
method that creates the HTTP header block.
To avoid unreflected addition of this element, a test has
been included to make sure that CGI#header won't break.


Detailed list of changes in `html.rb' (in comparison to HTML 4 strict):

* doctype changed
* new elements added
* removed elements: tt, big, acronym
* void elements: area, base, br, col, command, embed, hr, img, input, keygen, link, meta, param, source, track, wbr
* new elements with optional end tag: optgroup, rt, rp

See the Editor's Draft of the HTML5 specification (15 June 2012):
((<URL:http://dev.w3.org/html5/spec/>)).
=end


--
http://bugs.ruby-lang.org/

mame (Yusuke Endoh)

unread,
Jun 30, 2012, 9:45:51 PM6/30/12
to ruby...@ruby-lang.org

Issue #6637 has been updated by mame (Yusuke Endoh).

Status changed from Open to Assigned
Assignee set to xibbar (Takeyuki Fujioka)


----------------------------------------
Feature #6637: Add HTML5 support to CGI
https://bugs.ruby-lang.org/issues/6637#change-27647

Author: stomar (Marcus Stollsteimer)
Status: Assigned
Priority: Normal
Assignee: xibbar (Takeyuki Fujioka)

stomar (Marcus Stollsteimer)

unread,
Jul 1, 2012, 12:54:58 PM7/1/12
to ruby...@ruby-lang.org

Issue #6637 has been updated by stomar (Marcus Stollsteimer).

File 6637.pdf added

Slide added (attached 6637.pdf).

Content:

Feature #6637: Add HTML5 support to CGI, now!
---------------------------------------------

Motivation

- CGI: provides methods for generating HTML elements

- HTML5 already widely used, support highly desirable

Contra

- new element `<header>` collides with existing `CGI#header`
(which returns the HTTP header)

- suggestion:
rename `CGI#header`, possibly to `CGI#http_header`

Proposal

- at least, include support for **nearly all** new HTML5 elements
(easy to achieve, no compatibility issues, patch supplied)

- if possible, achieve **full** support
(**this could not be done in a minor release**)

----------------------------------------
Feature #6637: Add HTML5 support to CGI
https://bugs.ruby-lang.org/issues/6637#change-27671

Author: stomar (Marcus Stollsteimer)
Status: Assigned
Priority: Normal
Assignee: xibbar (Takeyuki Fujioka)

mame (Yusuke Endoh)

unread,
Jul 1, 2012, 2:26:43 PM7/1/12
to ruby...@ruby-lang.org

Issue #6637 has been updated by mame (Yusuke Endoh).


Received, thank you!

Unfortunately, CGI maintainer (Takeyuki Fujioka) is not planning to attend the developers' meeting.
So it may be difficult to determine to accept your proposal. But we'll discuss it. Thank you again!

--
Yusuke Endoh <ma...@tsg.ne.jp>
----------------------------------------
Feature #6637: Add HTML5 support to CGI
https://bugs.ruby-lang.org/issues/6637#change-27690

Author: stomar (Marcus Stollsteimer)
Status: Assigned
Priority: Normal
Assignee: xibbar (Takeyuki Fujioka)

xibbar (Takeyuki Fujioka)

unread,
Jul 3, 2012, 4:26:59 PM7/3/12
to ruby...@ruby-lang.org

Issue #6637 has been updated by xibbar (Takeyuki Fujioka).


I think your proposal is good.
I will insert your patch to my branch and test.
Please wait so days.
Thank you.
----------------------------------------
Feature #6637: Add HTML5 support to CGI
https://bugs.ruby-lang.org/issues/6637#change-27767

Author: stomar (Marcus Stollsteimer)
Status: Assigned
Priority: Normal
Assignee: xibbar (Takeyuki Fujioka)

mame (Yusuke Endoh)

unread,
Jul 24, 2012, 9:20:30 AM7/24/12
to ruby...@ruby-lang.org

Issue #6637 has been updated by mame (Yusuke Endoh).


Marcus Stollsteimer,

We discussed your slide at the developer meeting (7/21), and
left this issue up to the CGI maintainer (Takeyuki Fujioka).

--
Yusuke Endoh <ma...@tsg.ne.jp>
----------------------------------------
Feature #6637: Add HTML5 support to CGI
https://bugs.ruby-lang.org/issues/6637#change-28390

Author: stomar (Marcus Stollsteimer)
Status: Assigned
Priority: Normal
Assignee: xibbar (Takeyuki Fujioka)

stomar (Marcus Stollsteimer)

unread,
Sep 22, 2012, 2:01:07 PM9/22/12
to ruby...@ruby-lang.org

Issue #6637 has been updated by stomar (Marcus Stollsteimer).


=begin
Hi Takeyuki,

have you come to any conclusions?

In case you consider support of all new HTML5 tags,
including <header>, I would be willing to provide
a new set of patches:

- first patch to rename `CGI#header` to `CGI#http_header`
(breaking downward compatibility)

- second patch to provide full HTML5 support at once

Regards,
Marcus
=end

----------------------------------------
Feature #6637: Add HTML5 support to CGI
https://bugs.ruby-lang.org/issues/6637#change-29677

Author: stomar (Marcus Stollsteimer)
Status: Assigned
Priority: Normal
Assignee: xibbar (Takeyuki Fujioka)

xibbar (Takeyuki Fujioka)

unread,
Oct 3, 2012, 10:03:49 PM10/3/12
to ruby...@ruby-lang.org

Issue #6637 has been updated by xibbar (Takeyuki Fujioka).

Category set to lib
Target version set to 2.0.0

Sorry, I was into other cgi performance tuning.

I will commit immediately.
----------------------------------------
Feature #6637: Add HTML5 support to CGI
https://bugs.ruby-lang.org/issues/6637#change-30016

Author: stomar (Marcus Stollsteimer)
Status: Assigned
Priority: Normal
Assignee: xibbar (Takeyuki Fujioka)
Category: lib
Target version: 2.0.0

stomar (Marcus Stollsteimer)

unread,
Oct 4, 2012, 6:32:41 AM10/4/12
to ruby...@ruby-lang.org

Issue #6637 has been updated by stomar (Marcus Stollsteimer).


=begin
Hi Takeyuki,

Did you consider the issue with the <header> tag?
At the moment it can not be created with the tag writer
like the other tags. I proposed a possible solution
in my previous posts.

Do you have any thoughts about this point?

Regards,
Marcus

BTW. I would have appreciated being mentioned in
the log message, like it's done by other committers
("patch by ..."), considerung the effort I put into this.
=end

----------------------------------------
Feature #6637: Add HTML5 support to CGI
https://bugs.ruby-lang.org/issues/6637#change-30020

Author: stomar (Marcus Stollsteimer)
Status: Closed
Priority: Normal
Assignee: xibbar (Takeyuki Fujioka)
Category: lib
Target version: 2.0.0


xibbar (Takeyuki Fujioka)

unread,
Oct 4, 2012, 7:48:20 AM10/4/12
to ruby...@ruby-lang.org

Issue #6637 has been updated by xibbar (Takeyuki Fujioka).

Status changed from Closed to Feedback

I need your full support patch to support the complete HTML5.
I will write "patch by stomar" to log, I promise.
Please provide.
----------------------------------------
Feature #6637: Add HTML5 support to CGI
https://bugs.ruby-lang.org/issues/6637#change-30034

Author: stomar (Marcus Stollsteimer)
Status: Feedback
Priority: Normal
Assignee: xibbar (Takeyuki Fujioka)
Category: lib
Target version: 2.0.0


stomar (Marcus Stollsteimer)

unread,
Oct 5, 2012, 9:23:43 AM10/5/12
to ruby...@ruby-lang.org

Issue #6637 has been updated by stomar (Marcus Stollsteimer).


=begin
Since this issue is already closed, I opened a new one, see #7110.
=end

----------------------------------------
Feature #6637: Add HTML5 support to CGI
https://bugs.ruby-lang.org/issues/6637#change-30110

Author: stomar (Marcus Stollsteimer)
Status: Feedback
Priority: Normal
Assignee: xibbar (Takeyuki Fujioka)
Category: lib
Target version: 2.0.0


ko1 (Koichi Sasada)

unread,
Oct 26, 2012, 6:13:28 PM10/26/12
to ruby...@ruby-lang.org

Issue #6637 has been updated by ko1 (Koichi Sasada).

Status changed from Feedback to Closed

It seems closed.
----------------------------------------
Feature #6637: Add HTML5 support to CGI
https://bugs.ruby-lang.org/issues/6637#change-31692

Author: stomar (Marcus Stollsteimer)
Status: Closed
Priority: Normal
Assignee: xibbar (Takeyuki Fujioka)
Category: lib
Target version: 2.0.0


Reply all
Reply to author
Forward
0 new messages