Received: by 10.58.135.42 with SMTP id pp10mr2430621veb.18.1347925365802;
Mon, 17 Sep 2012 16:42:45 -0700 (PDT)
X-BeenThere: rope-dev@googlegroups.com
Received: by 10.220.141.4 with SMTP id k4ls5322439vcu.8.gmail; Mon, 17 Sep
2012 16:42:45 -0700 (PDT)
Received: by 10.58.220.97 with SMTP id pv1mr2737089vec.13.1347925365298;
Mon, 17 Sep 2012 16:42:45 -0700 (PDT)
Received: by 10.58.220.97 with SMTP id pv1mr2737088vec.13.1347925365276;
Mon, 17 Sep 2012 16:42:45 -0700 (PDT)
Return-Path: <anton.belogla...@gmail.com>
Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174])
by gmr-mx.google.com with ESMTPS id z16si468781vdf.0.2012.09.17.16.42.45
(version=TLSv1/SSLv3 cipher=OTHER);
Mon, 17 Sep 2012 16:42:45 -0700 (PDT)
Received-SPF: pass (google.com: domain of anton.belogla...@gmail.com designates 209.85.220.174 as permitted sender) client-ip=209.85.220.174;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of anton.belogla...@gmail.com designates 209.85.220.174 as permitted sender) smtp.mail=anton.belogla...@gmail.com; dkim=pass header...@gmail.com
Received: by vcbfo13 with SMTP id fo13so7754621vcb.5
for <rope-dev@googlegroups.com>; Mon, 17 Sep 2012 16:42:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20120113;
h=mime-version:in-reply-to:references:from:date:message-id:subject:to
:cc:content-type;
bh=9qAVs/AdVaAFh2HRo5rDUpdaQ0BZatFuekwVS/Jx1nk=;
b=FbdE1eOTF7DdPt/Mt7uKWLbEz6sXSj4M84NIMYQP42H1lrnQeW7ycsnAisndUmjgw+
tBr//mZScHLSydwA5fUr0wKelq13buYUyODT2TCFbfJDDwy+ON1WxLUpLNNGL7sa2tNb
sTCikA3LqDiiqKMwGiVu+TFv62pevTK2qnCrhqHoeqGtf1mvTAp0qHXnyOQ83fywqpyi
Pcb96lbQ5949kY28RLzHa/zsIHAGIfH1MsA/ymh+mgo9di3wUrEFThnrN7iF1f3HluSR
prAfCvJ63YH+EjjvftkGhMfdwLZ7U7JXeGSmcqXQee6Vx3BeZ19vV9RlHLe5to1HBP9A
v2qw==
Received: by 10.220.228.131 with SMTP id je3mr8366748vcb.73.1347925365043;
Mon, 17 Sep 2012 16:42:45 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.58.26.234 with HTTP; Mon, 17 Sep 2012 16:42:04 -0700 (PDT)
In-Reply-To: <CAKmrg8NLRVHAyJ2j5CBt2aUpMWu_kw25GRBu9Zu-wecihqp...@mail.gmail.com>
References: <CAPM+gBR2Dv1Pf+FGyWMRo_+d4qwoM5X_ZXW2+t_CAU--mSK...@mail.gmail.com>
<20122303154...@lilem.mirepesht> <CAPM+gBRVvd=Wg=xPSb_vuMG8oOfW9DSCPyj4sP0Nkyx=NLu...@mail.gmail.com>
<20122403092...@lilem.mirepesht> <CAPM+gBTj5aRJiASsvBhkQFLGyT0DYb4B57z1_34xGg=uMvn...@mail.gmail.com>
<20122403165...@lilem.mirepesht> <CAPM+gBTx9Hi+q=XbLnfhRHGLLbsTSw=hnzUdtmXz=Eja1mg...@mail.gmail.com>
<20122503000...@lilem.mirepesht> <CAPM+gBQTVjj9doWxFKsvZTxjG+3zJ68fAy4=pyzabr0RUVM...@mail.gmail.com>
<20122503080...@lilem.mirepesht> <20122503083...@lilem.mirepesht>
<CAPM+gBRvBVA+yxVr5juaLSom9KmtHhQkjatuCc39echPJ7c...@mail.gmail.com>
<CAPM+gBTUZTd8Z5rANj6LG+bo--x9Rg8=yyV73s03DU1WXRM...@mail.gmail.com>
<20122503154...@lilem.mirepesht> <m1vclshjar....@gmail.com>
<CAPM+gBQhi1-zVHyJPgin4G95HZN0ni+q3hE=udc6Df0Yg7R...@mail.gmail.com>
<20122603000...@lilem.mirepesht> <0d811a66-bc49-4a24-8aa9-8d3a0b399b7a@googlegroups.com>
<20122308182...@lilem.mirepesht> <m1y5l541mv....@gmail.com>
<11e60759-f3d8-4b11-90a8-fb7ab306586f@googlegroups.com> <20122408063...@lilem.mirepesht>
<CAHVUVS7pvm_wxOKEt=k7UV9UAt4SLzJ1GGY8ujj_7dfT=TN...@mail.gmail.com>
<20122708193...@lilem.mirepesht> <CAHVUVS6RtFS3YVi7heNuwB7Xg988Beet-sZYHTEYqf90VzA...@mail.gmail.com>
<CAHVUVS5fivWPvhDE-jP70qi9wyV6hHR6aUw2+f51REgjn2s...@mail.gmail.com>
<CAHVUVS5TonWQRChr2RKfF_4ythesCiCj8sNuMBF8Eif=BHa...@mail.gmail.com>
<20122808174...@lilem.mirepesht> <CAHVUVS63upxf28oCE+8NnO014VhHBBB7Z--LNEPcKdzeZHe...@mail.gmail.com>
<20122908141...@lilem.mirepesht> <CAKmrg8ObUP=Aw6LK=_uSfEdBs3meRc951fA4dG8FrHT5mLE...@mail.gmail.com>
<CAHVUVS4fC+eLHcyTS7P_0kT_w9mk3Rw5UZ4nXYW5eF7XzeW...@mail.gmail.com>
<20123008181...@lilem.mirepesht> <CAHVUVS6=EGq+U_axGbaOkugconrRAiRPLDOLdDnPb6bpsco...@mail.gmail.com>
<20123108142...@lilem.mirepesht> <CAHVUVS6YodC2wpV4DiEuZ0EbUQbJSPCKnCibJKWC+jd1iVN...@mail.gmail.com>
<CAHVUVS6VJ+yEUU8sDXvmD2ZjE3Uma+sgwoXcH15U4zU3mkq...@mail.gmail.com>
<CAHVUVS7sYKTVqVgvsPbDA4oGfA0ZTaEsfqsom9vpHEE40ON...@mail.gmail.com>
<CAKmrg8P7WurqrskZ-Q_ACO09uL-u8ogji4MTWwynkHGkJA6...@mail.gmail.com> <CAKmrg8NLRVHAyJ2j5CBt2aUpMWu_kw25GRBu9Zu-wecihqp...@mail.gmail.com>
From: Anton Beloglazov <anton.belogla...@gmail.com>
Date: Tue, 18 Sep 2012 09:42:04 +1000
Message-ID: <CAHVUVS7jz4T4q5DMCXo0W0SHqgpkhNFP9yHBcQfFz88xYgt...@mail.gmail.com>
Subject: Re: Patches: noerror option to code_assist
To: an...@angri.ru
Cc: Ali Gholami Rudi <aligr...@gmail.com>, rope-dev@googlegroups.com
Content-Type: multipart/alternative; boundary=14dae9ccd5a291338f04c9ee5461
--14dae9ccd5a291338f04c9ee5461
Content-Type: text/plain; charset=KOI8-R
I've just tested it, it works. Thanks, Anton and Ali!
Best regards,
Anton
On Tue, Sep 18, 2012 at 5:46 AM, <an...@angri.ru> wrote:
> The patch is now in master. Please test and let me know if something
> is not quite right.
>
> Thanks, Anton and Ali!
>
> --
> Anton
>
> 2012/9/13 <an...@angri.ru>:
> > Hi Anton, hi Ali,
> >
> > I'm sorry for the delay. I'm very short on free time these days, but
> > I'll definitely take care of the patches until the middle of next
> > week. Thanks!
> >
> > --
> > Anton
> >
> > 2012/9/13 Anton Beloglazov <anton.belogla...@gmail.com>:
> >> Hi Ali and Anton,
> >>
> >> Is there any problem with accepting the patches?
> >>
> >> Thanks,
> >> Anton
> >>
> >>
> >> On Sat, Sep 1, 2012 at 9:25 AM, Anton Beloglazov
> >> <anton.belogla...@gmail.com> wrote:
> >>>
> >>> A side note: I'll be away for the next two weeks. If there are any
> issues,
> >>> I'll only be able to look into them when I come back.
> >>>
> >>> Best regards,
> >>> Anton
> >>>
> >>>
> >>> On Sat, Sep 1, 2012 at 9:24 AM, Anton Beloglazov
> >>> <anton.belogla...@gmail.com> wrote:
> >>>>
> >>>> Hi Ali and Anton,
> >>>>
> >>>> Here are the patches (only decorators.py has been updated: I've added
> a
> >>>> raise_exceptions argument):
> >>>>
> >>>> For decorators.py:
> >>>>
> >>>> --- decorators-backup.py 2012-08-30 11:27:46.690981338 +1000
> >>>> +++ decorators.py 2012-09-01 09:18:43.820460019 +1000
> >>>> @@ -47,13 +47,15 @@
> >>>> exceptions.ModuleSyntaxError,
> >>>> exceptions.BadIdentifierError)
> >>>>
> >>>> -def _exception_handler(func):
> >>>> +def _exception_handler(func, raise_exceptions, error_return):
> >>>> def newfunc(*args, **kwds):
> >>>> try:
> >>>> return func(*args, **kwds)
> >>>> except exceptions.RopeError, e:
> >>>> short = None
> >>>> if isinstance(e, input_exceptions):
> >>>> + if not raise_exceptions:
> >>>> + return error_return
> >>>> short = _exception_message(e)
> >>>> logger(str(traceback.format_exc()), short)
> >>>> newfunc.__name__ = func.__name__
> >>>> @@ -72,10 +74,12 @@
> >>>> return func
> >>>> return decorator
> >>>>
> >>>> -
> >>>> -def local_command(key=None, prefix=False, shortcut=None, name=None):
> >>>> +def local_command(key=None, prefix=False, shortcut=None,
> >>>> + name=None, raise_exceptions=True,
> >>>> + error_return=None):
> >>>> def decorator(func, name=name):
> >>>> - func = _exception_handler(func)
> >>>> + func = _exception_handler(func, raise_exceptions,
> >>>> + error_return)
> >>>> func.kind = 'local'
> >>>> func.prefix = prefix
> >>>> func.local_key = key
> >>>> @@ -86,10 +90,15 @@
> >>>> return func
> >>>> return decorator
> >>>>
> >>>> +def local_function(error_return=None):
> >>>> + return local_command(raise_exceptions=False,
> >>>> + error_return=error_return)
> >>>>
> >>>> -def global_command(key=None, prefix=False):
> >>>> +def global_command(key=None, prefix=False, raise_exceptions=True,
> >>>> + error_return=None):
> >>>> def decorator(func):
> >>>> - func = _exception_handler(func)
> >>>> + func = _exception_handler(func, raise_exceptions,
> >>>> + error_return)
> >>>> func.kind = 'global'
> >>>> func.prefix = prefix
> >>>> func.global_key = key
> >>>>
> >>>> For interface.py
> >>>>
> >>>> --- interface-backup.py 2012-07-17 10:24:30.611629650 +1000
> >>>> +++ interface.py 2012-08-29 10:42:22.736438024 +1000
> >>>> @@ -157,7 +157,7 @@
> >>>> def pop_mark(self):
> >>>> self.env.pop_mark()
> >>>>
> >>>> - @decorators.local_command()
> >>>> + @decorators.local_function()
> >>>> def definition_location(self):
> >>>> definition = self._base_definition_location()
> >>>> if definition:
> >>>> @@ -182,7 +182,7 @@
> >>>> self._check_project()
> >>>> self._base_show_doc(prefix,
> >>>> self._base_get_doc(codeassist.get_doc))
> >>>>
> >>>> - @decorators.local_command()
> >>>> + @decorators.local_function()
> >>>> def get_calltip(self):
> >>>> self._check_project()
> >>>> def _get_doc(project, text, offset, *args, **kwds):
> >>>> @@ -203,7 +203,7 @@
> >>>> else:
> >>>> self.env.message('No docs available!')
> >>>>
> >>>> - @decorators.local_command()
> >>>> + @decorators.local_function()
> >>>> def get_doc(self):
> >>>> self._check_project()
> >>>> return self._base_get_doc(codeassist.get_doc)
> >>>> @@ -275,11 +275,11 @@
> >>>> def auto_import(self):
> >>>> _CodeAssist(self, self.env).auto_import()
> >>>>
> >>>> - @decorators.local_command()
> >>>> + @decorators.local_function([])
> >>>> def completions(self):
> >>>> return _CodeAssist(self, self.env).completions()
> >>>>
> >>>> - @decorators.local_command()
> >>>> + @decorators.local_function([])
> >>>> def extended_completions(self):
> >>>> return _CodeAssist(self, self.env).extended_completions()
> >>>>
> >>>> Thanks,
> >>>> Anton
> >>>>
> >>>> On Fri, Aug 31, 2012 at 7:57 PM, Ali Gholami Rudi <aligr...@gmail.com
> >
> >>>> wrote:
> >>>>>
> >>>>> Hi Anton,
> >>>>>
> >>>>> Anton Beloglazov <anton.belogla...@gmail.com> wrote:
> >>>>> > Thanks for the explanation! In my opinion, the two parameter
> approach
> >>>>> > is
> >>>>> > easier to understand since it's more explicit and doesn't require
> any
> >>>>> > special values.
> >>>>>
> >>>>> That's OK with me and please update your patch.
> >>>>>
> >>>>> Thanks,
> >>>>> Ali
> >>>>>
> >>>>
> >>>
> >>
>
--14dae9ccd5a291338f04c9ee5461
Content-Type: text/html; charset=KOI8-R
Content-Transfer-Encoding: quoted-printable
I've just tested it, it works.=9AThanks, Anton and Ali!<div><br></div><=
div>Best regards,</div><div>Anton<br><br><div class=3D"gmail_quote">On Tue,=
Sep 18, 2012 at 5:46 AM, <span dir=3D"ltr"><<a href=3D"mailto:anton@an=
gri.ru" target=3D"_blank">an...@angri.ru</a>></span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">The patch is now in master. Please test and =
let me know if something<br>
is not quite right.<br>
<br>
Thanks, Anton and Ali!<br>
<br>
--<br>
Anton<br>
<br>
2012/9/13 =9A<<a href=3D"mailto:an...@angri.ru">an...@angri.ru</a>>:<=
br>
<div class=3D"HOEnZb"><div class=3D"h5">> Hi Anton, hi Ali,<br>
><br>
> I'm sorry for the delay. I'm very short on free time these day=
s, but<br>
> I'll definitely take care of the patches until the middle of next<=
br>
> week. Thanks!<br>
><br>
> --<br>
> Anton<br>
><br>
> 2012/9/13 Anton Beloglazov <<a href=3D"mailto:anton.beloglazov@gmai=
l.com">anton.belogla...@gmail.com</a>>:<br>
>> Hi Ali and Anton,<br>
>><br>
>> Is there any problem with accepting the patches?<br>
>><br>
>> Thanks,<br>
>> Anton<br>
>><br>
>><br>
>> On Sat, Sep 1, 2012 at 9:25 AM, Anton Beloglazov<br>
>> <<a href=3D"mailto:anton.belogla...@gmail.com">anton.beloglazov=
@gmail.com</a>> wrote:<br>
>>><br>
>>> A side note: I'll be away for the next two weeks. If there=
are any issues,<br>
>>> I'll only be able to look into them when I come back.<br>
>>><br>
>>> Best regards,<br>
>>> Anton<br>
>>><br>
>>><br>
>>> On Sat, Sep 1, 2012 at 9:24 AM, Anton Beloglazov<br>
>>> <<a href=3D"mailto:anton.belogla...@gmail.com">anton.belogl=
a...@gmail.com</a>> wrote:<br>
>>>><br>
>>>> Hi Ali and Anton,<br>
>>>><br>
>>>> Here are the patches (only decorators.py has been updated:=
I've added a<br>
>>>> raise_exceptions argument):<br>
>>>><br>
>>>> For decorators.py:<br>
>>>><br>
>>>> --- decorators-backup.py 2012-08-30 11:27:46.690981338 +10=
00<br>
>>>> +++ decorators.py 2012-09-01 09:18:43.820460019 +1000<br>
>>>> @@ -47,13 +47,15 @@<br>
>>>> =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9Aexceptions.Modu=
leSyntaxError,<br>
>>>> =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9Aexceptions.BadI=
dentifierError)<br>
>>>><br>
>>>> -def _exception_handler(func):<br>
>>>> +def _exception_handler(func, raise_exceptions, error_retu=
rn):<br>
>>>> =9A =9A =9Adef newfunc(*args, **kwds):<br>
>>>> =9A =9A =9A =9A =9Atry:<br>
>>>> =9A =9A =9A =9A =9A =9A =9Areturn func(*args, **kwds)<br>
>>>> =9A =9A =9A =9A =9Aexcept exceptions.RopeError, e:<br>
>>>> =9A =9A =9A =9A =9A =9A =9Ashort =3D None<br>
>>>> =9A =9A =9A =9A =9A =9A =9Aif isinstance(e, input_exceptio=
ns):<br>
>>>> + =9A =9A =9A =9A =9A =9A =9A =9Aif not raise_exceptions:<=
br>
>>>> + =9A =9A =9A =9A =9A =9A =9A =9A =9A =9Areturn error_retu=
rn<br>
>>>> =9A =9A =9A =9A =9A =9A =9A =9A =9Ashort =3D _exception_me=
ssage(e)<br>
>>>> =9A =9A =9A =9A =9A =9A =9Alogger(str(traceback.format_exc=
()), short)<br>
>>>> =9A =9A =9Anewfunc.__name__ =3D func.__name__<br>
>>>> @@ -72,10 +74,12 @@<br>
>>>> =9A =9A =9A =9A =9Areturn func<br>
>>>> =9A =9A =9Areturn decorator<br>
>>>><br>
>>>> -<br>
>>>> -def local_command(key=3DNone, prefix=3DFalse, shortcut=3D=
None, name=3DNone):<br>
>>>> +def local_command(key=3DNone, prefix=3DFalse, shortcut=3D=
None,<br>
>>>> + =9A =9A =9A =9A =9A =9A =9A =9A =9Aname=3DNone, raise_ex=
ceptions=3DTrue,<br>
>>>> + =9A =9A =9A =9A =9A =9A =9A =9A =9Aerror_return=3DNone):=
<br>
>>>> =9A =9A =9Adef decorator(func, name=3Dname):<br>
>>>> - =9A =9A =9A =9Afunc =3D _exception_handler(func)<br>
>>>> + =9A =9A =9A =9Afunc =3D _exception_handler(func, raise_e=
xceptions,<br>
>>>> + =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =
=9A =9A =9Aerror_return)<br>
>>>> =9A =9A =9A =9A =9Afunc.kind =3D 'local'<br>
>>>> =9A =9A =9A =9A =9Afunc.prefix =3D prefix<br>
>>>> =9A =9A =9A =9A =9Afunc.local_key =3D key<br>
>>>> @@ -86,10 +90,15 @@<br>
>>>> =9A =9A =9A =9A =9Areturn func<br>
>>>> =9A =9A =9Areturn decorator<br>
>>>><br>
>>>> +def local_function(error_return=3DNone):<br>
>>>> + =9A =9A =9A return local_command(raise_exceptions=3DFals=
e,<br>
>>>> + =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9Ae=
rror_return=3Derror_return)<br>
>>>><br>
>>>> -def global_command(key=3DNone, prefix=3DFalse):<br>
>>>> +def global_command(key=3DNone, prefix=3DFalse, raise_exce=
ptions=3DTrue,<br>
>>>> + =9A =9A =9A =9A =9A =9A =9A =9A =9A error_return=3DNone)=
:<br>
>>>> =9A =9A =9Adef decorator(func):<br>
>>>> - =9A =9A =9A =9Afunc =3D _exception_handler(func)<br>
>>>> + =9A =9A =9A =9Afunc =3D _exception_handler(func, raise_e=
xceptions,<br>
>>>> + =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =9A =
=9A =9A =9Aerror_return)<br>
>>>> =9A =9A =9A =9A =9Afunc.kind =3D 'global'<br>
>>>> =9A =9A =9A =9A =9Afunc.prefix =3D prefix<br>
>>>> =9A =9A =9A =9A =9Afunc.global_key =3D key<br>
>>>><br>
>>>> For interface.py<br>
>>>><br>
>>>> --- interface-backup.py 2012-07-17 10:24:30.611629650 +100=
0<br>
>>>> +++ interface.py 2012-08-29 10:42:22.736438024 +1000<br>
>>>> @@ -157,7 +157,7 @@<br>
>>>> =9A =9A =9Adef pop_mark(self):<br>
>>>> =9A =9A =9A =9A =9Aself.env.pop_mark()<br>
>>>><br>
>>>> - =9A =...@decorators.local_command()<br>
>>>> + =9A =...@decorators.local_function()<br>
>>>> =9A =9A =9Adef definition_location(self):<br>
>>>> =9A =9A =9A =9A =9Adefinition =3D self._base_definition_lo=
cation()<br>
>>>> =9A =9A =9A =9A =9Aif definition:<br>
>>>> @@ -182,7 +182,7 @@<br>
>>>> =9A =9A =9A =9A =9Aself._check_project()<br>
>>>> =9A =9A =9A =9A =9Aself._base_show_doc(prefix,<br>
>>>> self._base_get_doc(codeassist.get_doc))<br>
>>>><br>
>>>> - =9A =...@decorators.local_command()<br>
>>>> + =9A =...@decorators.local_function()<br>
>>>> =9A =9A =9Adef get_calltip(self):<br>
>>>> =9A =9A =9A =9A =9Aself._check_project()<br>
>>>> =9A =9A =9A =9A =9Adef _get_doc(project, text, offset, *ar=
gs, **kwds):<br>
>>>> @@ -203,7 +203,7 @@<br>
>>>> =9A =9A =9A =9A =9Aelse:<br>
>>>> =9A =9A =9A =9A =9A =9A =9Aself.env.message('No docs a=
vailable!')<br>
>>>><br>
>>>> - =9A =...@decorators.local_command()<br>
>>>> + =9A =...@decorators.local_function()<br>
>>>> =9A =9A =9Adef get_doc(self):<br>
>>>> =9A =9A =9A =9A =9Aself._check_project()<br>
>>>> =9A =9A =9A =9A =9Areturn self._base_get_doc(codeassist.ge=
t_doc)<br>
>>>> @@ -275,11 +275,11 @@<br>
>>>> =9A =9A =9Adef auto_import(self):<br>
>>>> =9A =9A =9A =9A =9A_CodeAssist(self, self.env).auto_import=
()<br>
>>>><br>
>>>> - =9A =...@decorators.local_command()<br>
>>>> + =9A =...@decorators.local_function([])<br>
>>>> =9A =9A =9Adef completions(self):<br>
>>>> =9A =9A =9A =9A =9Areturn _CodeAssist(self, self.env).comp=
letions()<br>
>>>><br>
>>>> - =9A =...@decorators.local_command()<br>
>>>> + =9A =...@decorators.local_function([])<br>
>>>> =9A =9A =9Adef extended_completions(self):<br>
>>>> =9A =9A =9A =9A =9Areturn _CodeAssist(self, self.env).exte=
nded_completions()<br>
>>>><br>
>>>> Thanks,<br>
>>>> Anton<br>
>>>><br>
>>>> On Fri, Aug 31, 2012 at 7:57 PM, Ali Gholami Rudi <<a h=
ref=3D"mailto:aligr...@gmail.com">aligr...@gmail.com</a>><br>
>>>> wrote:<br>
>>>>><br>
>>>>> Hi Anton,<br>
>>>>><br>
>>>>> Anton Beloglazov <<a href=3D"mailto:anton.beloglazo=
v...@gmail.com">anton.belogla...@gmail.com</a>> wrote:<br>
>>>>> > Thanks for the explanation! In my opinion, the tw=
o parameter approach<br>
>>>>> > is<br>
>>>>> > easier to understand since it's more explicit=
and doesn't require any<br>
>>>>> > special values.<br>
>>>>><br>
>>>>> That's OK with me and please update your patch.<br=
>
>>>>><br>
>>>>> Thanks,<br>
>>>>> Ali<br>
>>>>><br>
>>>><br>
>>><br>
>><br>
</div></div></blockquote></div><br></div>
--14dae9ccd5a291338f04c9ee5461--
Message from discussion Patches: noerror option to code_assist
| Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy |
| ©2013 Google |