Patch to support "extended completion" - rope-dev

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion Patch to support "extended completion"
Received-SPF: fail (google.com: domain of jstpie...@mecheye.net does not designate 209.85.221.200 as permitted sender) client-ip=209.85.221.200;
MIME-Version: 1.0
In-Reply-To: <n2g91b249311004290019y984dff7eq13076190fc146a3a@mail.gmail.com>
References: <m2z2c1d48a71004271857j68014039kc57778f3ef37feac@mail.gmail.com>
	 <n2g91b249311004290019y984dff7eq13076190fc146a3a@mail.gmail.com>
Date: Thu, 29 Apr 2010 04:03:59 -0400
Message-ID: <z2m2c1d48a71004290103y94bd8b4dt2a31f95b46779c35@mail.gmail.com>
Subject: Re: Patch to support "extended completion"
From: "Jasper St. Pierre" <jstpie...@mecheye.net>
To: rope-dev@googlegroups.com
Reply-To: rope-dev@googlegroups.com
Precedence: list
Mailing-list: list rope-dev@googlegroups.com; contact rope-dev+owners@googlegroups.com
Sender: rope-dev@googlegroups.com
Content-Type: multipart/alternative; boundary=0016364ee308aa813f04855b91a8

--0016364ee308aa813f04855b91a8
Content-Type: text/plain; charset=ISO-8859-1

It's currently in here:

http://github.com/magcius/auto-complete/

Which I will try to get upstream as soon as the patch is integrated.
<http://github.com/magcius/auto-complete/>
On Thu, Apr 29, 2010 at 3:19 AM, Darren Hoo <darren....@gmail.com> wrote:

> Hi,
>
> On Wed, Apr 28, 2010 at 9:57 AM, Jasper St. Pierre
> <jstpie...@mecheye.net> wrote:
> > I am currently in the process of making a ropemacs auto-complete backend.
> > Here is the patch to support that:
> > diff -r 364ab6aeb8e9 ropemode/interface.py
> > --- a/ropemode/interface.py Tue Apr 27 19:53:45 2010 +0400
> > +++ b/ropemode/interface.py Tue Apr 27 21:55:06 2010 -0400
> > @@ -272,6 +272,10 @@
> >      def completions(self):
> >          return _CodeAssist(self, self.env).completions()
> >
> > +    @decorators.local_command()
> > +    def extended_completions(self):
> > +        return _CodeAssist(self, self.env).extended_completions()
> > +
> >      def _check_autoimport(self):
> >          self._check_project()
> >          if self.autoimport is None:
> > @@ -590,6 +594,12 @@
> >          return [self.env._completion_text(proposal)[prefix:]
> >                  for proposal in proposals]
> >
> > +    def extended_completions(self):
> > +        proposals = self._calculate_proposals()
> > +        prefix = self.offset - self.starting_offset
> > +        return [[proposal.name[prefix:], proposal.get_doc(),
> > + proposal.type] for proposal in proposals]
> > +
> >      def _apply_assist(self, assist):
> >          if ' : ' in assist:
> >              name, module = assist.rsplit(' : ', 1)
> >
> this patch works for me.
>
> People who use company-mode can use this patch to make
> of this extended complete, the info will show in the echo area
>
> --- company-ropemacs.new.el     2010-04-29 14:55:24.766121479 +0800
> +++ company-ropemacs.el 2010-04-29 14:56:15.000000000 +0800
> @@ -63,6 +63,9 @@
>                   (company-ropemacs--grab-symbol)))
>     ('candidates (mapcar (lambda (element) (concat arg element))
>                          (rope-completions)))
> +    ('meta (let* ((completions (rope-extended-completions))
> +                 (match (assoc arg completions)))
> +            (concat (propertize arg 'face 'font-lock-doc-face) ": " (caddr
> match))))
>     ('doc-buffer (company-ropemacs-doc-buffer arg))
>     ('location (company-ropemacs-location arg))))
>
> there's one nuisance here, that is if the completion is an instance
> for example if it is a string , it will return the documentation of
> string class ,I think this is too much verbose, return something like
> "type String" will be enough IMHO. so I have not added doc in
> the above patch, add it if  that's ok for  you. also you can press
> F1 on the selected completion candidate to get docuementation of
> it in company-mode.
>

--0016364ee308aa813f04855b91a8
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

It&#39;s currently in here:<div><br></div><div><a href=3D"http://github.com=
/magcius/auto-complete/">http://github.com/magcius/auto-complete/</a></div>=
<div><br></div><div>Which I will try to get upstream as soon as the patch i=
s integrated.</div>
<div><a href=3D"http://github.com/magcius/auto-complete/"></a><br><div><div=
><div class=3D"gmail_quote">On Thu, Apr 29, 2010 at 3:19 AM, Darren Hoo <sp=
an dir=3D"ltr">&lt;<a href=3D"mailto:darren....@gmail.com">darren.hoo@gmail=
.com</a>&gt;</span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex;">Hi,<br>
<div><div></div><div class=3D"h5"><br>
On Wed, Apr 28, 2010 at 9:57 AM, Jasper St. Pierre<br>
&lt;<a href=3D"mailto:jstpie...@mecheye.net">jstpie...@mecheye.net</a>&gt; =
wrote:<br>
&gt; I am currently in the process of making a ropemacs auto-complete backe=
nd.<br>
&gt; Here is the patch to support that:<br>
&gt; diff -r 364ab6aeb8e9 ropemode/interface.py<br>
&gt; --- a/ropemode/interface.py Tue Apr 27 19:53:45 2010 +0400<br>
&gt; +++ b/ropemode/interface.py Tue Apr 27 21:55:06 2010 -0400<br>
&gt; @@ -272,6 +272,10 @@<br>
&gt; =A0=A0 =A0 def completions(self):<br>
&gt; =A0=A0 =A0 =A0 =A0 return _CodeAssist(self, self.env).completions()<br=
>
&gt;<br>
&gt; + =A0 =...@decorators.local_command()<br>
&gt; + =A0 =A0def extended_completions(self):<br>
&gt; + =A0 =A0 =A0 =A0return _CodeAssist(self, self.env).extended_completio=
ns()<br>
&gt; +<br>
&gt; =A0=A0 =A0 def _check_autoimport(self):<br>
&gt; =A0=A0 =A0 =A0 =A0 self._check_project()<br>
&gt; =A0=A0 =A0 =A0 =A0 if self.autoimport is None:<br>
&gt; @@ -590,6 +594,12 @@<br>
&gt; =A0=A0 =A0 =A0 =A0 return [self.env._completion_text(proposal)[prefix:=
]<br>
&gt; =A0=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 for proposal in proposals]<br>
&gt;<br>
&gt; + =A0 =A0def extended_completions(self):<br>
&gt; + =A0 =A0 =A0 =A0proposals =3D self._calculate_proposals()<br>
&gt; + =A0 =A0 =A0 =A0prefix =3D self.offset - self.starting_offset<br>
&gt; + =A0 =A0 =A0 =A0return [[<a href=3D"http://proposal.name" target=3D"_=
blank">proposal.name</a>[prefix:], proposal.get_doc(),<br>
&gt; + proposal.type] for proposal in proposals]<br>
&gt; +<br>
&gt; =A0=A0 =A0 def _apply_assist(self, assist):<br>
&gt; =A0=A0 =A0 =A0 =A0 if &#39; : &#39; in assist:<br>
&gt; =A0=A0 =A0 =A0 =A0 =A0 =A0 name, module =3D assist.rsplit(&#39; : &#39=
;, 1)<br>
&gt;<br>
</div></div>this patch works for me.<br>
<br>
People who use company-mode can use this patch to make<br>
of this extended complete, the info will show in the echo area<br>
<br>
--- company-ropemacs.new.el =A0 =A0 2010-04-29 14:55:24.766121479 +0800<br>
+++ company-ropemacs.el 2010-04-29 14:56:15.000000000 +0800<br>
@@ -63,6 +63,9 @@<br>
 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (company-ropemacs--grab-symbol)))<br>
 =A0 =A0 (&#39;candidates (mapcar (lambda (element) (concat arg element))<b=
r>
 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(rope-completions)))<br=
>
+ =A0 =A0(&#39;meta (let* ((completions (rope-extended-completions))<br>
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (match (assoc arg completions)))<br>
+ =A0 =A0 =A0 =A0 =A0 =A0(concat (propertize arg &#39;face &#39;font-lock-d=
oc-face) &quot;: &quot; (caddr match))))<br>
 =A0 =A0 (&#39;doc-buffer (company-ropemacs-doc-buffer arg))<br>
 =A0 =A0 (&#39;location (company-ropemacs-location arg))))<br>
<br>
there&#39;s one nuisance here, that is if the completion is an instance<br>
for example if it is a string , it will return the documentation of<br>
string class ,I think this is too much verbose, return something like<br>
&quot;type String&quot; will be enough IMHO. so I have not added doc in<br>
the above patch, add it if =A0that&#39;s ok for =A0you. also you can press<=
br>
F1 on the selected completion candidate to get docuementation of<br>
it in company-mode.<br>
</blockquote></div><br></div></div></div>
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
