                                                                                                                                                                                                                                                                
Received-SPF: pass (google.com: domain of takafum...@gmail.com designates 209.85.216.175 as permitted sender) client-ip=209.85.216.175;
MIME-Version: 1.0
Sender: takafum...@gmail.com
In-Reply-To: <20122503154...@lilem.mirepesht>
References: <CAPM+gBR2Dv1Pf+FGyWMRo_+d4qwoM5X_ZXW2+t_CAU--mSK...@mail.gmail.com>
 <20122303154...@lilem.mirepesht> <CAPM+gBRVvd=Wg=xPSb_vuMG8oOfW9DSCPyj4sP0Nkyx=NLu...@mail.gmail.com>
 <20122403092...@lilem.mirepesht> <CAPM+gBTj5aRJiASsvBhkQFLGyT0DYb4B57z1_34xGg=uMvn...@mail.gmail.com>
 <20122403165...@lilem.mirepesht> <CAPM+gBTx9Hi+q=XbLnfhRHGLLbsTSw=hnzUdtmXz=Eja1mg...@mail.gmail.com>
 <20122503000...@lilem.mirepesht> <CAPM+gBQTVjj9doWxFKsvZTxjG+3zJ68fAy4=pyzabr0RUVM...@mail.gmail.com>
 <20122503080...@lilem.mirepesht> <20122503083...@lilem.mirepesht>
 <CAPM+gBRvBVA+yxVr5juaLSom9KmtHhQkjatuCc39echPJ7c...@mail.gmail.com>
 <CAPM+gBTUZTd8Z5rANj6LG+bo--x9Rg8=yyV73s03DU1WXRM...@mail.gmail.com> <20122503154...@lilem.mirepesht>
From: Takafumi Arakaki <aka....@gmail.com>
Date: Sun, 25 Mar 2012 14:37:31 +0200
Message-ID: <CAPM+gBTiKKQQaM9O7LRQNaBZ21f4GMQNr08qEJDyeoifR=5...@mail.gmail.com>
Subject: Re: Patches: noerror option to code_assist
To: Ali Gholami Rudi <aligr...@gmail.com>
Cc: rope-dev <rope-dev@googlegroups.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 25, 2012 at 1:12 PM, Ali Gholami Rudi <aligr...@gmail.com> wrot=
e:
> Hi Takafumi,
>
> Takafumi Arakaki <aka....@gmail.com> wrote:
>> diff -r bd969e488130 -r 1e251abf45c2 ropemode/interface.py
>> --- a/ropemode/interface.py =A0 Wed Feb 08 12:16:43 2012 +0800
>> +++ b/ropemode/interface.py =A0 Sun Mar 25 10:01:31 2012 +0200
>> @@ -626,13 +626,19 @@
>>
>> =A0 =A0 =A0def _calculate_proposals(self):
>> =A0 =A0 =A0 =A0 =A0self.interface._check_project()
>> =A0 =A0 =A0 =A0 =A0resource =3D self.interface.resource
>> =A0 =A0 =A0 =A0 =A0maxfixes =3D self.env.get('codeassist_maxfixes')
>> - =A0 =A0 =A0 =A0proposals =3D codeassist.code_assist(
>> - =A0 =A0 =A0 =A0 =A0 =A0self.interface.project, self.source, self.offse=
t,
>> - =A0 =A0 =A0 =A0 =A0 =A0resource, maxfixes=3Dmaxfixes)
>> + =A0 =A0 =A0 =A0try:
>> + =A0 =A0 =A0 =A0 =A0 =A0proposals =3D codeassist.code_assist(
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0self.interface.project, self.source, se=
lf.offset,
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0resource, maxfixes=3Dmaxfixes)
>> + =A0 =A0 =A0 =A0except exceptions.ModuleSyntaxError as err:
>> + =A0 =A0 =A0 =A0 =A0 =A0if self.env.get('codeassist_noerror'):
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0proposals =3D []
>> + =A0 =A0 =A0 =A0 =A0 =A0else:
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0raise err
>> =A0 =A0 =A0 =A0 =A0if self.env.get('sorted_completions', True):
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0proposals =3D codeassist.sorted_proposals(pro=
posals)
>> =A0 =A0 =A0 =A0 =A0if self.autoimport is not None:
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0if self.starting.strip() and '.' not in self.=
expression:
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0import_assists =3D self.autoimport.im=
port_assist(self.starting)
>
> Thanks. =A0Only one suggestion: as I mentioned in my previous mail, noerr=
or
> probably makes sense only for functions, like ropevim_completions, not
> for commands like ropevim_codeassist. =A0Almost always, users prefer a
> message like "rope failed to ..." =A0when there are errors, rather than a=
n
> empty response which may mean no completions. =A0For commands, something
> like brieferrors makes more sense, though that's another story.
>
> So I suggest moving the try-expect block to the functions calling
> _calculate_proposals(), or passing a noerror argument to it, which
> is true only in functions. =A0Like completions() and extended_completions=
().
>
> Thanks,
> Ali
>

Here you go!
https://bitbucket.org/agr/ropemode/pull-request/5/

If it is just for completions() and extended_completions(), isn't it
better to use argument instead of a global variable?  My aim was to
provide a global way to control the error messages because you can
call any commands and functions from outside of ropemode and caller
may want to suppress the errors.

What is the use case you have in mind? (1) rope user may set the
default for noerror option but the external module can override the
default by dynamically changing it; (2) rope users set the value and
external module should not alter the value. if the users want to see
the errors while calling completions via the external module, let them
see it.

I have (1) in mind, so having argument for that makes more sense, if
you really want to distinguish APIs (completions and
extended_completions) and interactive commands.  But if (2) is the
goal, having global variable for it is better. I like the idea of (1)
because user benefits a lot without a special setup.


Best,
Takafumi