> Takafumi Arakaki <aka...@gmail.com <javascript:>> wrote:
> > > When there is no completion, signal an error is good but a multi-line
> > > error message is not because it causes the minibuffer to enlarge which
> > > is visually disturbing.

> > Yes, that's exactly why I wanted to send the patches.

> I think it is better to change rope/contrib/fixerror.py, since AFAIR,
> it is the only place we use multi-line short exception messages.

>         Ali

> On 2012-08-23 21:59 +0800, Ali Gholami Rudi wrote:
> > I meant something like this patch for rope.  Not tested, so it
> > may need to be tweaked to work.

> Note that Pymacs (0.25 and above) no longer prints the whole backtrace
> unless debug-on-error is non-nil.

> Leo

> I think that's a good idea.  Did you test it?

> > On Friday, 24 August 2012 09:41:44 UTC+10, Leo wrote:
> > > Note that Pymacs (0.25 and above) no longer prints the whole backtrace
> > > unless debug-on-error is non-nil.

> I don't think that would help, since we do want the error
> message but the message is too long; codeassist syntax
> errors have multi-line messages, each line describing an
> attempt to fix the error.  The patch in my previous
> mail made it less verbose.

>         Ali

> Do you know what could be the reason for such behavior?

> Anton Beloglazov <anton.belogla...@gmail.com> wrote:
> > Sorry for the delay. I've tested your patch: the error message has got
> > indeed reduced into one line. However, the mini buffer still expands into
> > multiple lines for some reason. Here is a screenshot:
> > http://i.imgbox.com/ady0ackX.jpg

> > Do you know what could be the reason for such behavior?

> Odd...  Does the included patch make any difference.

>         Ali

> --- a/rope/contrib/fixsyntax.py 2012-08-27 19:42:30.516015457 +0430
> +++ b/rope/contrib/fixsyntax.py 2012-08-27 19:45:00.236235582 +0430
> @@ -15,7 +15,7 @@
>      @utils.saveit
>      def get_pymodule(self):
>          """Get a `PyModule`"""
> -        errors = []
> +        msg = None
>          code = self.code
>          tries = 0
>          while True:
> @@ -27,19 +27,14 @@
>                  return self.pycore.get_string_module(
>                      code, resource=self.resource, force_errors=True)
>              except exceptions.ModuleSyntaxError, e:
> +                if msg is None:
> +                    msg = '%s:%s %s' % (e.filename, e.lineno,
> e.message_.rstrip())
>                  if tries < self.maxfixes:
>                      tries += 1
>                      self.commenter.comment(e.lineno)
>                      code = '\n'.join(self.commenter.lines)
> -                    errors.append('  * line %s: %s ... fixed' % (e.lineno,
> -
> e.message_))
>                  else:
> -                    errors.append('  * line %s: %s ... raised!' %
> (e.lineno,
> -
> e.message_))
> -                    new_message = ('\nSyntax errors in file %s:\n' %
> e.filename) \
> -                                   + '\n'.join(errors)
> -                    raise exceptions.ModuleSyntaxError(e.filename,
> e.lineno,
> -                                                       new_message)
> +                    raise exceptions.ModuleSyntaxError(e.filename,
> e.lineno, msg)

>      @property
>      @utils.saveit

> Best regards,
> Anton

> On Tue, Aug 28, 2012 at 1:05 AM, Ali Gholami Rudi <aligr...@gmail.com>wrote:

>> Hi,

>> Anton Beloglazov <anton.belogla...@gmail.com> wrote:
>> > Sorry for the delay. I've tested your patch: the error message has got
>> > indeed reduced into one line. However, the mini buffer still expands
>> into
>> > multiple lines for some reason. Here is a screenshot:
>> > http://i.imgbox.com/ady0ackX.jpg

>> > Do you know what could be the reason for such behavior?

>> Odd...  Does the included patch make any difference.

>>         Ali

>> --- a/rope/contrib/fixsyntax.py 2012-08-27 19:42:30.516015457 +0430
>> +++ b/rope/contrib/fixsyntax.py 2012-08-27 19:45:00.236235582 +0430
>> @@ -15,7 +15,7 @@
>>      @utils.saveit
>>      def get_pymodule(self):
>>          """Get a `PyModule`"""
>> -        errors = []
>> +        msg = None
>>          code = self.code
>>          tries = 0
>>          while True:
>> @@ -27,19 +27,14 @@
>>                  return self.pycore.get_string_module(
>>                      code, resource=self.resource, force_errors=True)
>>              except exceptions.ModuleSyntaxError, e:
>> +                if msg is None:
>> +                    msg = '%s:%s %s' % (e.filename, e.lineno,
>> e.message_.rstrip())
>>                  if tries < self.maxfixes:
>>                      tries += 1
>>                      self.commenter.comment(e.lineno)
>>                      code = '\n'.join(self.commenter.lines)
>> -                    errors.append('  * line %s: %s ... fixed' %
>> (e.lineno,
>> -
>> e.message_))
>>                  else:
>> -                    errors.append('  * line %s: %s ... raised!' %
>> (e.lineno,
>> -
>> e.message_))
>> -                    new_message = ('\nSyntax errors in file %s:\n' %
>> e.filename) \
>> -                                   + '\n'.join(errors)
>> -                    raise exceptions.ModuleSyntaxError(e.filename,
>> e.lineno,
>> -                                                       new_message)
>> +                    raise exceptions.ModuleSyntaxError(e.filename,
>> e.lineno, msg)

>>      @property
>>      @utils.saveit

> I've just found that this message is popped up by eldoc-mode. I'm
> using rope-get-calltip as eldoc-documentation-function. Due to syntax
> errors, it failed all the time and displayed that message. To fix this,
> I've modified the get_calltip function in rope/contrib/codeassist.py. Here
> is the patch:

> --- codeassist.py 2012-08-28 12:17:06.801540893 +1000
> +++ codeassist-patched.py 2012-08-28 12:12:31.444884763 +1000
> @@ -90,7 +90,10 @@
>      """
>      fixer = fixsyntax.FixSyntax(project.pycore, source_code,
>                                  resource, maxfixes)
> -    pymodule = fixer.get_pymodule()
> +    try:
> +        pymodule = fixer.get_pymodule()
> +    except exceptions.ModuleSyntaxError:
> +        return None
>      pyname = fixer.pyname_at(offset)
>      if pyname is None:
>          return None

> Now it just displays nothing if there is a syntax error, which I think is
> reasonable for this purpose. Otherwise, it continuously shows up error
> messages, which is very annoying.

> Thanks,
> Anton

> On Tue, Aug 28, 2012 at 11:42 AM, Anton Beloglazov <
> anton.belogla...@gmail.com> wrote:

>> Thanks, Ali. Unfortunately, this has not fixed the problem. Here is a new
>> screenshot: http://i.imgbox.com/abvW3Bjc.jpg

>> Best regards,
>> Anton

>> On Tue, Aug 28, 2012 at 1:05 AM, Ali Gholami Rudi <aligr...@gmail.com>wrote:

>>> Hi,

>>> Anton Beloglazov <anton.belogla...@gmail.com> wrote:
>>> > Sorry for the delay. I've tested your patch: the error message has got
>>> > indeed reduced into one line. However, the mini buffer still expands
>>> into
>>> > multiple lines for some reason. Here is a screenshot:
>>> > http://i.imgbox.com/ady0ackX.jpg

>>> > Do you know what could be the reason for such behavior?

>>> Odd...  Does the included patch make any difference.

>>>         Ali

>>> --- a/rope/contrib/fixsyntax.py 2012-08-27 19:42:30.516015457 +0430
>>> +++ b/rope/contrib/fixsyntax.py 2012-08-27 19:45:00.236235582 +0430
>>> @@ -15,7 +15,7 @@
>>>      @utils.saveit
>>>      def get_pymodule(self):
>>>          """Get a `PyModule`"""
>>> -        errors = []
>>> +        msg = None
>>>          code = self.code
>>>          tries = 0
>>>          while True:
>>> @@ -27,19 +27,14 @@
>>>                  return self.pycore.get_string_module(
>>>                      code, resource=self.resource, force_errors=True)
>>>              except exceptions.ModuleSyntaxError, e:
>>> +                if msg is None:
>>> +                    msg = '%s:%s %s' % (e.filename, e.lineno,
>>> e.message_.rstrip())
>>>                  if tries < self.maxfixes:
>>>                      tries += 1
>>>                      self.commenter.comment(e.lineno)
>>>                      code = '\n'.join(self.commenter.lines)
>>> -                    errors.append('  * line %s: %s ... fixed' %
>>> (e.lineno,
>>> -
>>> e.message_))
>>>                  else:
>>> -                    errors.append('  * line %s: %s ... raised!' %
>>> (e.lineno,
>>> -
>>> e.message_))
>>> -                    new_message = ('\nSyntax errors in file %s:\n' %
>>> e.filename) \
>>> -                                   + '\n'.join(errors)
>>> -                    raise exceptions.ModuleSyntaxError(e.filename,
>>> e.lineno,
>>> -                                                       new_message)
>>> +                    raise exceptions.ModuleSyntaxError(e.filename,
>>> e.lineno, msg)

>>>      @property
>>>      @utils.saveit

> Anton Beloglazov <anton.belogla...@gmail.com> wrote:
> > I had to make a similar fix in the _code_completions function to suppress
> > the error reporting during auto-completion. The updated patch is below:

> I'm wondering if it is a good idea to make a distinction between
> ropemode commands and functions; for instance between rope-show-doc
> and rope-get-doc; the former is a command in ropemacs/ropevim, while
> the latter is a function that can be used in external commands.  If an
> error happens when performing a command, I think the user expects an
> error message (my fixsyntax.py patch makes one such error more compact,
> so I think it would be still useful).  But functions are invoked from
> elisp/vimscript and instead of breaking the call chain by throwing
> an exception, I think it is a better idea to return a special value.
> This is what your patches did, but I think that could be improved.

> At the moment both commands and functions are specified using the
> local_command decorator in ropemode/interface.py.  I suggest adding a
> local_function decorator in ropemode/decorators.py whose only argument is
> the value to return if an interrupt occurs, as in the included untested
> patch.  What do you think?  Is the default return value of completions
> and extended_completions acceptable?

> Thanks,
> Ali

> diff -u a/ropemode/decorators.py b/ropemode/decorators.py
> --- a/ropemode/decorators.py    2012-08-28 18:05:56.132361619 +0430
> +++ b/ropemode/decorators.py    2012-08-28 18:14:21.633103214 +0430
> @@ -47,13 +47,17 @@
>                      exceptions.ModuleSyntaxError,
>                      exceptions.BadIdentifierError)

> -def _exception_handler(func):
> +log_errors = object()
> +
> +def _exception_handler(func, error_return):
>      def newfunc(*args, **kwds):
>          try:
>              return func(*args, **kwds)
>          except exceptions.RopeError, e:
>              short = None
>              if isinstance(e, input_exceptions):
> +                if error_return is not log_errors:
> +                    return error_return
>                  short = _exception_message(e)
>              logger(str(traceback.format_exc()), short)
>      newfunc.__name__ = func.__name__
> @@ -72,10 +76,10 @@
>          return func
>      return decorator

> -
> -def local_command(key=None, prefix=False, shortcut=None, name=None):
> +def local_command(key=None, prefix=False, shortcut=None,
> +                  name=None, error_return=log_errors):
>      def decorator(func, name=name):
> -        func = _exception_handler(func)
> +        func = _exception_handler(func, error_return)
>          func.kind = 'local'
>          func.prefix = prefix
>          func.local_key = key
> @@ -86,10 +90,12 @@
>          return func
>      return decorator

> +def local_function(error_return=None):
> +       local_command(error_return=error_return)

>  def global_command(key=None, prefix=False):
>      def decorator(func):
> -        func = _exception_handler(func)
> +        func = _exception_handler(func, error_return)
>          func.kind = 'global'
>          func.prefix = prefix
>          func.global_key = key
> diff -u ropemode_/interface.py ropemode/interface.py
> --- ropemode_/interface.py      2012-08-28 18:05:56.132361619 +0430
> +++ ropemode/interface.py       2012-08-28 18:20:43.313655977 +0430
> @@ -157,7 +157,7 @@
>      def pop_mark(self):
>          self.env.pop_mark()

> -    @decorators.local_command()
> +    @decorators.local_function()
>      def definition_location(self):
>          definition = self._base_definition_location()
>          if definition:
> @@ -200,7 +200,7 @@
>          else:
>              self.env.message('No docs available!')

> -    @decorators.local_command()
> +    @decorators.local_function()
>      def get_doc(self):
>          self._check_project()
>          return self._base_get_doc(codeassist.get_doc)
> @@ -272,11 +272,11 @@
>      def auto_import(self):
>          _CodeAssist(self, self.env).auto_import()

> -    @decorators.local_command()
> +    @decorators.local_function([])
>      def completions(self):
>          return _CodeAssist(self, self.env).completions()

> -    @decorators.local_command()
> +    @decorators.local_function([])
>      def extended_completions(self):
>          return _CodeAssist(self, self.env).extended_completions()

> For decorators.py:

> --- decorators-backup.py 2012-07-17 10:24:30.611629650 +1000
> +++ decorators.py 2012-08-29 10:39:11.867472050 +1000

> For interface.py:

> --- interface-backup.py 2012-07-17 10:24:30.611629650 +1000
> +++ interface.py 2012-08-29 10:42:22.736438024 +1000

> Anton Beloglazov <anton.belogla...@gmail.com> wrote:
>> Nice generalization! I've tested your patch, and with a couple of
>> modifications it works fine. I've added 'return' in the local_function
>> definition, and made get_calltip a local_function as well. Here are the
>> updated patches:

>> --- decorators-backup.py 2012-07-17 10:24:30.611629650 +1000
>> +++ decorators.py 2012-08-29 10:39:11.867472050 +1000

>> For interface.py:

>> --- interface-backup.py 2012-07-17 10:24:30.611629650 +1000
>> +++ interface.py 2012-08-29 10:42:22.736438024 +1000

> I've CC'ed Anton Gritsay, the maintainer.  Anton, what do you think?
> I think this patch and also my patch to make fixsyntax.py errors terser
> (I've included the latter in this mail) look acceptable.

> --- a/rope/contrib/fixsyntax.py 2012-08-27 19:42:30.516015457 +0430
> +++ b/rope/contrib/fixsyntax.py 2012-08-27 19:45:00.236235582 +0430
> @@ -15,7 +15,7 @@
>      @utils.saveit
>      def get_pymodule(self):
>          """Get a `PyModule`"""
> -        errors = []
> +        msg = None
>          code = self.code
>          tries = 0
>          while True:
> @@ -27,19 +27,14 @@
>                  return self.pycore.get_string_module(
>                      code, resource=self.resource, force_errors=True)
>              except exceptions.ModuleSyntaxError, e:
> +                if msg is None:
> +                    msg = '%s:%s %s' % (e.filename, e.lineno, e.message_)
>                  if tries < self.maxfixes:
>                      tries += 1
>                      self.commenter.comment(e.lineno)
>                      code = '\n'.join(self.commenter.lines)
> -                    errors.append('  * line %s: %s ... fixed' % (e.lineno,
> -                                                                 e.message_))
>                  else:
> -                    errors.append('  * line %s: %s ... raised!' % (e.lineno,
> -                                                                   e.message_))
> -                    new_message = ('\nSyntax errors in file %s:\n' % e.filename) \
> -                                   + '\n'.join(errors)
> -                    raise exceptions.ModuleSyntaxError(e.filename, e.lineno,
> -                                                       new_message)
> +                    raise exceptions.ModuleSyntaxError(e.filename, e.lineno, msg)

>      @property
>      @utils.saveit

> 2012/8/29 Ali Gholami Rudi <aligr...@gmail.com>:
> > Hi,

> > Anton Beloglazov <anton.belogla...@gmail.com> wrote:
> >> Nice generalization! I've tested your patch, and with a couple of
> >> modifications it works fine. I've added 'return' in the local_function
> >> definition, and made get_calltip a local_function as well. Here are the
> >> updated patches:

> Anton, could you please explain me the semantic difference between
> local function and local command? It is also not clear for me why did
> you use singleton object for triggering "return on error" behaviour in
> _exception_handler(). Could it not be just boolean function parameter
> with default to False?

> And one more thing: how do I test if it works as it should? What are
> steps to reproduce the problem?

> >> For decorators.py:

> >> --- decorators-backup.py 2012-07-17 10:24:30.611629650 +1000
> >> +++ decorators.py 2012-08-29 10:39:11.867472050 +1000

> >> For interface.py:

> >> --- interface-backup.py 2012-07-17 10:24:30.611629650 +1000
> >> +++ interface.py 2012-08-29 10:42:22.736438024 +1000

> > I've CC'ed Anton Gritsay, the maintainer.  Anton, what do you think?
> > I think this patch and also my patch to make fixsyntax.py errors terser
> > (I've included the latter in this mail) look acceptable.

> I've committed this one. Thanks!

> --
> Anton

> > Thanks,
> > Ali

> > --- a/rope/contrib/fixsyntax.py 2012-08-27 19:42:30.516015457 +0430
> > +++ b/rope/contrib/fixsyntax.py 2012-08-27 19:45:00.236235582 +0430
> > @@ -15,7 +15,7 @@
> >      @utils.saveit
> >      def get_pymodule(self):
> >          """Get a `PyModule`"""
> > -        errors = []
> > +        msg = None
> >          code = self.code
> >          tries = 0
> >          while True:
> > @@ -27,19 +27,14 @@
> >                  return self.pycore.get_string_module(
> >                      code, resource=self.resource, force_errors=True)
> >              except exceptions.ModuleSyntaxError, e:
> > +                if msg is None:
> > +                    msg = '%s:%s %s' % (e.filename, e.lineno,
> e.message_)
> >                  if tries < self.maxfixes:
> >                      tries += 1
> >                      self.commenter.comment(e.lineno)
> >                      code = '\n'.join(self.commenter.lines)
> > -                    errors.append('  * line %s: %s ... fixed' %
> (e.lineno,
> > -
> e.message_))
> >                  else:
> > -                    errors.append('  * line %s: %s ... raised!' %
> (e.lineno,
> > -
> e.message_))
> > -                    new_message = ('\nSyntax errors in file %s:\n' %
> e.filename) \
> > -                                   + '\n'.join(errors)
> > -                    raise exceptions.ModuleSyntaxError(e.filename,
> e.lineno,
> > -                                                       new_message)
> > +                    raise exceptions.ModuleSyntaxError(e.filename,
> e.lineno, msg)

> >      @property
> >      @utils.saveit

> Anton Beloglazov <anton.belogla...@gmail.com> wrote:
> > Regarding the "return on error" behavior, that is the implementation
> > proposed by Ali, I've just adopted it. Perhaps, Ali could explain his
> > choice of a singleton object over a boolean variable. To me, it seems
> that
> > a boolean parameter would work just as well.

> Actually the error_return parameter is the value to return on errors.
> I added a similar parameter to local_command() mainly for implementing
> local_function().  But then to retain the old behavior, I needed
> to somehow tell local_command() to re-raise an exception instead of
> returning a value.  I could have added a new boolean parameter like
> reraise_exceptions, which, when False, forced the value of the new
> error_return parameter to be returned.  This would have required adding
> two new parameters to local_command(), one of which was dependent
> on the other; i.e. error_return would have been meaningful only if
> reraise_exceptions was False.

> I decided to merge the arguments: when exceptions are caught, the value
> passed as error_return should be returned, unless it is log_errors (maybe
> reraise_errors is a better name).  I added the log_errors singleton
> because I couldn't tell if any other value (like None) is meant to
> be returned on errors or is meant to request re-raising exceptions.
> I thought this is the common practice in such cases, but maybe I'm among
> the few who used to use this technique (or hack, probably).

> I suggest either adding comments for this new parameter and the new
> global variable or using the double parameter approach.  Unless, of
> course, someone has a cleaner solution.

> Thanks,
> Ali

> Anton Beloglazov <anton.belogla...@gmail.com> wrote:
> > Thanks for the explanation! In my opinion, the two parameter approach is
> > easier to understand since it's more explicit and doesn't require any
> > special values.

> That's OK with me and please update your patch.

> Thanks,
> Ali

> Here are the patches (only decorators.py has been updated: I've added
> a raise_exceptions argument):

> For decorators.py:

> --- decorators-backup.py 2012-08-30 11:27:46.690981338 +1000
> +++ decorators.py 2012-09-01 09:18:43.820460019 +1000
> @@ -47,13 +47,15 @@
>                      exceptions.ModuleSyntaxError,
>                      exceptions.BadIdentifierError)

> -def _exception_handler(func):
> +def _exception_handler(func, raise_exceptions, error_return):
>      def newfunc(*args, **kwds):
>          try:
>              return func(*args, **kwds)
>          except exceptions.RopeError, e:
>              short = None
>              if isinstance(e, input_exceptions):
> +                if not raise_exceptions:
> +                    return error_return
>                  short = _exception_message(e)
>              logger(str(traceback.format_exc()), short)
>      newfunc.__name__ = func.__name__
> @@ -72,10 +74,12 @@
>          return func
>      return decorator

> -
> -def local_command(key=None, prefix=False, shortcut=None, name=None):
> +def local_command(key=None, prefix=False, shortcut=None,
> +                  name=None, raise_exceptions=True,
> +                  error_return=None):
>      def decorator(func, name=name):
> -        func = _exception_handler(func)
> +        func = _exception_handler(func, raise_exceptions,
>  +                                  error_return)
>          func.kind = 'local'
>          func.prefix = prefix
>          func.local_key = key
> @@ -86,10 +90,15 @@
>          return func
>      return decorator

> +def local_function(error_return=None):
> +       return local_command(raise_exceptions=False,
> +                            error_return=error_return)

> -def global_command(key=None, prefix=False):
> +def global_command(key=None, prefix=False, raise_exceptions=True,
> +                   error_return=None):
>      def decorator(func):
> -        func = _exception_handler(func)
> +        func = _exception_handler(func, raise_exceptions,
> +                                  error_return)
>          func.kind = 'global'
>          func.prefix = prefix
>          func.global_key = key

> For interface.py

> --- interface-backup.py 2012-07-17 10:24:30.611629650 +1000
> +++ interface.py 2012-08-29 10:42:22.736438024 +1000
> @@ -157,7 +157,7 @@
>      def pop_mark(self):
>          self.env.pop_mark()

> -    @decorators.local_command()
> +    @decorators.local_function()
>      def definition_location(self):
>          definition = self._base_definition_location()
>          if definition:
> @@ -182,7 +182,7 @@
>          self._check_project()
>          self._base_show_doc(prefix,
> self._base_get_doc(codeassist.get_doc))

> -    @decorators.local_command()
> +    @decorators.local_function()
>      def get_calltip(self):
>          self._check_project()
>          def _get_doc(project, text, offset, *args, **kwds):
> @@ -203,7 +203,7 @@
>          else:
>              self.env.message('No docs available!')

> -    @decorators.local_command()
> +    @decorators.local_function()
>      def get_doc(self):
>          self._check_project()
>          return self._base_get_doc(codeassist.get_doc)
> @@ -275,11 +275,11 @@
>      def auto_import(self):
>          _CodeAssist(self, self.env).auto_import()

> -    @decorators.local_command()
> +    @decorators.local_function([])
>      def completions(self):
>          return _CodeAssist(self, self.env).completions()

> -    @decorators.local_command()
> +    @decorators.local_function([])
>      def extended_completions(self):
>          return _CodeAssist(self, self.env).extended_completions()

> Thanks,
> Anton

> On Fri, Aug 31, 2012 at 7:57 PM, Ali Gholami Rudi <aligr...@gmail.com>wrote:

>> Hi Anton,

>> Anton Beloglazov <anton.belogla...@gmail.com> wrote:
>> > Thanks for the explanation! In my opinion, the two parameter approach is
>> > easier to understand since it's more explicit and doesn't require any
>> > special values.

>> That's OK with me and please update your patch.

>> Thanks,
>> Ali

> Best regards,
> Anton

> On Sat, Sep 1, 2012 at 9:24 AM, Anton Beloglazov <
> anton.belogla...@gmail.com> wrote:

>> Hi Ali and Anton,

>> Here are the patches (only decorators.py has been updated: I've added
>> a raise_exceptions argument):

>> For decorators.py:

>> --- decorators-backup.py 2012-08-30 11:27:46.690981338 +1000
>> +++ decorators.py 2012-09-01 09:18:43.820460019 +1000
>> @@ -47,13 +47,15 @@
>>                      exceptions.ModuleSyntaxError,
>>                      exceptions.BadIdentifierError)

>> -def _exception_handler(func):
>> +def _exception_handler(func, raise_exceptions, error_return):
>>      def newfunc(*args, **kwds):
>>          try:
>>              return func(*args, **kwds)
>>          except exceptions.RopeError, e:
>>              short = None
>>              if isinstance(e, input_exceptions):
>> +                if not raise_exceptions:
>> +                    return error_return
>>                  short = _exception_message(e)
>>              logger(str(traceback.format_exc()), short)
>>      newfunc.__name__ = func.__name__
>> @@ -72,10 +74,12 @@
>>          return func
>>      return decorator

>> -
>> -def local_command(key=None, prefix=False, shortcut=None, name=None):
>> +def local_command(key=None, prefix=False, shortcut=None,
>> +                  name=None, raise_exceptions=True,
>> +                  error_return=None):
>>      def decorator(func, name=name):
>> -        func = _exception_handler(func)
>> +        func = _exception_handler(func, raise_exceptions,
>>  +                                  error_return)
>>          func.kind = 'local'
>>          func.prefix = prefix
>>          func.local_key = key
>> @@ -86,10 +90,15 @@
>>          return func
>>      return decorator

>> +def local_function(error_return=None):
>> +       return local_command(raise_exceptions=False,
>> +                            error_return=error_return)

>> -def global_command(key=None, prefix=False):
>> +def global_command(key=None, prefix=False, raise_exceptions=True,
>> +                   error_return=None):
>>      def decorator(func):
>> -        func = _exception_handler(func)
>> +        func = _exception_handler(func, raise_exceptions,
>> +                                  error_return)
>>          func.kind = 'global'
>>          func.prefix = prefix
>>          func.global_key = key

>> For interface.py

>> --- interface-backup.py 2012-07-17 10:24:30.611629650 +1000
>> +++ interface.py 2012-08-29 10:42:22.736438024 +1000
>> @@ -157,7 +157,7 @@
>>      def pop_mark(self):
>>          self.env.pop_mark()

>> -    @decorators.local_command()
>> +    @decorators.local_function()
>>      def definition_location(self):
>>          definition = self._base_definition_location()
>>          if definition:
>> @@ -182,7 +182,7 @@
>>          self._check_project()
>>          self._base_show_doc(prefix,
>> self._base_get_doc(codeassist.get_doc))

>> -    @decorators.local_command()
>> +    @decorators.local_function()
>>      def get_calltip(self):
>>          self._check_project()
>>          def _get_doc(project, text, offset, *args, **kwds):
>> @@ -203,7 +203,7 @@
>>          else:
>>              self.env.message('No docs available!')

>> -    @decorators.local_command()
>> +    @decorators.local_function()
>>      def get_doc(self):
>>          self._check_project()
>>          return self._base_get_doc(codeassist.get_doc)
>> @@ -275,11 +275,11 @@
>>      def auto_import(self):
>>          _CodeAssist(self, self.env).auto_import()

>> -    @decorators.local_command()
>> +    @decorators.local_function([])
>>      def completions(self):
>>          return _CodeAssist(self, self.env).completions()

>> -    @decorators.local_command()
>> +    @decorators.local_function([])
>>      def extended_completions(self):
>>          return _CodeAssist(self, self.env).extended_completions()

>> Thanks,
>> Anton

>> On Fri, Aug 31, 2012 at 7:57 PM, Ali Gholami Rudi <aligr...@gmail.com>wrote:

>>> Hi Anton,

>>> Anton Beloglazov <anton.belogla...@gmail.com> wrote:
>>> > Thanks for the explanation! In my opinion, the two parameter approach
>>> is
>>> > easier to understand since it's more explicit and doesn't require any
>>> > special values.

>>> That's OK with me and please update your patch.

>>> Thanks,
>>> Ali

> Is there any problem with accepting the patches?

> Thanks,
> Anton

> On Sat, Sep 1, 2012 at 9:25 AM, Anton Beloglazov
> <anton.belogla...@gmail.com> wrote:

>> A side note: I'll be away for the next two weeks. If there are any issues,
>> I'll only be able to look into them when I come back.

>> Best regards,
>> Anton

>> On Sat, Sep 1, 2012 at 9:24 AM, Anton Beloglazov
>> <anton.belogla...@gmail.com> wrote:

>>> Hi Ali and Anton,

>>> Here are the patches (only decorators.py has been updated: I've added a
>>> raise_exceptions argument):

>>> For decorators.py:

>>> --- decorators-backup.py 2012-08-30 11:27:46.690981338 +1000
>>> +++ decorators.py 2012-09-01 09:18:43.820460019 +1000
>>> @@ -47,13 +47,15 @@
>>>                      exceptions.ModuleSyntaxError,
>>>                      exceptions.BadIdentifierError)

>>> -def _exception_handler(func):
>>> +def _exception_handler(func, raise_exceptions, error_return):
>>>      def newfunc(*args, **kwds):
>>>          try:
>>>              return func(*args, **kwds)
>>>          except exceptions.RopeError, e:
>>>              short = None
>>>              if isinstance(e, input_exceptions):
>>> +                if not raise_exceptions:
>>> +                    return error_return
>>>                  short = _exception_message(e)
>>>              logger(str(traceback.format_exc()), short)
>>>      newfunc.__name__ = func.__name__
>>> @@ -72,10 +74,12 @@
>>>          return func
>>>      return decorator

>>> -
>>> -def local_command(key=None, prefix=False, shortcut=None, name=None):
>>> +def local_command(key=None, prefix=False, shortcut=None,
>>> +                  name=None, raise_exceptions=True,
>>> +                  error_return=None):
>>>      def decorator(func, name=name):
>>> -        func = _exception_handler(func)
>>> +        func = _exception_handler(func, raise_exceptions,
>>> +                                  error_return)
>>>          func.kind = 'local'
>>>          func.prefix = prefix
>>>          func.local_key = key
>>> @@ -86,10 +90,15 @@
>>>          return func
>>>      return decorator

>>> +def local_function(error_return=None):
>>> +       return local_command(raise_exceptions=False,
>>> +                            error_return=error_return)

>>> -def global_command(key=None, prefix=False):
>>> +def global_command(key=None, prefix=False, raise_exceptions=True,
>>> +                   error_return=None):
>>>      def decorator(func):
>>> -        func = _exception_handler(func)
>>> +        func = _exception_handler(func, raise_exceptions,
>>> +                                  error_return)
>>>          func.kind = 'global'
>>>          func.prefix = prefix
>>>          func.global_key = key

>>> For interface.py

>>> --- interface-backup.py 2012-07-17 10:24:30.611629650 +1000
>>> +++ interface.py 2012-08-29 10:42:22.736438024 +1000
>>> @@ -157,7 +157,7 @@
>>>      def pop_mark(self):
>>>          self.env.pop_mark()

>>> -    @decorators.local_command()
>>> +    @decorators.local_function()
>>>      def definition_location(self):
>>>          definition = self._base_definition_location()
>>>          if definition:
>>> @@ -182,7 +182,7 @@
>>>          self._check_project()
>>>          self._base_show_doc(prefix,
>>> self._base_get_doc(codeassist.get_doc))

>>> -    @decorators.local_command()
>>> +    @decorators.local_function()
>>>      def get_calltip(self):
>>>          self._check_project()
>>>          def _get_doc(project, text, offset, *args, **kwds):
>>> @@ -203,7 +203,7 @@
>>>          else:
>>>              self.env.message('No docs available!')

>>> -    @decorators.local_command()
>>> +    @decorators.local_function()
>>>      def get_doc(self):
>>>          self._check_project()
>>>          return self._base_get_doc(codeassist.get_doc)
>>> @@ -275,11 +275,11 @@
>>>      def auto_import(self):
>>>          _CodeAssist(self, self.env).auto_import()

>>> -    @decorators.local_command()
>>> +    @decorators.local_function([])
>>>      def completions(self):
>>>          return _CodeAssist(self, self.env).completions()

>>> -    @decorators.local_command()
>>> +    @decorators.local_function([])
>>>      def extended_completions(self):
>>>          return _CodeAssist(self, self.env).extended_completions()

>>> Thanks,
>>> Anton

>>> On Fri, Aug 31, 2012 at 7:57 PM, Ali Gholami Rudi <aligr...@gmail.com>
>>> wrote:

>>>> Hi Anton,

>>>> Anton Beloglazov <anton.belogla...@gmail.com> wrote:
>>>> > Thanks for the explanation! In my opinion, the two parameter approach
>>>> > is
>>>> > easier to understand since it's more explicit and doesn't require any
>>>> > special values.

>>>> That's OK with me and please update your patch.

>>>> Thanks,
>>>> Ali

> I'm sorry for the delay. I'm very short on free time these days, but
> I'll definitely take care of the patches until the middle of next
> week. Thanks!

> --
> Anton

> 2012/9/13 Anton Beloglazov <anton.belogla...@gmail.com>:
>> Hi Ali and Anton,

>> Is there any problem with accepting the patches?

>> Thanks,
>> Anton

>> On Sat, Sep 1, 2012 at 9:25 AM, Anton Beloglazov
>> <anton.belogla...@gmail.com> wrote:

>>> A side note: I'll be away for the next two weeks. If there are any issues,
>>> I'll only be able to look into them when I come back.

>>> Best regards,
>>> Anton

>>> On Sat, Sep 1, 2012 at 9:24 AM, Anton Beloglazov
>>> <anton.belogla...@gmail.com> wrote:

>>>> Hi Ali and Anton,

>>>> Here are the patches (only decorators.py has been updated: I've added a
>>>> raise_exceptions argument):

>>>> For decorators.py:

>>>> --- decorators-backup.py 2012-08-30 11:27:46.690981338 +1000
>>>> +++ decorators.py 2012-09-01 09:18:43.820460019 +1000
>>>> @@ -47,13 +47,15 @@
>>>>                      exceptions.ModuleSyntaxError,
>>>>                      exceptions.BadIdentifierError)

>>>> -def _exception_handler(func):
>>>> +def _exception_handler(func, raise_exceptions, error_return):
>>>>      def newfunc(*args, **kwds):
>>>>          try:
>>>>              return func(*args, **kwds)
>>>>          except exceptions.RopeError, e:
>>>>              short = None
>>>>              if isinstance(e, input_exceptions):
>>>> +                if not raise_exceptions:
>>>> +                    return error_return
>>>>                  short = _exception_message(e)
>>>>              logger(str(traceback.format_exc()), short)
>>>>      newfunc.__name__ = func.__name__
>>>> @@ -72,10 +74,12 @@
>>>>          return func
>>>>      return decorator

>>>> -
>>>> -def local_command(key=None, prefix=False, shortcut=None, name=None):
>>>> +def local_command(key=None, prefix=False, shortcut=None,
>>>> +                  name=None, raise_exceptions=True,
>>>> +                  error_return=None):
>>>>      def decorator(func, name=name):
>>>> -        func = _exception_handler(func)
>>>> +        func = _exception_handler(func, raise_exceptions,
>>>> +                                  error_return)
>>>>          func.kind = 'local'
>>>>          func.prefix = prefix
>>>>          func.local_key = key
>>>> @@ -86,10 +90,15 @@
>>>>          return func
>>>>      return decorator

>>>> +def local_function(error_return=None):
>>>> +       return local_command(raise_exceptions=False,
>>>> +                            error_return=error_return)

>>>> -def global_command(key=None, prefix=False):
>>>> +def global_command(key=None, prefix=False, raise_exceptions=True,
>>>> +                   error_return=None):
>>>>      def decorator(func):
>>>> -        func = _exception_handler(func)
>>>> +        func = _exception_handler(func, raise_exceptions,
>>>> +                                  error_return)
>>>>          func.kind = 'global'
>>>>          func.prefix = prefix
>>>>          func.global_key = key

>>>> For interface.py

>>>> --- interface-backup.py 2012-07-17 10:24:30.611629650 +1000
>>>> +++ interface.py 2012-08-29 10:42:22.736438024 +1000
>>>> @@ -157,7 +157,7 @@
>>>>      def pop_mark(self):
>>>>          self.env.pop_mark()

>>>> -    @decorators.local_command()
>>>> +    @decorators.local_function()
>>>>      def definition_location(self):
>>>>          definition = self._base_definition_location()
>>>>          if definition:
>>>> @@ -182,7 +182,7 @@
>>>>          self._check_project()
>>>>          self._base_show_doc(prefix,
>>>> self._base_get_doc(codeassist.get_doc))

>>>> -    @decorators.local_command()
>>>> +    @decorators.local_function()
>>>>      def get_calltip(self):
>>>>          self._check_project()
>>>>          def _get_doc(project, text, offset, *args, **kwds):
>>>> @@ -203,7 +203,7 @@
>>>>          else:
>>>>              self.env.message('No docs available!')

>>>> -    @decorators.local_command()
>>>> +    @decorators.local_function()
>>>>      def get_doc(self):
>>>>          self._check_project()
>>>>          return self._base_get_doc(codeassist.get_doc)
>>>> @@ -275,11 +275,11 @@
>>>>      def auto_import(self):
>>>>          _CodeAssist(self, self.env).auto_import()

>>>> -    @decorators.local_command()
>>>> +    @decorators.local_function([])
>>>>      def completions(self):
>>>>          return _CodeAssist(self, self.env).completions()

>>>> -    @decorators.local_command()
>>>> +    @decorators.local_function([])
>>>>      def extended_completions(self):
>>>>          return _CodeAssist(self, self.env).extended_completions()

>>>> Thanks,
>>>> Anton

>>>> On Fri, Aug 31, 2012 at 7:57 PM, Ali Gholami Rudi <aligr...@gmail.com>
>>>> wrote:

>>>>> Hi Anton,

>>>>> Anton Beloglazov <anton.belogla...@gmail.com> wrote:
>>>>> > Thanks for the explanation! In my opinion, the two parameter approach
>>>>> > is
>>>>> > easier to understand since it's more explicit and doesn't require any
>>>>> > special values.

>>>>> That's OK with me and please update your patch.

>>>>> Thanks,
>>>>> Ali

> Thanks, Anton and Ali!

> --
> Anton

> 2012/9/13  <an...@angri.ru>:
> > Hi Anton, hi Ali,

> > I'm sorry for the delay. I'm very short on free time these days, but
> > I'll definitely take care of the patches until the middle of next
> > week. Thanks!

> > --
> > Anton

> > 2012/9/13 Anton Beloglazov <anton.belogla...@gmail.com>:
> >> Hi Ali and Anton,

> >> Is there any problem with accepting the patches?

> >> Thanks,
> >> Anton

> >> On Sat, Sep 1, 2012 at 9:25 AM, Anton Beloglazov
> >> <anton.belogla...@gmail.com> wrote:

> >>> A side note: I'll be away for the next two weeks. If there are any
> issues,
> >>> I'll only be able to look into them when I come back.

> >>> Best regards,
> >>> Anton

> >>> On Sat, Sep 1, 2012 at 9:24 AM, Anton Beloglazov
> >>> <anton.belogla...@gmail.com> wrote:

> >>>> Hi Ali and Anton,

> >>>> Here are the patches (only decorators.py has been updated: I've added
> a
> >>>> raise_exceptions argument):

> >>>> For decorators.py:

> >>>> --- decorators-backup.py 2012-08-30 11:27:46.690981338 +1000
> >>>> +++ decorators.py 2012-09-01 09:18:43.820460019 +1000
> >>>> @@ -47,13 +47,15 @@
> >>>>                      exceptions.ModuleSyntaxError,
> >>>>                      exceptions.BadIdentifierError)

> >>>> -def _exception_handler(func):
> >>>> +def _exception_handler(func, raise_exceptions, error_return):
> >>>>      def newfunc(*args, **kwds):
> >>>>          try:
> >>>>              return func(*args, **kwds)
> >>>>          except exceptions.RopeError, e:
> >>>>              short = None
> >>>>              if isinstance(e, input_exceptions):
> >>>> +                if not raise_exceptions:
> >>>> +                    return error_return
> >>>>                  short = _exception_message(e)
> >>>>              logger(str(traceback.format_exc()), short)
> >>>>      newfunc.__name__ = func.__name__
> >>>> @@ -72,10 +74,12 @@
> >>>>          return func
> >>>>      return decorator

> >>>> -
> >>>> -def local_command(key=None, prefix=False, shortcut=None, name=None):
> >>>> +def local_command(key=None, prefix=False, shortcut=None,
> >>>> +                  name=None, raise_exceptions=True,
> >>>> +                  error_return=None):
> >>>>      def decorator(func, name=name):
> >>>> -        func = _exception_handler(func)
> >>>> +        func = _exception_handler(func, raise_exceptions,
> >>>> +                                  error_return)
> >>>>          func.kind = 'local'
> >>>>          func.prefix = prefix
> >>>>          func.local_key = key
> >>>> @@ -86,10 +90,15 @@
> >>>>          return func
> >>>>      return decorator

> >>>> +def local_function(error_return=None):
> >>>> +       return local_command(raise_exceptions=False,
> >>>> +                            error_return=error_return)

> >>>> -def global_command(key=None, prefix=False):
> >>>> +def global_command(key=None, prefix=False, raise_exceptions=True,
> >>>> +                   error_return=None):
> >>>>      def decorator(func):
> >>>> -        func = _exception_handler(func)
> >>>> +        func = _exception_handler(func, raise_exceptions,
> >>>> +                                  error_return)
> >>>>          func.kind = 'global'
> >>>>          func.prefix = prefix
> >>>>          func.global_key = key

> >>>> For interface.py

> >>>> --- interface-backup.py 2012-07-17 10:24:30.611629650 +1000
> >>>> +++ interface.py 2012-08-29 10:42:22.736438024 +1000
> >>>> @@ -157,7 +157,7 @@
> >>>>      def pop_mark(self):
> >>>>          self.env.pop_mark()

> >>>> -    @decorators.local_command()
> >>>> +    @decorators.local_function()
> >>>>      def definition_location(self):
> >>>>          definition = self._base_definition_location()
> >>>>          if definition:
> >>>> @@ -182,7 +182,7 @@
> >>>>          self._check_project()
> >>>>          self._base_show_doc(prefix,
> >>>> self._base_get_doc(codeassist.get_doc))

> >>>> -    @decorators.local_command()
> >>>> +    @decorators.local_function()
> >>>>      def get_calltip(self):
> >>>>          self._check_project()
> >>>>          def _get_doc(project, text, offset, *args, **kwds):
> >>>> @@ -203,7 +203,7 @@
> >>>>          else:
> >>>>              self.env.message('No docs available!')

> >>>> -    @decorators.local_command()
> >>>> +    @decorators.local_function()
> >>>>      def get_doc(self):
> >>>>          self._check_project()
> >>>>          return self._base_get_doc(codeassist.get_doc)
> >>>> @@ -275,11 +275,11 @@
> >>>>      def auto_import(self):
> >>>>          _CodeAssist(self, self.env).auto_import()

> >>>> -    @decorators.local_command()
> >>>> +    @decorators.local_function([])
> >>>>      def completions(self):
> >>>>          return _CodeAssist(self, self.env).completions()

> >>>> -    @decorators.local_command()
> >>>> +    @decorators.local_function([])
> >>>>      def extended_completions(self):
> >>>>          return _CodeAssist(self, self.env).extended_completions()

> >>>> Thanks,
> >>>> Anton

> >>>> On Fri, Aug 31, 2012 at 7:57 PM, Ali Gholami Rudi <aligr...@gmail.com

> >>>> wrote:

> >>>>> Hi Anton,

> >>>>> Anton Beloglazov <anton.belogla...@gmail.com> wrote:
> >>>>> > Thanks for the explanation! In my opinion, the two parameter
> approach
> >>>>> > is
> >>>>> > easier to understand since it's more explicit and doesn't require
> any
> >>>>> > special values.

> >>>>> That's OK with me and please update your patch.

> >>>>> Thanks,
> >>>>> Ali