Hello,

I want to use something like rope-get-calltip which returns the calltip
as a string so that I can hook it up in eldoc to automatically show
calltips.

It would be nice if it also returns the index of the current arg. For
example, if foo has signature foo(x, y, z), when I am typing foo(1, |)
where | indicates where cursor is, the index is 1 (counting from 0).

Could this be implemented upstream? Thanks.

Leo

Sure. Write a patch and I'm sure agr will take it.

--
  Jasper

Hi,

Another solution is to write a lisp function that uses
rope-get-calltip; this doesn't require changing ropemode.
But I'm not sure which of them are cleaner.  Please
report any success.

"Jasper St. Pierre" <jstpie...@mecheye.net> wrote:

Certainly, any patch is welcome.  By the way, Anton maintains
ropemacs too, so he takes the patches.

Thanks,
Ali

On 2012-02-06 00:02 +0800, Ali Gholami Rudi wrote:

I was using one:

(defun rope-get-calltip ()
  (let ((message-log-max nil))
    (rope-show-calltip ropemacs-separate-doc-buffer)
    (let ((msg (current-message)))
      (message nil)
      (unless (equal msg "No docs available!")
        msg))))

But this feels backwards. I think if rope-get-calltip is defined then
rope-show-calltip will be straightforward to define in elisp. Just like
rope-show-doc can be easily re-implemented in elisp using rope-get-doc.

BTW, rope-show-calltip fails on the following example code:

os.path.join\
  ('a', 'b')

Leo

Hi,

And it works with eldoc?

Changing ropemacs is a bit harder as you may need to change
ropemode and possibly ropevim (but the latter is very unlikely).
But I may be wrong.  Do you have a patch?

You can change show_calltip() in ropemode/interface.py for
handling that; just skip any whitespace and newlines
following backslashes.  But personally I think this is not
PEP8 compatible and safe to ignore.

Thanks,
Ali

On 2012-02-06 02:31 +0800, Ali Gholami Rudi wrote:

Yes, by setting eldoc-documentation-function locally in python mode.

The following patch works for me. Comments?

diff -r 9bf46eecc9b7 ropemode/interface.py
--- a/ropemode/interface.py     Mon Feb 06 12:39:36 2012 +0100
+++ b/ropemode/interface.py     Tue Feb 07 15:43:02 2012 +0800
@@ -182,8 +182,8 @@
         self._check_project()
         self._base_show_doc(prefix, codeassist.get_doc)

-    @decorators.local_command('a c', 'P')
-    def show_calltip(self, prefix):
+    @decorators.local_command()
+    def get_calltip(self):
         self._check_project()
         def _get_doc(project, text, offset, *args, **kwds):
             try:
@@ -191,7 +191,11 @@
             except ValueError:
                 return None
             return codeassist.get_calltip(project, text, offset, *args, **kwds)
-        self._base_show_doc(prefix, _get_doc)
+        return self._base_get_doc(_get_doc)
+
+    @decorators.local_command('a c', 'P')
+    def show_calltip(self, prefix):
+        self._base_show_doc(prefix, lambda *args, **kwds: self.get_calltip())

     def _base_show_doc(self, prefix, get_doc):
         docs = self._base_get_doc(get_doc)

Leo

Hi Leo,

This is OK.  But I suggest applying this (untested) clean up before
your patch (_base_show_doc() no longer calls _base_get_doc()):

--- a/ropemode/interface.py     2012-02-07 20:29:20.181617836 +0330
+++ b/ropemode/interface.py     2012-02-07 20:30:26.111711102 +0330
@@ -180,7 +180,7 @@
     @decorators.local_command('a d', 'P', 'C-c d')
     def show_doc(self, prefix):
         self._check_project()
-        self._base_show_doc(prefix, codeassist.get_doc)
+        self._base_show_doc(prefix, self._base_get_doc(codeassist.get_doc))

     @decorators.local_command('a c', 'P')
     def show_calltip(self, prefix):
@@ -191,10 +191,9 @@
             except ValueError:
                 return None
             return codeassist.get_calltip(project, text, offset, *args, **kwds)
-        self._base_show_doc(prefix, _get_doc)
+        self._base_show_doc(prefix, self._base_get_doc(_get_doc))

-    def _base_show_doc(self, prefix, get_doc):
-        docs = self._base_get_doc(get_doc)
+    def _base_show_doc(self, prefix, docs):
         if docs:
             self.env.show_doc(docs, prefix)
         else:

Then the lambda in your patch would be unnecessary.

Thanks,
Ali

On 2012-02-08 01:02 +0800, Ali Gholami Rudi wrote:

Indeed. Thanks for the cleanup. I have re-worked the patch to be on top
of yours. How to get these two patches installed upstream? Thanks. - Leo

diff -r 5174afc04c11 ropemode/interface.py
--- a/ropemode/interface.py     Wed Feb 08 10:37:57 2012 +0800
+++ b/ropemode/interface.py     Wed Feb 08 10:49:41 2012 +0800
@@ -182,8 +182,8 @@
         self._check_project()
         self._base_show_doc(prefix, self._base_get_doc(codeassist.get_doc))

-    @decorators.local_command('a c', 'P')
-    def show_calltip(self, prefix):
+    @decorators.local_command()
+    def get_calltip(self):
         self._check_project()
         def _get_doc(project, text, offset, *args, **kwds):
             try:
@@ -191,7 +191,11 @@
             except ValueError:
                 return None
             return codeassist.get_calltip(project, text, offset, *args, **kwds)
-        self._base_show_doc(prefix, self._base_get_doc(_get_doc))
+        return self._base_get_doc(_get_doc)
+
+    @decorators.local_command('a c', 'P')
+    def show_calltip(self, prefix):
+        self._base_show_doc(prefix, self.get_calltip())

     def _base_show_doc(self, prefix, docs):
         if docs:

On 2012-02-08 10:53 +0800, Leo wrote:

I forgot to mention that I have tested these patches and they worked.

Leo

Hi Leo,

ACK.

Please resubmit both patches and CC Anton.

Thanks,
Ali

On 2012-02-08 11:22 +0800, Ali Gholami Rudi wrote:

Hello Anton,

Could you kindly install the following patch sets? Thanks a lot.

Leo

patch.diff 2K Download

On 2012-02-08 12:20 +0800, Leo wrote:

Ping?

Leo

Hi Leo,

could you please send a pull request with the changes in question?

Thank you.

--
Anton

2012/2/11 Leo <sdl....@gmail.com>:

On 2012-02-12 06:49 +0800, general wrote:

Done.  - Leo

Pulled. Thanks.

--
Anton

2012/2/12 Leo <sdl....@gmail.com>: