Pull request failed to build?

[Tim Baverstock]

Hey guys,

I made a pull request a while ago - https://github.com/pivotal/robolectric/pull/334 - but it failed to build because the build couldn't find the Android SDK.

Is there some particular way I should be building from my command-line to mimic the build process, or is the website's build failure due to something else? I don't recall changing the build script.

Thanks

Tim

[Tyler Schultz]

If your tests are passing locally, and you've not made any configuration changes to robolectric, then it will probably be ok. We typically run the tests locally before merging a request. 

I assume you're referring to a failed Travis build that is was kicked off as part of submitting your pull request. Travis is mainly used as a canary, and for feedback to developers submitting pull requests. Unfortunately, the Travis build system does not get the attention it deserves. The jenkins build system running on http://ci.robolectric.org is the real 'ci of record'. It has credentials and configurations that push passing snapshot builds to maven central. The ability to push snapshots from Travis was not possible (the last time I investigated), because of the need for private keys and credentials.

--Tyler