OPML subscriptions import and garbage collection

7 views
Skip to first unread message

Les Orchard

unread,
Nov 2, 2011, 10:30:00 AM11/2/11
to river2
One other speed bump I hit: When I used the "Import OPML..." menu item,
all the feeds got added - and then immediately garbage collected.

I poked my nose in and saw that river2Suite.opmlImport had this:

river2Suite.subscribeFeed (url)

But, it looks like feeds need to be associated with a user (or app) or
else they get cleaned up. So, I changed it to this line:

river2Suite.utilities.addFeedForAllUsers(url)

That fixed my problem, though I could imagine a multi-user installation
might not want it fixed that way.

--
m...@lmorchard.com
http://decafbad.com
{web,mad,computer} scientist

Dave Winer

unread,
Nov 2, 2011, 10:33:01 AM11/2/11
to river2...@googlegroups.com
Thanks Les. Garbage collection is a relatively new feature, and I
missed that when I put it in.

I'm going to keep saying this for a while -- it's GREAT to have you
back in the loop. Every developer needs people watching him or her
every step of the way. It's been hard for me to make progress without
this kind of back and forth.

I'll try to have a fix for this later today. I'm working on a new
feature in the world outline software right now.

Dave

Les Orchard

unread,
Nov 2, 2011, 10:45:49 AM11/2/11
to river2...@googlegroups.com
On 11/2/11 10:33 AM, Dave Winer wrote:
> Thanks Les. Garbage collection is a relatively new feature, and I
> missed that when I put it in.
>
> I'm going to keep saying this for a while -- it's GREAT to have you
> back in the loop. Every developer needs people watching him or her
> every step of the way. It's been hard for me to make progress without
> this kind of back and forth.

Happy to help, and I can hop over to another mailing list for further
finds like this if the code babble is out of scope for river2-users

My brain's been pretty full of work projects and miscellanea for most of
this year, but I'm hoping soon to spend more quality time with things
like the rssCloud and friends

> I'll try to have a fix for this later today. I'm working on a new
> feature in the world outline software right now.

Cool! World outline will have to be one of the next things I start
playing with :)

Dave Winer

unread,
Nov 2, 2011, 1:03:21 PM11/2/11
to river2...@googlegroups.com
Les, here are the notes on the fix, which is released.

http://worknotes.scripting.com/november2011/11211ByDw/river2BugImportingOpml

There's a "how to test" section in the notes. It would be helpful if a
few people could try this on their River2 installations with a very
small OPML file (so you don't end up with a bunch of stuff you don't
want).

Dave

On Wed, Nov 2, 2011 at 10:30 AM, Les Orchard <l.m.o...@pobox.com> wrote:

Les Orchard

unread,
Nov 2, 2011, 2:53:46 PM11/2/11
to river2...@googlegroups.com
On 11/2/11 1:03 PM, Dave Winer wrote:
> Les, here are the notes on the fix, which is released.
>
> http://worknotes.scripting.com/november2011/11211ByDw/river2BugImportingOpml
>
> There's a "how to test" section in the notes. It would be helpful if a
> few people could try this on their River2 installations with a very
> small OPML file (so you don't end up with a bunch of stuff you don't
> want).

Worked for me, only subbed for the "admin" user. But, that makes sense
since "admin" is most likely who's clicking at the menu bar.

Dave Winer

unread,
Nov 2, 2011, 3:09:41 PM11/2/11
to river2...@googlegroups.com
By convention, in a single-user installation, which is most of them, the single user is named admin.

That assumption is made throughout the software.

Les Orchard

unread,
Nov 2, 2011, 3:15:53 PM11/2/11
to river2...@googlegroups.com
On 11/2/11 3:09 PM, Dave Winer wrote:
> By convention, in a single-user installation, which is most of them, the
> single user is named admin.
>
> That assumption is made throughout the software.

Makes sense to me!

Reply all
Reply to author
Forward
0 new messages