isElement and isNode in v2

[CjK]

Hey there,

#isElement() and #isNode() are giving me strange results in RJS 2.0
(tested in FF 3.6.x):

var e = $('comments_list');
isElement(e); => [yields nothing]
isElement(document.createElement('div')); => "DIV" - shouldn't it be
'true'?)
isElement("div"); => [yields nothing] - expected 'false'
isNode(e); => [yields nothing]
isNode(document.createElement('div')); => 1 - expected 'true'
isNode(e._); => 1 - expected 'true'
...

Either my Firebug console is broken or #isElement() doesn't behave as
it used to.

Claus

[CjK]

Just looked at the implementation of #isElement() and something like
this would make it work:

--- before ---
[...]
return value && value.tagName; => returns tagname for elements

--- after ---
[...]
return value && !!value.tagName; => returns true for elements

But then a "negated not" might not read intuitive for everyone ;)

Claus

[Nikolay Nemshilov]

Hi Claus,

the meaning of `isElement` is the same as it was in RightJS 1, it checks if the given value is a raw dom-element and as far as I remember it wasn't changed since then.

But you have your point, I think it should be kinda like that

return value && value.nodeType === 1;

> --
> You received this message because you are subscribed to the Google Groups "RightJS" group.
> To post to this group, send email to rig...@googlegroups.com.
> To unsubscribe from this group, send email to rightjs+u...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/rightjs?hl=en.
>

--
Nikolay V. Nemshilov
The Web-Developer