Problems trying to fix the not-passed tests on Rhino commons

[Lorenzo Melato]

Dear all,

as announced here:
http://groups.google.it/group/rhino-tools-dev/browse_thread/thread/dade9447c50010c6?hl=it

with the help of Paul Cowan, project leader of the Horn project, I
have published a new repo for the Rhino Commons project here:
http://github.com/lorenzomelato/rhino-commons

now Rhino commons build against rhino.dsl trunk and nhibernate
2.1.1ga, but...

some unit test don't pass, so i'm trying to fix it.

Ayende in the "How to build" note say that:

"The tests Rhino Tools assumes that you have a SQL Server database
installed and with CREATE DATABASE privileges for the current user.
You should also ensure that the database server has a database named
'test' and a database named 'test2', with CREATE TABLE and DROP TABLE
privileges for the current user."

Running the tests, I noticed that also the "Commons_Test", "TestDb1"
and "TestDb2" databases are needed by some tests.
At a first look I suppose that these databases were created by the
code (CREATE DATABASE privileges are needed for the current user) but
I haven't found where and when.

The class UnitOfWorkTestContextDbStrategy has a method SetupDatabase
(ISession currentSession) that call the CreateDatabaseMedia() and than
the CreateDatabaseSchema(currentSession):

public virtual void SetupDatabase(ISession currentSession)
{
CreateDatabaseMedia();
CreateDatabaseSchema(currentSession);
}

but if the SetupDatabase method needs the currentSession parameter...
in order to create the currentSession the database must already
exists!

So, how can I fix the tests? The databases needs to be created first?

@Ayende: please can you help us?

Lorenzo Melato
http://blogs.ynnova.it/lorenzomelato

[Lorenzo Melato]

Just pushed a patch to the rhino commons repo:

http://github.com/lorenzomelato/rhino-commons

Now all tests passes against nhibernate 2.1.1ga.
See the commit log for the patch details.

Lorenzo Melato
http://blogs.ynnova.it/lorenzomelato