Review Board with Git work flow

[raj]

Hi,

I use git internally and want to use RB to review code changes before
submitting to our repo.

We have a central repository which holds the main code. Developers
pull from this repo and work with their local checkouts. After hacking
their internal repos, when the code is in a consistent shape, they
push to the repo. Ideally our work flow should be

1. Developers pull from main repo
2. Developers hack, make multiple commits in local repo
3. Developers push code
4. Push uploads the patches to RB.
5. Reviewers review the diff and suggest changes etc code goes back
and forth between dev and RB
6. Reviewers approve the code
7. RB pushes the code to main repo, with proper commit messages etc

Is such a work flow possible in RB? If not approximations would also
be most welcome.

raj

[Christian Hammond]

Hi.

First, Review Board doesn't ever submit code. We leave that up to the developers, as there's just too many issues with Review Board handling this across different repository types.

Second, the rest of that should work fine, with the exception that post-review (the tool you'd want to use for uploading review requests/diffs) doesn't fully support Git yet. It probably wouldn't be too hard to add this support, but someone needs to do it (and we're both kinda busy right now).

Once Git support is in post-review, it should just be a matter of having some checkout on the Review Board server that you keep up to date with a cron job and then run post-review (with the --branch parameter for sub-topic branches) whenever you want to put up a new change.

Christian

--
Christian Hammond - chi...@chipx86.com
VMware, Inc.

[Dan Savilonis]

I spent far too much time searching the discussions and source before
I realized that git was actually supported, but not in post-review. Is
there any reason that post-review doesn't support (non svn) git other
than that you haven't gotten to it yet? I'd like to add support. I was
able to upload a git diff manually to a reviewboard server, though I'm
not sure exactly what git diff format it is looking for.

Dan
.

On Oct 16, 6:32 pm, "Christian Hammond" <chip...@chipx86.com> wrote:
> Hi.
>
> First, Review Board doesn't ever submit code. We leave that up to the
> developers, as there's just too many issues with Review Board handling this
> across different repository types.
>
> Second, the rest of that should work fine, with the exception that
> post-review (the tool you'd want to use for uploading review requests/diffs)
> doesn't fully support Git yet. It probably wouldn't be too hard to add this
> support, but someone needs to do it (and we're both kinda busy right now).
>
> Once Git support is in post-review, it should just be a matter of having
> some checkout on the Review Board server that you keep up to date with a
> cron job and then run post-review (with the --branch parameter for sub-topic
> branches) whenever you want to put up a new change.
>
> Christian
>
> --

> Christian Hammond - chip...@chipx86.com
> VMware, Inc.

[Christian Hammond]

No reason except we haven't gotten to it yet. We've been quite busy with the VMware Workstation 6.5 release for the past year or so and trying to juggle Review Board fixes and the 1.0 release in the meantime. It's been hard to get to a lot of things.

Christian


--
Christian Hammond - chi...@chipx86.com
VMware, Inc.