ReviewBoard not displaying content of diff file

[cogo]

I have just started trying out reviewboard and I have some issues with
some diffs not beeing displayed when I click "View diff" in the review
request. When i download the diff I can see the content:

Index: //trunk/library/extras/global-post-commit-hook.php
===================================================================
--- //trunk/library/extras/global-post-commit-hook.php (revision 1901)
+++ //trunk/library/extras/global-post-commit-hook.php (revision 1902)
@@ -64,4 +64,4 @@
$revision));
}

-// Test
\ No newline at end of file
+// Test



Why does this not get displayed?

[sergius]

To show diff reviewboard connects to actual repository and download
context lines. Make sure that repository you've setup in your
reviewboard instance are accessible from reviewboard domain. And what
paths are right.

[Chris Clark]

This looks like a white-space-only-diff issue. There is a config option
that _may_ help here (and there is a bug too), see :

<http://code.google.com/p/reviewboard/issues/detail?id=1780>http://code.google.com/p/reviewboard/issues/detail?id=1780
http://code.google.com/p/reviewboard/issues/detail?id=1511

Chris

[cogo]

It shows all other diffs, so that is not the problem.

[cogo]

I'm using 1.5RC1 and in the settings part of the admin area I have
enabled:

Show syntax highlighting
Show trailing whitespace

and in the input field for "Show all whitespace for" I have tried *.*,
*.php and several other combinations. Perhaps these changes are
effective post-creation of a review? I'm not sure about what these
values was when the actual review was created.

[Christian Hammond]

It's effective at diff generation time, but if you've already viewed the diff, it's been cached. You would have to restart memcached to see the effects, and likely clear your browser cache as well.

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

>
> Chris

--
Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to reviewboard...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en

[cogo]

That did not seem to help. I restarted memcache, and logged in using a
browser that had not been logged in to our reviewboard installation
before. The review does not list any files under "Files changed:" when
I click Show Diff, and when I download the diff, the contents are
there.

On Oct 14, 10:31 pm, Christian Hammond <chip...@chipx86.com> wrote:
> It's effective at diff generation time, but if you've already viewed the
> diff, it's been cached. You would have to restart memcached to see the
> effects, and likely clear your browser cache as well.
>
> Christian
>
> --

> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com

> >http://code.google.com/p/reviewboard/issues/detail?id=1780http://code...

>
> > > Chris
>
> > --
> > Want to help the Review Board project? Donate today at
> >http://www.reviewboard.org/donate/

> > Happy user? Let us know athttp://www.reviewboard.org/users/

> > -~----------~----~----~----~------~----~------~--~---
> > To unsubscribe from this group, send email to

> > reviewboard...@googlegroups.com<reviewboard%2Bunsu...@googlegroups.com>

[Jan Koprowski]

I had the same problems but this was long time ago. I have some
suspects. I don't know which versioning system You use but e.g.
ClearCase had broken "\No new end of line" searching because
workaround wasn't properly implemented.

1) Try patch Your Python following this issue: http://bugs.python.org/issue2142
2) If this doesn't work try turn FireBug and check is this is not a
bug http://code.google.com/p/reviewboard/issues/detail?id=1672

> Happy user? Let us know at http://www.reviewboard.org/users/

> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to reviewboard...@googlegroups.com

> For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en

--
><> Jan Koprowski