Unable to view diff

[Chris Baron]

Hi review board users, I just upgraded from version 1.0.1 to 1.6.3.
Most things are going smoothly. However, when I try to view a diff :

Traceback (most recent call last):
File "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3-
py2.7.egg/reviewboard/diffviewer/views.py", line 151, in view_diff
interdiffset, highlighting, True)
File "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3-
py2.7.egg/reviewboard/diffviewer/diffutils.py", line 1071, in
get_diff_files
large_data=True)
File "/usr/local/lib/python2.7/site-packages/Djblets-0.6.15-
py2.7.egg/djblets/util/misc.py", line 157, in cache_memoize
data = lookup_callable()
File "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3-
py2.7.egg/reviewboard/diffviewer/diffutils.py", line 1070, in <lambda>
enable_syntax_highlighting)),
File "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3-
py2.7.egg/reviewboard/diffviewer/diffutils.py", line 551, in
get_chunks
old = get_original_file(filediff)
File "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3-
py2.7.egg/reviewboard/diffviewer/diffutils.py", line 364, in
get_original_file
large_data=True)[0]
File "/usr/local/lib/python2.7/site-packages/Djblets-0.6.15-
py2.7.egg/djblets/util/misc.py", line 157, in cache_memoize
data = lookup_callable()
File "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3-
py2.7.egg/reviewboard/diffviewer/diffutils.py", line 363, in <lambda>
data = cache_memoize(key, lambda: [fetch_file(file, revision)],
File "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3-
py2.7.egg/reviewboard/diffviewer/diffutils.py", line 342, in
fetch_file
data = tool.get_file(file, revision)
File "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3-
py2.7.egg/reviewboard/scmtools/perforce.py", line 306, in get_file
return self.client.get_file(path, revision)
File "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3-
py2.7.egg/reviewboard/scmtools/perforce.py", line 224, in get_file
return self._run_worker(lambda: self._get_file(path, revision))
File "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3-
py2.7.egg/reviewboard/scmtools/perforce.py", line 154, in _run_worker
result = worker()
File "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3-
py2.7.egg/reviewboard/scmtools/perforce.py", line 224, in <lambda>
return self._run_worker(lambda: self._get_file(path, revision))
File "/usr/local/lib/python2.7/site-packages/ReviewBoard-1.6.3-
py2.7.egg/reviewboard/scmtools/perforce.py", line 201, in _get_file
stderr=subprocess.PIPE)
File "/usr/lib64/python2.7/subprocess.py", line 672, in __init__
errread, errwrite)
File "/usr/lib64/python2.7/subprocess.py", line 1201, in
_execute_child
raise child_exception
OSError: [Errno 13] Permission denied


Any suggestions? Thanks in advance.

[Christian Hammond]

Hi Chris,

On first glance, it looks like the p4 binary isn't executable. Can you check the permissions of this?

I've seen similar issues crop up, so I'll add some better logging and error handling for hopefully the next patch release to help diagnose these issues.

Christian

> --
> Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to reviewboard...@googlegroups.com
> For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en

[Chris Baron]

You were right - I needed to give proper permissions to the review
board user for the p4 binary.

Again, I appreciate your help. It has made the installation,
migration much easier.

On Mar 9, 2:19 pm, Christian Hammond <chip...@gmail.com> wrote:
> Hi Chris,
>
> On first glance, it looks like the p4 binary isn't executable. Can you check the permissions of this?
>
> I've seen similar issues crop up, so I'll add some better logging and error handling for hopefully the next patch release to help diagnose these issues.
>
> Christian
>

> > Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/