Web Images Videos Maps News Shopping Gmail more »
Recently Visited Groups | Help | Sign in
Google Groups Home
Code Review Process
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
jon  
View profile  
 More options Jul 2 2008, 10:17 pm
From: jon <latch...@gmail.com>
Date: Wed, 2 Jul 2008 19:17:28 -0700 (PDT)
Local: Wed, Jul 2 2008 10:17 pm
Subject: Code Review Process
Hi all,

After fully installing and reviewing reviewboard today, I realized
that this product is kind of the opposite of what I'm looking for
because my development model is a bit different than the one that this
product supports. Instead of creating a patch and waiting for my co-
workers to review it, I'd rather see a system where reviews are done
on already committed code and there is a workflow around that system
instead. To keep this email short, I just wrote a blog posting
detailing my issues:

http://lookfirst.com/2008/07/code-reviews.html

I'd love to hear the experts here comment on my views.

thanks,

jon


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Christian Hammond  
View profile  
 More options Jul 3 2008, 12:07 am
From: "Christian Hammond" <chip...@chipx86.com>
Date: Wed, 2 Jul 2008 21:07:37 -0700
Local: Thurs, Jul 3 2008 12:07 am
Subject: Re: Code Review Process

Hi Jon.

Love the title of your blog :)

Though we don't advertise it nearly as much, Review Board can post review
requests of already committed code. The web UI doesn't have support for this
(yet) but the command line post-review tool does. You can specify a revision
range to put up for review and people can review that.

In time, probably after extensions support goes in, I envision a small
repository browser that lets you easily put committed code up for review.
But in the meantime, post-review is your best option. If you check the wiki,
there's some documentation on using post-review in this way.

Christian

--
Christian Hammond - chip...@chipx86.com
VMware, Inc.


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2009 Google