some post-review requests succeed, some fail -- same repository & user

44 views
Skip to first unread message

Robert Cabacungan

unread,
Jun 3, 2010, 12:18:29 PM6/3/10
to reviewboard
Hi, everyone,

For the same review board instance, same repository, same user, I get
post-review errors for some review requests, but not for others. (I
have included debug output below.)

It seems like everything goes well until the actual uploading of the
diff. Then it fails with a "Network connection closed unexpectedly"
error message.

But as far as I can tell, there's no difference in the two requests
besides the contents of the diff itself. The diffs themselves are
accurate.

The errors are consistent: Creating a review request from certain
revisions always fails, but from other revisions always succeeds.

I have dumped and examined the http requests with tcpdump, and I
couldn't see any difference in the requests besides the actual content
of the diffs. I didn't notice any special content in the failing
request (i.e., no special characters or binary data).

Hoping somebody can help!

Sincerely,

Rob

=====

Here's debug output for a failure:

/usr/local/bin/post-review --server=http://XXXX.com/ --summary="[cmp]
Checkin #33714 by robin" --submit-as=robin --username=Otto --
password=yyyy --repository-url=svn+ssh://ro...@YYYY.com/cmp --revision-
range=33713:33714 --description-file=description.txt --debug
>>> svn info svn+ssh://ro...@YYYY.com/cmp
>>> diff --version
>>> repository info: Path: svn+ssh://ro...@YYYY.com/cmp, Base path: /, Supports changesets: False
>>> svn diff --diff-cmd=diff svn+ssh://ro...@YYYY.com/cmp/@33713 svn+ssh://ro...@YYYY.com/cmp/@33714
>>> Looking for 'XXXX.com /' cookie in /home/robc/.post-review-cookies.txt
>>> Loaded valid cookie -- no login required
>>> HTTP GETting /api/json/repositories/
>>> HTTP GETting /api/json/repositories/1/info/
>>> Got API Error 210 (HTTP code 200): There was an error fetching extended information for this repository.
>>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error fetching extended information for this repository.', u'code': 210}}
>>> HTTP GETting /api/json/repositories/2/info/
>>> Got API Error 210 (HTTP code 200): There was an error fetching extended information for this repository.
>>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error fetching extended information for this repository.', u'code': 210}}
>>> HTTP GETting /api/json/repositories/3/info/
>>> Got API Error 210 (HTTP code 200): There was an error fetching extended information for this repository.
>>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error fetching extended information for this repository.', u'code': 210}}
>>> HTTP GETting /api/json/repositories/4/info/
>>> Got API Error 210 (HTTP code 200): There was an error fetching extended information for this repository.
>>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error fetching extended information for this repository.', u'code': 210}}
>>> Attempting to create review request on svn+ssh://ro...@YYYY.com/cmp for None
>>> Submitting the review request as robin
>>> HTTP POSTing to http://XXXX.com/api/json/reviewrequests/new/: {'repository_path': 'svn+ssh://ro...@YYYY.com/cmp', 'submit_as': 'robin'}
>>> Review request created
>>> Attempting to set field 'summary' to '[cmp] Checkin #33714 by robin' for review request '47'
>>> HTTP POSTing to http://XXXX.com/api/json/reviewrequests/47/draft/set/: {'summary': '[cmp] Checkin #33714 by robin'}
>>> Attempting to set field 'description' to 'r33714 | robin | 2010-06-03 07:37:10 -0400 (Thu, 03 Jun 2010) | 1 line
Changed paths:
M /channels/aaaa/aaaa-main/trunk/solr/aaaa-schema.xml

Added a field to store major groups **REVIEW**
' for review request '47'
>>> HTTP POSTing to http://XXXX.com/api/json/reviewrequests/47/draft/set/: {'description': 'r33714 | robin | 2010-06-03 07:37:10 -0400 (Thu, 03 Jun 2010) | 1 line\nChanged paths:\n M /channels/aaaa/aaaa-main/trunk/solr/aaaa-schema.xml\n\nAdded a field to store major groups **REVIEW**\n'}
>>> Uploading diff, size: 985
>>> HTTP POSTing to http://XXXX.com/api/json/reviewrequests/47/diff/new/: {'basedir': '/'}
>>> Got API Error 105 (HTTP code 200): One or more fields had errors
>>> Error data: {u'fields': {u'path': [u'Network connection closed unexpectedly']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}}

Error uploading diff

The generated diff file was empty. This usually means no files were
modified in this change.

Try running with --output-diff and --debug for more information.

Your review request still exists, but the diff is not attached.


=============

And here's a success:

/usr/local/bin/post-review --server=http://XXXX.com/ --summary="[cmp]
Checkin #33715 by robin" --submit-as=robin --username=Otto --
password=yyyy --repository-url=svn+ssh://ro...@YYYY.com/cmp --revision-
range=33714:33715 --description-file=description.txt --debug
>>> svn info svn+ssh://ro...@YYYY.com/cmp
>>> diff --version
>>> repository info: Path: svn+ssh://ro...@YYYY.com/cmp, Base path: /, Supports changesets: False
>>> svn diff --diff-cmd=diff svn+ssh://ro...@YYYY.com/cmp/@33714 svn+ssh://ro...@YYYY.com/cmp/@33715
>>> Looking for 'XXXX.com /' cookie in /home/robc/.post-review-cookies.txt
>>> Loaded valid cookie -- no login required
>>> HTTP GETting /api/json/repositories/
>>> HTTP GETting /api/json/repositories/1/info/
>>> Got API Error 210 (HTTP code 200): There was an error fetching extended information for this repository.
>>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error fetching extended information for this repository.', u'code': 210}}
>>> HTTP GETting /api/json/repositories/2/info/
>>> Got API Error 210 (HTTP code 200): There was an error fetching extended information for this repository.
>>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error fetching extended information for this repository.', u'code': 210}}
>>> HTTP GETting /api/json/repositories/3/info/
>>> Got API Error 210 (HTTP code 200): There was an error fetching extended information for this repository.
>>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error fetching extended information for this repository.', u'code': 210}}
>>> HTTP GETting /api/json/repositories/4/info/
>>> Got API Error 210 (HTTP code 200): There was an error fetching extended information for this repository.
>>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error fetching extended information for this repository.', u'code': 210}}
>>> Attempting to create review request on svn+ssh://ro...@YYYY.com/cmp for None
>>> Submitting the review request as robin
>>> HTTP POSTing to http://XXXX.com/api/json/reviewrequests/new/: {'repository_path': 'svn+ssh://ro...@YYYY.com/cmp', 'submit_as': 'robin'}
>>> Review request created
>>> Attempting to set field 'summary' to '[cmp] Checkin #33715 by robin' for review request '48'
>>> HTTP POSTing to http://XXXX.com/api/json/reviewrequests/48/draft/set/: {'summary': '[cmp] Checkin #33715 by robin'}
>>> Attempting to set field 'description' to 'r33715 | robin | 2010-06-03 07:43:21 -0400 (Thu, 03 Jun 2010) | 3 lines
Changed paths:
A /channels/aaaa/aaaa-main/trunk/talend/makefile_listing
M /channels/aaaa/aaaa-main/trunk/talend/solrhotel.zip

* SOLRHOTEL: add major groups into SOLR*
makefile_listing: make file for build
**REVIEW**
' for review request '48'
>>> HTTP POSTing to http://XXXX.com/api/json/reviewrequests/48/draft/set/: {'description': 'r33715 | robin | 2010-06-03 07:43:21 -0400 (Thu, 03 Jun 2010) | 3 lines\nChanged paths:\n A /channels/aaaa/aaaa-main/trunk/talend/makefile_listing\n M /channels/aaaa/aaaa-main/trunk/talend/solrhotel.zip\n\n* SOLRHOTEL: add major groups into SOLR* \nmakefile_listing: make file for build\n**REVIEW**\n'}
>>> Uploading diff, size: 915
>>> HTTP POSTing to http://XXXX.com/api/json/reviewrequests/48/diff/new/: {'basedir': '/'}
Review request #48 posted.

http://XXXX.com/r/48

Christian Hammond

unread,
Jun 3, 2010, 1:50:42 PM6/3/10
to revie...@googlegroups.com
Sounds like something is failing when Review Board talks to the repository. This is a Subversion repository? What happens if you do a `svn cat` on that file with that revision from the Review Board server?

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



--
Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to reviewboard...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en

Robert Cabacungan

unread,
Jun 3, 2010, 6:25:28 PM6/3/10
to reviewboard
I get:

svn: Network connection closed unexpectedly

Thank you! I kept debugging the post-review side of it, but it looks
like something's wrong from the server's perspective.

Thanks a lot!

Rob

On Jun 3, 1:50 pm, Christian Hammond <chip...@chipx86.com> wrote:
> Sounds like something is failing when Review Board talks to the repository.
> This is a Subversion repository? What happens if you do a `svn cat` on that
> file with that revision from the Review Board server?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Thu, Jun 3, 2010 at 9:18 AM, Robert Cabacungan <
>
>
>
> robert.cabacun...@gmail.com> wrote:
> > Hi, everyone,
>
> > For the same review board instance, same repository, same user, I get
> > post-review errors for some review requests, but not for others.  (I
> > have included debug output below.)
>
> > It seems like everything goes well until the actual uploading of the
> > diff.  Then it fails with a "Network connection closed unexpectedly"
> > error message.
>
> > But as far as I can tell, there's no difference in the two requests
> > besides the contents of the diff itself.  The diffs themselves are
> > accurate.
>
> > The errors are consistent:  Creating a review request from certain
> > revisions always fails, but from other revisions always succeeds.
>
> > I have dumped and examined the http requests with tcpdump, and I
> > couldn't see any difference in the requests besides the actual content
> > of the diffs.  I didn't notice any special content in the failing
> > request (i.e., no special characters or binary data).
>
> > Hoping somebody can help!
>
> > Sincerely,
>
> > Rob
>
> > =====
>
> > Here's debug output for a failure:
>
> > /usr/local/bin/post-review --server=http://XXXX.com/--summary="[cmp]
> > Checkin #33714 by robin" --submit-as=robin --username=Otto --
> > password=yyyy --repository-url=svn+ssh://r...@YYYY.com/cmp --revision-
> > range=33713:33714 --description-file=description.txt --debug
> > >>> svn info svn+ssh://r...@YYYY.com/cmp
> > >>> diff --version
> > >>> repository info: Path: svn+ssh://r...@YYYY.com/cmp, Base path: /,
> > Supports changesets: False
> > >>> svn diff --diff-cmd=diff svn+ssh://r...@YYYY.com/cmp/@33713
> > svn+ssh://r...@YYYY.com/cmp/@33714
> > >>> Looking for 'XXXX.com /' cookie in /home/robc/.post-review-cookies.txt
> > >>> Loaded valid cookie -- no login required
> > >>> HTTP GETting /api/json/repositories/
> > >>> HTTP GETting /api/json/repositories/1/info/
> > >>> Got API Error 210 (HTTP code 200): There was an error fetching extended
> > information for this repository.
> > >>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
> > fetching extended information for this repository.', u'code': 210}}
> > >>> HTTP GETting /api/json/repositories/2/info/
> > >>> Got API Error 210 (HTTP code 200): There was an error fetching extended
> > information for this repository.
> > >>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
> > fetching extended information for this repository.', u'code': 210}}
> > >>> HTTP GETting /api/json/repositories/3/info/
> > >>> Got API Error 210 (HTTP code 200): There was an error fetching extended
> > information for this repository.
> > >>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
> > fetching extended information for this repository.', u'code': 210}}
> > >>> HTTP GETting /api/json/repositories/4/info/
> > >>> Got API Error 210 (HTTP code 200): There was an error fetching extended
> > information for this repository.
> > >>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
> > fetching extended information for this repository.', u'code': 210}}
> > >>> Attempting to create review request on svn+ssh://r...@YYYY.com/cmp for
> > None
> > >>> Submitting the review request as robin
> > >>> HTTP POSTing tohttp://XXXX.com/api/json/reviewrequests/new/:
> > {'repository_path': 'svn+ssh://r...@YYYY.com/cmp', 'submit_as': 'robin'}
> > >>> Review request created
> > >>> Attempting to set field 'summary' to '[cmp] Checkin #33714 by robin'
> > for review request '47'
> > >>> HTTP POSTing tohttp://XXXX.com/api/json/reviewrequests/47/draft/set/:
> > {'summary': '[cmp] Checkin #33714 by robin'}
> > >>> Attempting to set field 'description' to 'r33714 | robin | 2010-06-03
> > 07:37:10 -0400 (Thu, 03 Jun 2010) | 1 line
> > Changed paths:
> >   M /channels/aaaa/aaaa-main/trunk/solr/aaaa-schema.xml
>
> > Added a field to store major groups **REVIEW**
> > ' for review request '47'
> > >>> HTTP POSTing tohttp://XXXX.com/api/json/reviewrequests/47/draft/set/:
> > {'description': 'r33714 | robin | 2010-06-03 07:37:10 -0400 (Thu, 03 Jun
> > 2010) | 1 line\nChanged paths:\n   M
> > /channels/aaaa/aaaa-main/trunk/solr/aaaa-schema.xml\n\nAdded a field to
> > store major groups **REVIEW**\n'}
> > >>> Uploading diff, size: 985
> > >>> HTTP POSTing tohttp://XXXX.com/api/json/reviewrequests/47/diff/new/:
> > {'basedir': '/'}
> > >>> Got API Error 105 (HTTP code 200): One or more fields had errors
> > >>> Error data: {u'fields': {u'path': [u'Network connection closed
> > unexpectedly']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
> > errors', u'code': 105}}
>
> > Error uploading diff
>
> > The generated diff file was empty. This usually means no files were
> > modified in this change.
>
> > Try running with --output-diff and --debug for more information.
>
> > Your review request still exists, but the diff is not attached.
>
> > =============
>
> > And here's a success:
>
> > /usr/local/bin/post-review --server=http://XXXX.com/--summary="[cmp]
> > Checkin #33715 by robin" --submit-as=robin --username=Otto --
> > password=yyyy --repository-url=svn+ssh://r...@YYYY.com/cmp --revision-
> > range=33714:33715 --description-file=description.txt --debug
> > >>> svn info svn+ssh://r...@YYYY.com/cmp
> > >>> diff --version
> > >>> repository info: Path: svn+ssh://r...@YYYY.com/cmp, Base path: /,
> > Supports changesets: False
> > >>> svn diff --diff-cmd=diff svn+ssh://r...@YYYY.com/cmp/@33714
> > svn+ssh://r...@YYYY.com/cmp/@33715
> > >>> Looking for 'XXXX.com /' cookie in /home/robc/.post-review-cookies.txt
> > >>> Loaded valid cookie -- no login required
> > >>> HTTP GETting /api/json/repositories/
> > >>> HTTP GETting /api/json/repositories/1/info/
> > >>> Got API Error 210 (HTTP code 200): There was an error fetching extended
> > information for this repository.
> > >>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
> > fetching extended information for this repository.', u'code': 210}}
> > >>> HTTP GETting /api/json/repositories/2/info/
> > >>> Got API Error 210 (HTTP code 200): There was an error fetching extended
> > information for this repository.
> > >>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
> > fetching extended information for this repository.', u'code': 210}}
> > >>> HTTP GETting /api/json/repositories/3/info/
> > >>> Got API Error 210 (HTTP code 200): There was an error fetching extended
> > information for this repository.
> > >>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
> > fetching extended information for this repository.', u'code': 210}}
> > >>> HTTP GETting /api/json/repositories/4/info/
> > >>> Got API Error 210 (HTTP code 200): There was an error fetching extended
> > information for this repository.
> > >>> Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
> > fetching extended information for this repository.', u'code': 210}}
> > >>> Attempting to create review request on svn+ssh://r...@YYYY.com/cmp for
> > None
> > >>> Submitting the review request as robin
> > >>> HTTP POSTing tohttp://XXXX.com/api/json/reviewrequests/new/:
> > {'repository_path': 'svn+ssh://r...@YYYY.com/cmp', 'submit_as': 'robin'}
> > >>> Review request created
> > >>> Attempting to set field 'summary' to '[cmp] Checkin #33715 by robin'
> > for review request '48'
> > >>> HTTP POSTing tohttp://XXXX.com/api/json/reviewrequests/48/draft/set/:
> > {'summary': '[cmp] Checkin #33715 by robin'}
> > >>> Attempting to set field 'description' to 'r33715 | robin | 2010-06-03
> > 07:43:21 -0400 (Thu, 03 Jun 2010) | 3 lines
> > Changed paths:
> >   A /channels/aaaa/aaaa-main/trunk/talend/makefile_listing
> >   M /channels/aaaa/aaaa-main/trunk/talend/solrhotel.zip
>
> > * SOLRHOTEL: add major groups into SOLR*
> > makefile_listing: make file for build
> > **REVIEW**
> > ' for review request '48'
> > >>> HTTP POSTing tohttp://XXXX.com/api/json/reviewrequests/48/draft/set/:
> > {'description': 'r33715 | robin | 2010-06-03 07:43:21 -0400 (Thu, 03 Jun
> > 2010) | 3 lines\nChanged paths:\n   A
> > /channels/aaaa/aaaa-main/trunk/talend/makefile_listing\n   M
> > /channels/aaaa/aaaa-main/trunk/talend/solrhotel.zip\n\n* SOLRHOTEL: add
> > major groups into SOLR* \nmakefile_listing: make file for
> > build\n**REVIEW**\n'}
> > >>> Uploading diff, size: 915
> > >>> HTTP POSTing tohttp://XXXX.com/api/json/reviewrequests/48/diff/new/:
> > {'basedir': '/'}
> > Review request #48 posted.
>
> >http://XXXX.com/r/48
>
> > --
> > Want to help the Review Board project? Donate today at
> >http://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~----------~----~----~----~------~----~------~--~---
> > To unsubscribe from this group, send email to
> > reviewboard...@googlegroups.com<reviewboard%2Bunsubscribe@googlegr oups.com>
Reply all
Reply to author
Forward
0 new messages