Bug publishing request with post-review

0 views
Skip to first unread message

Jonathan Ellis

unread,
Jan 21, 2008, 2:43:22 AM1/21/08
to reviewboard
With the --publish option, post-review hangs requesting r/id/publish.
This is caused by

return HttpResponseRedirect(review_request.get_absolute_url())

in the publish function in reviews/views.

I am not sure why post-review is unable to handle this. It is hanging
in recv in urllib2.urlopen(r).read() so I guess django just isn't
sending it the data. Currently I am working around this by kludging
the openerdirector to ignore http 302 codes.

-Jonathan

Christian Hammond

unread,
Jan 21, 2008, 4:42:45 AM1/21/08
to revie...@googlegroups.com
Yeah, we need a dedicated publish API function. We're re-using/abusing the publish URL for review requests. urllib2 doesn't seem to be handling the redirect associated with this very well. So the correct solution is taking the publish view logic and putting it into an API function and updating the script. If someone wants to submit a patch, I'll commit it. Otherwise, I'll try to get to it in the next few days if I have time.

Christian
--
Christian Hammond - chi...@chipx86.com
VMware, Inc.
Reply all
Reply to author
Forward
0 new messages