Review Request 3242: Multi user collaboration on review requests - Review Board Reviews

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion Review Request 3242: Multi user collaboration on review requests
Received-SPF: pass (google.com: domain of nore...@reviewboard.org designates 107.22.175.174 as permitted sender) client-ip=107.22.175.174;
Content-Type: multipart/alternative; boundary="===============1250105372=="
MIME-Version: 1.0
Subject: Re: Review Request 3242: Multi user collaboration on review requests
From: crystal....@gmail.com
To: "Review Board" <reviewboard-reviews@googlegroups.com>,
        "Mike Conley" <mike.d.con...@gmail.com>,
        "Christian Hammond" <chip...@chipx86.com>, crystal....@gmail.com
Date: Mon, 29 Oct 2012 00:44:41 -0000
Message-ID: <20121029004441.4577.55946@ip-10-60-82-95.ec2.internal>
Auto-Submitted: auto-generated
Sender: nore...@reviewboard.org
References: <20121007192815.7849.81...@ip-10-60-82-95.ec2.internal>
In-Reply-To: <20121007192815.7849.81...@ip-10-60-82-95.ec2.internal>
Reply-To: crystal....@gmail.com

--===============1250105372==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.reviewboard.org/r/3242/
-----------------------------------------------------------

(Updated Oct. 29, 2012, 12:44 a.m.)


Review request for Review Board.


Changes
-------

Fixed all the minor issues that were bought up during the last code review. Added a missing evolution file. More manual testing done.


Description
-------

This is what I have so far for the multi user collaboration on review requests. So far, what I have done is allow all reviewers (users in the target people and groups) to be allowed to change the review request. This would all the reviewers to all the normal changing review request functionalities. 

I'm not sure if we have decided who can be able to modify the review request. For now, I put them as all the reviewers.

Also, I've included the last_updated_by field to the review request model in order to display who has last modified the review request or published new review on the dashboard.


Diffs (updated)
-----

  reviewboard/attachments/forms.py 3bcfa1845bd64e68ab2819deda049b83d4728fad 
  reviewboard/attachments/tests.py e614c9dab275cc006702d0b30d39b024a4d5107e 
  reviewboard/changedescs/evolutions/__init__.py 40a5228649c29c224f65bf0e6703c429549a1dae 
  reviewboard/changedescs/evolutions/change_desc_user.py c876d9ccec81262d878deb3ace2ddc21ab3b0583 
  reviewboard/changedescs/models.py 0bbf0d5a8626eb06ed6a8c669ed3bb3afe82cbcd 
  reviewboard/reviews/datagrids.py 736d7ff1bb63d17412ee17c7adbe95853c29d584 
  reviewboard/reviews/evolutions/__init__.py 4a5dedd45af098a1524a6a46ad0d6d063fe27c92 
  reviewboard/reviews/evolutions/add_reviewrequest_owner.py 205ef88d8dfac5a30e48abc82fce9d10aebfe76d 
  reviewboard/reviews/forms.py bc32c002311a464091e8ec8e1092ad6e07d61573 
  reviewboard/reviews/managers.py 67434e7d557e453a1cb046c926eabd3d72c9d91d 
  reviewboard/reviews/models.py d8fa0e71ff75e398d586ed5085a5a4dd0fec448d 
  reviewboard/reviews/tests.py bddc522aa84ea6a8cb62fc829260a37019fb1c29 
  reviewboard/reviews/views.py 1025322abe236a03fc9a0c2d4221ae3363eff7dd 
  reviewboard/static/rb/js/datastore.js 331c1cde61ceb257c5e055430ced46b6704d05c9 
  reviewboard/static/rb/js/reviews.js 777248fd4ea5d8f244cf807803c0cd982b08ea96 
  reviewboard/templates/reviews/review_detail.html 95f7100ad65e16959ad28c09e5f0aac45adc0386 
  reviewboard/templates/reviews/review_flags.js 2e64e59c2b477e5baf59d7dd82a24557400477f5 
  reviewboard/templates/reviews/review_header.html e428f1866ba1b578fabaf72d193ade155c5aa08e 
  reviewboard/templates/reviews/review_request_actions_secondary.html 53a7d93d441e5efd59cb3e9a5cb99d7a7fe38ad9 
  reviewboard/templates/reviews/review_request_box.html 3aa104bc2a8c2ebae8102c1ad4fc05d576f1235e 
  reviewboard/templates/reviews/review_request_dlgs.html 69238071762b37ca01f2090e37b1d929e5a47dbc 
  reviewboard/webapi/resources.py 5cf15de29b650b2a947350819c30d134bdb3e5b5 
  reviewboard/webapi/tests.py d49d12e8fb7473acacf1804a81ed92482f5e2f77 

Diff: http://reviews.reviewboard.org/r/3242/diff/


Testing
-------

Manual testing. At first, I've ran the unit tests and had a bunch of errors and one failure. The errors are all expected due to the change of the ReviewRequestDraft.create() function and I need to look into that one failure. I think it's expected failure though.

As of diff 2, all the test failures/errors have been fixed.


Thanks,

CrystalLokKoo


--===============1250105372==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviews.reviewboard.org/r/3242/">http://reviews.reviewboard.org/r/3242/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviews.reviewboard.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Review Board.</div>
<div>By CrystalLokKoo.</div>


<p style="color: grey;"><i>Updated Oct. 29, 2012, 12:44 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed all the minor issues that were bought up during the last code review. Added a missing evolution file. More manual testing done.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is what I have so far for the multi user collaboration on review requests. So far, what I have done is allow all reviewers (users in the target people and groups) to be allowed to change the review request. This would all the reviewers to all the normal changing review request functionalities. 

I&#39;m not sure if we have decided who can be able to modify the review request. For now, I put them as all the reviewers.

Also, I&#39;ve included the last_updated_by field to the review request model in order to display who has last modified the review request or published new review on the dashboard.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing. At first, I&#39;ve ran the unit tests and had a bunch of errors and one failure. The errors are all expected due to the change of the ReviewRequestDraft.create() function and I need to look into that one failure. I think it&#39;s expected failure though.

As of diff 2, all the test failures/errors have been fixed.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>reviewboard/attachments/forms.py <span style="color: grey">(3bcfa1845bd64e68ab2819deda049b83d4728fad)</span></li>

 <li>reviewboard/attachments/tests.py <span style="color: grey">(e614c9dab275cc006702d0b30d39b024a4d5107e)</span></li>

 <li>reviewboard/changedescs/evolutions/__init__.py <span style="color: grey">(40a5228649c29c224f65bf0e6703c429549a1dae)</span></li>

 <li>reviewboard/changedescs/evolutions/change_desc_user.py <span style="color: grey">(c876d9ccec81262d878deb3ace2ddc21ab3b0583)</span></li>

 <li>reviewboard/changedescs/models.py <span style="color: grey">(0bbf0d5a8626eb06ed6a8c669ed3bb3afe82cbcd)</span></li>

 <li>reviewboard/reviews/datagrids.py <span style="color: grey">(736d7ff1bb63d17412ee17c7adbe95853c29d584)</span></li>

 <li>reviewboard/reviews/evolutions/__init__.py <span style="color: grey">(4a5dedd45af098a1524a6a46ad0d6d063fe27c92)</span></li>

 <li>reviewboard/reviews/evolutions/add_reviewrequest_owner.py <span style="color: grey">(205ef88d8dfac5a30e48abc82fce9d10aebfe76d)</span></li>

 <li>reviewboard/reviews/forms.py <span style="color: grey">(bc32c002311a464091e8ec8e1092ad6e07d61573)</span></li>

 <li>reviewboard/reviews/managers.py <span style="color: grey">(67434e7d557e453a1cb046c926eabd3d72c9d91d)</span></li>

 <li>reviewboard/reviews/models.py <span style="color: grey">(d8fa0e71ff75e398d586ed5085a5a4dd0fec448d)</span></li>

 <li>reviewboard/reviews/tests.py <span style="color: grey">(bddc522aa84ea6a8cb62fc829260a37019fb1c29)</span></li>

 <li>reviewboard/reviews/views.py <span style="color: grey">(1025322abe236a03fc9a0c2d4221ae3363eff7dd)</span></li>

 <li>reviewboard/static/rb/js/datastore.js <span style="color: grey">(331c1cde61ceb257c5e055430ced46b6704d05c9)</span></li>

 <li>reviewboard/static/rb/js/reviews.js <span style="color: grey">(777248fd4ea5d8f244cf807803c0cd982b08ea96)</span></li>

 <li>reviewboard/templates/reviews/review_detail.html <span style="color: grey">(95f7100ad65e16959ad28c09e5f0aac45adc0386)</span></li>

 <li>reviewboard/templates/reviews/review_flags.js <span style="color: grey">(2e64e59c2b477e5baf59d7dd82a24557400477f5)</span></li>

 <li>reviewboard/templates/reviews/review_header.html <span style="color: grey">(e428f1866ba1b578fabaf72d193ade155c5aa08e)</span></li>

 <li>reviewboard/templates/reviews/review_request_actions_secondary.html <span style="color: grey">(53a7d93d441e5efd59cb3e9a5cb99d7a7fe38ad9)</span></li>

 <li>reviewboard/templates/reviews/review_request_box.html <span style="color: grey">(3aa104bc2a8c2ebae8102c1ad4fc05d576f1235e)</span></li>

 <li>reviewboard/templates/reviews/review_request_dlgs.html <span style="color: grey">(69238071762b37ca01f2090e37b1d929e5a47dbc)</span></li>

 <li>reviewboard/webapi/resources.py <span style="color: grey">(5cf15de29b650b2a947350819c30d134bdb3e5b5)</span></li>

 <li>reviewboard/webapi/tests.py <span style="color: grey">(d49d12e8fb7473acacf1804a81ed92482f5e2f77)</span></li>

</ul>

<p><a href="http://reviews.reviewboard.org/r/3242/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============1250105372==--
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
