Review Request 2828: Toggle for "Open an Issue" - Review Board Reviews

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion Review Request 2828: Toggle for "Open an Issue"
Received-SPF: pass (google.com: domain of nore...@reviewboard.org designates 107.22.175.174 as permitted sender) client-ip=107.22.175.174;
Content-Type: multipart/alternative; boundary="===============1157612531=="
MIME-Version: 1.0
Subject: Re: Review Request 2828: Toggle for "Open an Issue"
From: "Wilson Yeung" <wilsonyeun...@gmail.com>
To: "Mike Conley" <mike.d.con...@gmail.com>,
        "Yazan Medanat" <meda...@gmail.com>,
        "Wilson Yeung" <wilsonyeun...@gmail.com>,
        "Anthony Mok" <am...@uwaterloo.ca>,
        "Review Board" <reviewboard-reviews@googlegroups.com>,
        "Christian Hammond" <chip...@chipx86.com>
Date: Tue, 03 Apr 2012 05:54:16 -0000
Message-ID: <20120403055416.30934.45...@ip-10-98-67-135.ec2.internal>
Auto-Submitted: auto-generated
Sender: "Wilson Yeung" <nore...@reviewboard.org>
References: <20120226034208.17038.93...@ip-10-98-67-135.ec2.internal>
In-Reply-To: <20120226034208.17038.93...@ip-10-98-67-135.ec2.internal>
Reply-To: "Wilson Yeung" <wilsonyeun...@gmail.com>

--===============1157612531==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.reviewboard.org/r/2828/
-----------------------------------------------------------

(Updated April 3, 2012, 5:54 a.m.)


Review request for Review Board.


Changes
-------

Fixed bug that didn't reflect changes after a comment dialogue had been saved previously.


Description
-------

Problem: When opening a comment box, there is always a default to "Open an issue" ie that box is checked.

Solution: Create an additional property that is configurable by the user to swap that default on or off.
1. Evolution to add property: open_an_issue
2. Modified all relevant files to allow it to be stored in the database.
3. Made open_an_issue reflect in the comment dialogue when changed in account settings.


This addresses bug 2282.
    http://code.google.com/p/reviewboard/issues/detail?id=2282


Diffs (updated)
-----

  reviewboard/accounts/evolutions/__init__.py 60a6769b600eaf9646e101f61291a495bbebf283 
  reviewboard/accounts/evolutions/open_an_issue.py PRE-CREATION 
  reviewboard/accounts/forms.py ca97667dedd042f09c8b3d160b532bdc1b9fe34e 
  reviewboard/accounts/models.py dccc7f458b53deaaff342b23a9f2fae4ed40e80c 
  reviewboard/accounts/views.py ec58326c70f921d3eca9e8188cbc1732fb81e257 
  reviewboard/static/rb/js/reviews.js 25bfc1e48551abdde6da7d304dfd0e36d16c53f6 
  reviewboard/templates/accounts/prefs.html f6a59255923cae61c07dd778a4f0ae6e24fa72fe 
  reviewboard/templates/reviews/comments_dlg.html d90d80cd2d8d3c16a1f96578a11562595e5dfba9 
  reviewboard/templates/reviews/reviewable_base.html a8800268f6c4e6f8c01075f11095d0bf322f971f 

Diff: http://reviews.reviewboard.org/r/2828/diff/


Testing
-------

The "My account" page saves the preference just fine. 
You can toggle it on and off, and it's reflected on the comment dialogue.
Tested from off to on, on to off.


Thanks,

Wilson Yeung


--===============1157612531==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviews.reviewboard.org/r/2828/">http://reviews.reviewboard.org/r/2828/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviews.reviewboard.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Review Board.</div>
<div>By Wilson Yeung.</div>


<p style="color: grey;"><i>Updated April 3, 2012, 5:54 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed bug that didn&#39;t reflect changes after a comment dialogue had been saved previously.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Problem: When opening a comment box, there is always a default to &quot;Open an issue&quot; ie that box is checked.

Solution: Create an additional property that is configurable by the user to swap that default on or off.
1. Evolution to add property: open_an_issue
2. Modified all relevant files to allow it to be stored in the database.
3. Made open_an_issue reflect in the comment dialogue when changed in account settings.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The &quot;My account&quot; page saves the preference just fine. 
You can toggle it on and off, and it&#39;s reflected on the comment dialogue.
Tested from off to on, on to off.</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://code.google.com/p/reviewboard/issues/detail?id=2282">2282</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>reviewboard/accounts/evolutions/__init__.py <span style="color: grey">(60a6769b600eaf9646e101f61291a495bbebf283)</span></li>

 <li>reviewboard/accounts/evolutions/open_an_issue.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>reviewboard/accounts/forms.py <span style="color: grey">(ca97667dedd042f09c8b3d160b532bdc1b9fe34e)</span></li>

 <li>reviewboard/accounts/models.py <span style="color: grey">(dccc7f458b53deaaff342b23a9f2fae4ed40e80c)</span></li>

 <li>reviewboard/accounts/views.py <span style="color: grey">(ec58326c70f921d3eca9e8188cbc1732fb81e257)</span></li>

 <li>reviewboard/static/rb/js/reviews.js <span style="color: grey">(25bfc1e48551abdde6da7d304dfd0e36d16c53f6)</span></li>

 <li>reviewboard/templates/accounts/prefs.html <span style="color: grey">(f6a59255923cae61c07dd778a4f0ae6e24fa72fe)</span></li>

 <li>reviewboard/templates/reviews/comments_dlg.html <span style="color: grey">(d90d80cd2d8d3c16a1f96578a11562595e5dfba9)</span></li>

 <li>reviewboard/templates/reviews/reviewable_base.html <span style="color: grey">(a8800268f6c4e6f8c01075f11095d0bf322f971f)</span></li>

</ul>

<p><a href="http://reviews.reviewboard.org/r/2828/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============1157612531==--
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
