Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Review Board Reviews
Home
About this group
Join this group
Message from discussion Review Request 3440: RB Patch
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
John Sintal  
View profile  
 More options Oct 23 2012, 8:44 pm
From: "John Sintal" <john.sin...@gmail.com>
Date: Wed, 24 Oct 2012 00:44:24 -0000
Local: Tues, Oct 23 2012 8:44 pm
Subject: Re: Review Request 3440: RB Patch
Print | View thread | Show original | Report this message | Find messages by this author

> On Oct. 23, 2012, 6:40 p.m., Steven MacLeod wrote:
> > Looking over the plan you've laid out in your comments, no issues come to mind.

> > This diff is including your changes for 'rb diff', which I assume means you've based your branch for 'rb patch' off of your other branch. To fix this, you should run post-review with '--parent=<name_of_rb_diff_branch>' when you post your next diff.

Do I still include the --tracking-branch=api ?

- John

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.reviewboard.org/r/3440/#review4419
-----------------------------------------------------------

On Oct. 22, 2012, 3:58 a.m., John Sintal wrote:

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.reviewboard.org/r/3440/
> -----------------------------------------------------------

> (Updated Oct. 22, 2012, 3:58 a.m.)

> Review request for RBTools.

> Description
> -------

> [WIP]

> RB Patch will download a patch based off a specific review request ID and apply the patch on the local machine.

> Diffs
> -----

>   rbtools/commands/diff.py PRE-CREATION
>   rbtools/clients/__init__.py 7985973ec0286d8a656246282717d60d0fa97e02
>   rbtools/commands/patch.py PRE-CREATION
>   setup.py 84e7a2308449ee6ef72717e6adfaef2a0de41b77

> Diff: http://reviews.reviewboard.org/r/3440/diff/

> Testing
> -------

> Thanks,

> John Sintal


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google