Review Request 3242: Multi user collaboration on review requests - Review Board Reviews

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion Review Request 3242: Multi user collaboration on review requests
Received-SPF: pass (google.com: domain of nore...@reviewboard.org designates 107.22.175.174 as permitted sender) client-ip=107.22.175.174;
Content-Type: multipart/alternative; boundary="===============1396092303=="
MIME-Version: 1.0
Subject: Re: Review Request 3242: Multi user collaboration on review requests
From: crystal....@gmail.com
To: "Review Board" <reviewboard-reviews@googlegroups.com>,
        "Mike Conley" <mike.d.con...@gmail.com>,
        "Christian Hammond" <chip...@chipx86.com>, crystal....@gmail.com
Date: Sat, 01 Sep 2012 19:08:54 -0000
Message-ID: <20120901190854.2830.32350@ip-10-60-82-95.ec2.internal>
Auto-Submitted: auto-generated
Sender: nore...@reviewboard.org
References: <20120805184615.28564.82...@ip-10-60-82-95.ec2.internal>
In-Reply-To: <20120805184615.28564.82...@ip-10-60-82-95.ec2.internal>
Reply-To: crystal....@gmail.com

--===============1396092303==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.reviewboard.org/r/3242/
-----------------------------------------------------------

(Updated Sept. 1, 2012, 7:08 p.m.)


Review request for Review Board.


Changes
-------

Modified is_mutable_by method so that it doesn't query for reviewers' groups or people anymore. Basically reverted back to where it was before. When we decide on what type of users can modify the review request, we can modify that method again to accommodate the multi user collaboration. 

I still really like the idea of having the idea where the submitter can add a list of other users as owners of the ReviewRequest. I think that is simple and intuitive but may take a bit of work to redo the UI on the ReviewRequest. I love to hear suggestions or feedback! :)


Description
-------

This is what I have so far for the multi user collaboration on review requests. So far, what I have done is allow all reviewers (users in the target people and groups) to be allowed to change the review request. This would all the reviewers to all the normal changing review request functionalities. 

I'm not sure if we have decided who can be able to modify the review request. For now, I put them as all the reviewers.

Also, I've included the last_updated_by field to the review request model in order to display who has last modified the review request or published new review on the dashboard.


Diffs (updated)
-----

  reviewboard/attachments/forms.py 5d994391e1f0cd83aa7b155d4d88e33f7f0dbc84 
  reviewboard/attachments/tests.py 6453cfd7de1c9ad4b0a90fa86c4f911b23c424c1 
  reviewboard/changedescs/evolutions/__init__.py f725c299e78ae93819633c99b0ca91ef4159c618 
  reviewboard/changedescs/evolutions/change_desc_user.py PRE-CREATION 
  reviewboard/changedescs/models.py abb1074d104506a883e1f0a255e2a231841038f4 
  reviewboard/reviews/datagrids.py b61cf77fdb489e7947706aac316fb4bb693713fa 
  reviewboard/reviews/evolutions/__init__.py a9ad1e7a612a5c92cec7e9d1f962269837126662 
  reviewboard/reviews/evolutions/track_user_changes.py PRE-CREATION 
  reviewboard/reviews/forms.py 7996c654db276b0a3b67069c9c70e3e1cf20dd96 
  reviewboard/reviews/models.py 952a6cd497c2428c912107f146e23f932f535214 
  reviewboard/reviews/tests.py 51fd99c676e97b661c50d3e4dd726720524298a3 
  reviewboard/reviews/views.py b2f239a76aa2860c46ec55a16b654d498b6e8d12 
  reviewboard/templates/reviews/review_detail.html 6fcfc7dbb232306a9464488afd09bcea134fa022 
  reviewboard/templates/reviews/review_flags.js b1c2d7555d1329270c6779181c2e74cd22eceb18 
  reviewboard/templates/reviews/review_header.html 16afbbdb69d7feff9dc84dcc1c4c98a07dbb2490 
  reviewboard/templates/reviews/review_request_actions_secondary.html f3612f32aec1de9d6588fba969491ea0ba9fea29 
  reviewboard/templates/reviews/review_request_box.html eeaed19da97f936b659c6ba802c72304536e3e6b 
  reviewboard/templates/reviews/review_request_dlgs.html fc84c45182b258ae6530eb5b14be33500ae9efc7 
  reviewboard/webapi/resources.py ccbe49f8ad9ec5dbaddd7ccf46f2a31c22238d12 
  reviewboard/webapi/tests.py 5026f2ec81de3eb05ea65d1d2c8390e7e6b99398 

Diff: http://reviews.reviewboard.org/r/3242/diff/


Testing
-------

Manual testing. At first, I've ran the unit tests and had a bunch of errors and one failure. The errors are all expected due to the change of the ReviewRequestDraft.create() function and I need to look into that one failure. I think it's expected failure though.

As of diff 2, all the test failures/errors have been fixed.


Thanks,

CrystalLokKoo


--===============1396092303==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviews.reviewboard.org/r/3242/">http://reviews.reviewboard.org/r/3242/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviews.reviewboard.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Review Board.</div>
<div>By CrystalLokKoo.</div>


<p style="color: grey;"><i>Updated Sept. 1, 2012, 7:08 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Modified is_mutable_by method so that it doesn&#39;t query for reviewers&#39; groups or people anymore. Basically reverted back to where it was before. When we decide on what type of users can modify the review request, we can modify that method again to accommodate the multi user collaboration. 

I still really like the idea of having the idea where the submitter can add a list of other users as owners of the ReviewRequest. I think that is simple and intuitive but may take a bit of work to redo the UI on the ReviewRequest. I love to hear suggestions or feedback! :)</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is what I have so far for the multi user collaboration on review requests. So far, what I have done is allow all reviewers (users in the target people and groups) to be allowed to change the review request. This would all the reviewers to all the normal changing review request functionalities. 

I&#39;m not sure if we have decided who can be able to modify the review request. For now, I put them as all the reviewers.

Also, I&#39;ve included the last_updated_by field to the review request model in order to display who has last modified the review request or published new review on the dashboard.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing. At first, I&#39;ve ran the unit tests and had a bunch of errors and one failure. The errors are all expected due to the change of the ReviewRequestDraft.create() function and I need to look into that one failure. I think it&#39;s expected failure though.

As of diff 2, all the test failures/errors have been fixed.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>reviewboard/attachments/forms.py <span style="color: grey">(5d994391e1f0cd83aa7b155d4d88e33f7f0dbc84)</span></li>

 <li>reviewboard/attachments/tests.py <span style="color: grey">(6453cfd7de1c9ad4b0a90fa86c4f911b23c424c1)</span></li>

 <li>reviewboard/changedescs/evolutions/__init__.py <span style="color: grey">(f725c299e78ae93819633c99b0ca91ef4159c618)</span></li>

 <li>reviewboard/changedescs/evolutions/change_desc_user.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>reviewboard/changedescs/models.py <span style="color: grey">(abb1074d104506a883e1f0a255e2a231841038f4)</span></li>

 <li>reviewboard/reviews/datagrids.py <span style="color: grey">(b61cf77fdb489e7947706aac316fb4bb693713fa)</span></li>

 <li>reviewboard/reviews/evolutions/__init__.py <span style="color: grey">(a9ad1e7a612a5c92cec7e9d1f962269837126662)</span></li>

 <li>reviewboard/reviews/evolutions/track_user_changes.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>reviewboard/reviews/forms.py <span style="color: grey">(7996c654db276b0a3b67069c9c70e3e1cf20dd96)</span></li>

 <li>reviewboard/reviews/models.py <span style="color: grey">(952a6cd497c2428c912107f146e23f932f535214)</span></li>

 <li>reviewboard/reviews/tests.py <span style="color: grey">(51fd99c676e97b661c50d3e4dd726720524298a3)</span></li>

 <li>reviewboard/reviews/views.py <span style="color: grey">(b2f239a76aa2860c46ec55a16b654d498b6e8d12)</span></li>

 <li>reviewboard/templates/reviews/review_detail.html <span style="color: grey">(6fcfc7dbb232306a9464488afd09bcea134fa022)</span></li>

 <li>reviewboard/templates/reviews/review_flags.js <span style="color: grey">(b1c2d7555d1329270c6779181c2e74cd22eceb18)</span></li>

 <li>reviewboard/templates/reviews/review_header.html <span style="color: grey">(16afbbdb69d7feff9dc84dcc1c4c98a07dbb2490)</span></li>

 <li>reviewboard/templates/reviews/review_request_actions_secondary.html <span style="color: grey">(f3612f32aec1de9d6588fba969491ea0ba9fea29)</span></li>

 <li>reviewboard/templates/reviews/review_request_box.html <span style="color: grey">(eeaed19da97f936b659c6ba802c72304536e3e6b)</span></li>

 <li>reviewboard/templates/reviews/review_request_dlgs.html <span style="color: grey">(fc84c45182b258ae6530eb5b14be33500ae9efc7)</span></li>

 <li>reviewboard/webapi/resources.py <span style="color: grey">(ccbe49f8ad9ec5dbaddd7ccf46f2a31c22238d12)</span></li>

 <li>reviewboard/webapi/tests.py <span style="color: grey">(5026f2ec81de3eb05ea65d1d2c8390e7e6b99398)</span></li>

</ul>

<p><a href="http://reviews.reviewboard.org/r/3242/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============1396092303==--
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
