Review Request 3401: URL to diff comments returns 404 if at least one of diff-id and file-id are invalid. - Review Board Reviews

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion Review Request 3401: URL to diff comments returns 404 if at least one of diff-id and file-id are invalid.
View parsed - Show only message text
Received-SPF: pass (google.com: domain of nore...@reviewboard.org designates 107.22.175.174 as permitted sender) client-ip=107.22.175.174;
Content-Type: multipart/alternative; boundary="===============1364241580=="
MIME-Version: 1.0
Subject: Re: Review Request 3401: URL to diff comments returns 404 if at least one of
 diff-id and file-id are invalid.
From: "Michelle Chuang" <miche.chu...@gmail.com>
To: "Mike Conley" <mike.d.con...@gmail.com>,
        "Michelle Chuang" <miche.chu...@gmail.com>,
        "Review Board" <reviewboard-reviews@googlegroups.com>
Date: Sun, 14 Oct 2012 19:19:30 -0000
Message-ID: <20121014191930.25723.52568@ip-10-60-82-95.ec2.internal>
Auto-Submitted: auto-generated
Sender: "Michelle Chuang" <nore...@reviewboard.org>
References: <20121007180123.7852.92...@ip-10-60-82-95.ec2.internal>
In-Reply-To: <20121007180123.7852.92...@ip-10-60-82-95.ec2.internal>
Reply-To: "Michelle Chuang" <miche.chu...@gmail.com>

--===============1364241580==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.reviewboard.org/r/3401/
-----------------------------------------------------------

(Updated Oct. 14, 2012, 7:19 p.m.)


Review request for Review Board.


Description
-------

- Fixed URL to return 404.
- Changed to use pk when getting a FileDiffResource queryset instead of local id to pass unit test.


This addresses bug 2552.
    http://code.google.com/p/reviewboard/issues/detail?id=2552


Diffs (updated)
-----

  reviewboard/webapi/resources.py 7b40f4ea1b7e23787922071271def03500f463cc 

Diff: http://reviews.reviewboard.org/r/3401/diff/


Testing
-------

Tested on local development server against custom urls.


Thanks,

Michelle Chuang


--===============1364241580==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviews.reviewboard.org/r/3401/">http://reviews.reviewboard.org/r/3401/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviews.reviewboard.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Review Board.</div>
<div>By Michelle Chuang.</div>


<p style="color: grey;"><i>Updated Oct. 14, 2012, 7:19 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Fixed URL to return 404.
- Changed to use pk when getting a FileDiffResource queryset instead of local id to pass unit test.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on local development server against custom urls.</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://code.google.com/p/reviewboard/issues/detail?id=2552">2552</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>reviewboard/webapi/resources.py <span style="color: grey">(7b40f4ea1b7e23787922071271def03500f463cc)</span></li>

</ul>

<p><a href="http://reviews.reviewboard.org/r/3401/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============1364241580==--
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
