Review Request 3424: Add bazaar support to post-review
The group you are posting to is a
Usenet group . Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
From:
"Max Rabkin" <mrab... @nimbula.com> Date: Wed, 17 Oct 2012 11:33:14 -0000
Local: Wed, Oct 17 2012 7:33 am
Subject: Review Request 3424: Add bazaar support to post-review
-----------------------------------------------------------
http://reviews.reviewboard.org/r/3424/
Review request for RBTools.
Description
I updated the change from http://reviews.reviewboard.org/r/1739/ which added support for Bazaar to post-review, but is now out of date.
Diffs
rbtools/clients/__init__.py 7985973ec0286d8a656246282717d60d0fa97e02
Diff: http://reviews.reviewboard.org/r/3424/diff/
Testing
Ran the unit tests included, and used it locally to submit some changes.
Thanks,
Max Rabkin
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
"Max Rabkin" <mrab... @nimbula.com> Date: Thu, 18 Oct 2012 08:49:54 -0000
Local: Thurs, Oct 18 2012 4:49 am
Subject: Re: Review Request 3424: Add bazaar support to post-review
-----------------------------------------------------------
http://reviews.reviewboard.org/r/3424/
(Updated Oct. 18, 2012, 8:49 a.m.)
Review request for RBTools.
Description
I updated the change from http://reviews.reviewboard.org/r/1739/ which added support for Bazaar to post-review, but is now out of date.
This addresses bug 773.
http://code.google.com/p/reviewboard/issues/detail?id=773
Diffs
rbtools/clients/__init__.py 7985973ec0286d8a656246282717d60d0fa97e02
Diff: http://reviews.reviewboard.org/r/3424/diff/
Testing
Ran the unit tests included, and used it locally to submit some changes.
Thanks,
Max Rabkin
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
"Max Rabkin" <mrab... @nimbula.com> Date: Fri, 19 Oct 2012 09:26:16 -0000
Local: Fri, Oct 19 2012 5:26 am
Subject: Re: Review Request 3424: Add bazaar support to post-review
-----------------------------------------------------------
http://reviews.reviewboard.org/r/3424/
(Updated Oct. 19, 2012, 9:26 a.m.)
Review request for RBTools.
Description
I updated the change from http://reviews.reviewboard.org/r/1739/ which added support for Bazaar to post-review, but is now out of date.
This addresses bug 773.
http://code.google.com/p/reviewboard/issues/detail?id=773
Diffs (updated)
rbtools/clients/__init__.py 7985973ec0286d8a656246282717d60d0fa97e02
Diff: http://reviews.reviewboard.org/r/3424/diff/
Testing
Ran the unit tests included, and used it locally to submit some changes.
Thanks,
Max Rabkin
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
"David Trowbridge" <trowb... @gmail.com> Date: Sat, 20 Oct 2012 15:30:02 -0000
Local: Sat, Oct 20 2012 11:30 am
Subject: Re: Review Request 3424: Add bazaar support to post-review
-----------------------------------------------------------
http://reviews.reviewboard.org/r/3424/#review4404
This looks pretty great. I have a handful of style comments.
rbtools/clients/bazaar.py
http://reviews.reviewboard.org/r/3424/#comment7078 >
Please move this comment to be above BRANCH_REGEX, and use #s instead of a triple-quoted string.
rbtools/clients/bazaar.py
http://reviews.reviewboard.org/r/3424/#comment7079 >
Remove this line.
rbtools/clients/bazaar.py
http://reviews.reviewboard.org/r/3424/#comment7080 >
Remove this line.
rbtools/clients/bazaar.py
http://reviews.reviewboard.org/r/3424/#comment7081 >
Remove this line. Same for other docstrings below.
rbtools/clients/tests.py
http://reviews.reviewboard.org/r/3424/#comment7082 >
Remove this line.
- David Trowbridge
On Oct. 19, 2012, 9:26 a.m., Max Rabkin wrote:
> -----------------------------------------------------------
http://reviews.reviewboard.org/r/3424/
> (Updated Oct. 19, 2012, 9:26 a.m.)
> Review request for RBTools.
> Description
> I updated the change from http://reviews.reviewboard.org/r/1739/ which added support for Bazaar to post-review, but is now out of date.
> This addresses bug 773.
http://code.google.com/p/reviewboard/issues/detail?id=773
> Diffs
> rbtools/clients/__init__.py 7985973ec0286d8a656246282717d60d0fa97e02
> Diff: http://reviews.reviewboard.org/r/3424/diff/
> Testing
> Ran the unit tests included, and used it locally to submit some changes.
> Thanks,
> Max Rabkin
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
"Max Rabkin" <mrab... @nimbula.com> Date: Mon, 22 Oct 2012 08:27:49 -0000
Local: Mon, Oct 22 2012 4:27 am
Subject: Re: Review Request 3424: Add bazaar support to post-review
-----------------------------------------------------------
http://reviews.reviewboard.org/r/3424/
(Updated Oct. 22, 2012, 8:27 a.m.)
Review request for RBTools.
Changes
Cleaned up comments and docstrings
Description
I updated the change from http://reviews.reviewboard.org/r/1739/ which added support for Bazaar to post-review, but is now out of date.
This addresses bug 773.
http://code.google.com/p/reviewboard/issues/detail?id=773
Diffs (updated)
rbtools/clients/__init__.py 7985973ec0286d8a656246282717d60d0fa97e02
Diff: http://reviews.reviewboard.org/r/3424/diff/
Testing
Ran the unit tests included, and used it locally to submit some changes.
Thanks,
Max Rabkin
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
"Steven MacLeod" <ste... @smacleod.ca> Date: Tue, 23 Oct 2012 18:46:16 -0000
Local: Tues, Oct 23 2012 2:46 pm
Subject: Re: Review Request 3424: Add bazaar support to post-review
-----------------------------------------------------------
http://reviews.reviewboard.org/r/3424/#review4420
Ship it!
Ship It!
- Steven MacLeod
On Oct. 22, 2012, 8:27 a.m., Max Rabkin wrote:
> -----------------------------------------------------------
http://reviews.reviewboard.org/r/3424/
> (Updated Oct. 22, 2012, 8:27 a.m.)
> Review request for RBTools.
> Description
> I updated the change from http://reviews.reviewboard.org/r/1739/ which added support for Bazaar to post-review, but is now out of date.
> This addresses bug 773.
http://code.google.com/p/reviewboard/issues/detail?id=773
> Diffs
> rbtools/clients/__init__.py 7985973ec0286d8a656246282717d60d0fa97e02
> Diff: http://reviews.reviewboard.org/r/3424/diff/
> Testing
> Ran the unit tests included, and used it locally to submit some changes.
> Thanks,
> Max Rabkin
You must
Sign in before you can post messages.
You do not have the permission required to post.
From:
"David Trowbridge" <trowb... @gmail.com> Date: Wed, 31 Oct 2012 02:39:44 -0000
Local: Tues, Oct 30 2012 10:39 pm
Subject: Re: Review Request 3424: Add bazaar support to post-review
-----------------------------------------------------------
http://reviews.reviewboard.org/r/3424/#review4465
Ship it!
Ship It!
- David Trowbridge
On Oct. 22, 2012, 8:27 a.m., Max Rabkin wrote:
> -----------------------------------------------------------
http://reviews.reviewboard.org/r/3424/
> (Updated Oct. 22, 2012, 8:27 a.m.)
> Review request for RBTools.
> Description
> I updated the change from http://reviews.reviewboard.org/r/1739/ which added support for Bazaar to post-review, but is now out of date.
> This addresses bug 773.
http://code.google.com/p/reviewboard/issues/detail?id=773
> Diffs
> rbtools/clients/__init__.py 7985973ec0286d8a656246282717d60d0fa97e02
> Diff: http://reviews.reviewboard.org/r/3424/diff/
> Testing
> Ran the unit tests included, and used it locally to submit some changes.
> Thanks,
> Max Rabkin
You must
Sign in before you can post messages.
You do not have the permission required to post.
