Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Review Board Reviews
Home
About this group
Join this group
Review Request: Support LDAP authentication without using anonymous bind credentials
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   3 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Scott Lawrence  
View profile  
 More options Feb 21 2012, 9:27 am
From: "Scott Lawrence" <o...@lindenlab.com>
Date: Tue, 21 Feb 2012 14:27:58 -0000
Local: Tues, Feb 21 2012 9:27 am
Subject: Review Request: Support LDAP authentication without using anonymous bind credentials
Print | Individual message | Show original | Report this message | Find messages by this author

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.reviewboard.org/r/2909/
-----------------------------------------------------------

Review request for Review Board.

Description
-------

This change modifies the search for user information so that when the Anonymous credentials are not configured, the credentials entered by the user attempting to log in are used to bind to the LDAP service in order to do the search.

This addresses bug 2493.
    http://code.google.com/p/reviewboard/issues/detail?id=2493

Diffs
-----

  reviewboard/accounts/backends.py bc8ca01deca706dffecac68d0ab7e96798b80093

Diff: http://reviews.reviewboard.org/r/2909/diff/diff

Testing
-------

I've tested this with our LDAP server, which is configured not to allow any anonymous search; I believe that I did not change the behavior for the case in which the anonymous credentials are configured (if I configure them, it does the same sequence of operations to the LDAP server, but since they don't work I cannot be 100% sure).

Thanks,

Scott Lawrence


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Yazan Medanat  
View profile  
 More options Feb 21 2012, 11:04 pm
From: "Yazan Medanat" <meda...@gmail.com>
Date: Wed, 22 Feb 2012 04:04:31 -0000
Local: Tues, Feb 21 2012 11:04 pm
Subject: Re: Review Request: Support LDAP authentication without using anonymous bind credentials
Print | Individual message | Show original | Report this message | Find messages by this author

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.reviewboard.org/r/2909/#review3622
-----------------------------------------------------------

I honestly don't know what this code is doing, but I have one small remark.

I'm sure someone much smarter than me will get to this soon enough.

reviewboard/accounts/backends.py
<http://reviews.reviewboard.org/r/2909/#comment5834>

    Capitalize the "a" in attempt.

    i.e.: Attempt

- Yazan Medanat

On Feb. 21, 2012, 6:27 a.m., Scott Lawrence wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
David Trowbridge  
View profile  
 More options Mar 18 2012, 7:02 pm
From: "David Trowbridge" <trowb...@gmail.com>
Date: Sun, 18 Mar 2012 23:02:17 -0000
Local: Sun, Mar 18 2012 7:02 pm
Subject: Re: Review Request: Support LDAP authentication without using anonymous bind credentials
Print | Individual message | Show original | Report this message | Find messages by this author

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.reviewboard.org/r/2909/#review3718
-----------------------------------------------------------

Ship it!

Ship It!

- David Trowbridge

On Feb. 21, 2012, 6:27 a.m., Scott Lawrence wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google