Rational Team Concert support - implementation details

[Jan Koprowski]

Hi,

  Right now I am in headquarter of Rational Team Concert in Zurich. I'm learning things and, as big fan of ReviewBoard, I'm thinking about implementing support for this tool.

However. This is not so easy.

1. We can not use command-line tool because it is basically terrible and generating diffs between revisions in command line is probably not possible (or at least I can not find it)

2. There are two other ways to do that: implement in IDE itself (Eclipse and VIsualStudio) allowing to use it only inside IDE or talk with SOAP services

2.1 First approach cause you can not generate diff outside of IDE (there will be no post-review support) but there is another problem: there is no (AFAIK) Review Board client for Visual Studio

2.2 Second approach needs to generate XML requests (which may changes) or use Java library called "Plain Java Client Libraries" from https://jazz.net/downloads/rational-team-concert/releases/4.0?p=allDownloads

This second approach cause few things:

1. We need a builds to build post-review for different RTC versions (with different versions of library)

2. We need at lest jython to communicate with RTC (with whole bunch of jar files of course)

It is how it looks like now unfortunately and this is not easy call :| Probably the first approach would be much better than that.

There is also a third approach:

3. Write Review Board support as Rational Team Concert plugin - it still needs a builds and maybe even different code bases for different versions of RTC but it will work anyway regardless of IDE or things like that.

Regards,

Jan

[Christian Hammond]

Hi Jan,

Sounds like a challenge.

So our Perforce support has a similar problem when it comes to having limitations with generating diffs. We actually hand-roll our own diffs, by fetching older files, doing a standard diff between them, and post-processing them.

Sounds like your situation is even more difficult.

Rather than having to do anything too special with post-review, could a new tool be written instead in Java, Jython or whatever is best that interacts with the repository and allows such operations as file fetching (by path and revision) and returning repository information (so we can look up the repository on Review Board)? If a tool like that exists, post-review can just make use of it and treat it like svn, p4, etc.

We wouldn't be able to accept anything that laters post-review *too* drastically, or enforce restrictions like requiring jython for post-review itself. A third-party tool that can do that kind of work, though, would be fine.

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

--
 
---
You received this message because you are subscribed to the Google Groups "reviewboard-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-d...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Jan Koprowski]

Hi everyone,

  Little update in the subject. I did not get desired API. Instead I've used https://code.google.com/p/java-diff-utils/ project and generate unified diffs by myself.

  Review Board patch and appropriate Rational Team Concert follow-up action are available here: https://github.com/jankoprowski/org.reviewboard.rtc

  If you need generate review using post-review you can try this patch: http://reviews.reviewboard.org/r/4095/

  I hope it will be helpful.

Regards,

Jan