reopen requires perforce client specification

15 views
Skip to first unread message

Kudrettin Güleryüz

unread,
May 22, 2013, 5:09:58 PM5/22/13
to reviewb...@googlegroups.com
Hello, 

I am working on a solution to set review request status to submitted imitating current --reopen behaviour. I am having hard time to see why reopen option requires to know a Perforce client? Any insight would be great. For your information, I am currently playing with version 0.4.3 of RBTools. 

Thank you, \\Kudret

Christian Hammond

unread,
May 23, 2013, 2:37:06 PM5/23/13
to reviewb...@googlegroups.com
Hi,

post-review first attempts to figure out what your current repository is before figuring out what operation you want to perform.

What I'd recommend is installing RBTools 0.5 and then writing a small script that uses our API to perform a reopen. (This is actually something we'd love to include in RBTools itself). That would be able to avoid dealing with a local client.

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org


--
 
---
You received this message because you are subscribed to the Google Groups "reviewboard-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-d...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Kudrettin Güleryüz

unread,
May 23, 2013, 2:59:43 PM5/23/13
to reviewb...@googlegroups.com
I have to stick with 0.4.3 for a little while more. But I will switch to latest version soon.

I am calling post-review as:
post-review --repository=perforce --reopen -r 12345.Can't it assume that repository information is correct? Also, shouldn't --reopen skip the steps below for just to reopen a discarded review when there is no file changes?

INFO:root:Generating diff for changenum default
DEBUG:root:Running: p4 opened -c default
Couldn't find any affected files for this change.

Thank you, \\Kudret

Christian Hammond

unread,
May 23, 2013, 3:06:27 PM5/23/13
to reviewb...@googlegroups.com
post-review first and foremost is meant to deal with repositories. All options to it are evaluated after we've determined the type of repository. It's just how it works.

We've frozen post-review, so no new work will happen on it. Everything is moving to the new tools.

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org


Reply all
Reply to author
Forward
0 new messages