Weekly Headlines - Requirements Analysis

[Wei Lu Liu]

The original requirements on Google Code Wiki:

Finding out what's been happening on Review Board isn't always easy.
It might be worthwhile to have users be able to opt-in to weekly email
updates from Review Board that tell them useful things about the
groups that they belong to. In particular, it could mention things
about:
1. Outstanding reviews that they could / should tackle
2. A list of review requests that have been marked submitted, and
which ones have been discarded
3. A list of new review requests
4. Perhaps something like, "the top reviewer of the week"
5. Perhaps more...

My approach to and questions about 1~4:
1. What defines outstanding?
2. In [reviews_reviewrequest], <last_review_timestamp> within last
week & <shipit_count> =1
How to show to discarded ones?
3. In [reviews_reviewrequest], <time_added> within last week
4. In [reviews_review], if <timestamp> within last week, count
<user_id>; rank <user_id>

Any thoughts?

[Mike Conley]

Wei:

For an email recipient X:

1. An outstanding review request is a review request that:
a) is assigned to either a group containing X, or assigned to X
directly
b) has not yet been reviewed by X since the last revision.

> 2. In [reviews_reviewrequest], <last_review_timestamp> within last
> week & <shipit_count> =1
> How to show to discarded ones?

I wouldn't put the "ship it" logic in there. Instead, we'd look at
review requests where in the past week, the status has changed to
"submitted" or has changed to "discarded".

> 3. In [reviews_reviewrequest], <time_added> within last week

Sounds right.

> 4. In [reviews_review], if <timestamp> within last week, count
> <user_id>; rank <user_id>

This one might be a more complex query. Off the top of my head, I'd
get the list of reviews created in the past week, and group them / sum
them by author. The author with the highest rank is the "reviewer of
the week".

We might want to fine tune it somewhere down the line, but that'll
probably suffice for now.

Does this clear things up any?

-Mike

[Wei Lu Liu]

Sounds pretty clear. I'll see if I have more problems in
implementation.

Thanks,
Wei