ReviewBoard dependencies "prevent" from creating a fork

31 views
Skip to first unread message

Jan Koprowski

unread,
Jun 19, 2013, 1:58:14 AM6/19/13
to reviewb...@googlegroups.com
Hi,

  I'm still trying develop fork of Review Board support Rational Team Concert version.
  However because of very complex and not well maintained dependencies running 'python setup.py install' on plain Debian machine is almost impossible to finish.
  Creating fork is so hard it is almost impossible in current state of the project. I already have a client for RTC integration but I cannot support them because of project dependencies.
  I need your help. Could you try run install/develop on fresh up-to-date debian installation and see what is happening and fix the issues?

Regards,

Jan

Christian Hammond

unread,
Jun 19, 2013, 1:59:19 AM6/19/13
to reviewb...@googlegroups.com
Hi Jan,

I don't have such an install handy. Can you show us full logs on what's failing?

Christian

-- 
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org

--
 
---
You received this message because you are subscribed to the Google Groups "reviewboard-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-d...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Jan Koprowski

unread,
Jun 28, 2013, 12:22:51 AM6/28/13
to reviewb...@googlegroups.com
Christian,

  I've found the problem is while "python setup.py bdist_egg" command. I'm sending you log file (attached).

Regards,


--
 
---
You received this message because you are subscribed to a topic in the Google Groups "reviewboard-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard-dev/SnO9TGyqHKw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reviewboard-d...@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.
 
 



--
><> Jan Koprowski
bdist_egg.error.log

Jan Koprowski

unread,
Jun 28, 2013, 12:58:01 AM6/28/13
to reviewb...@googlegroups.com
Ok,

  I've solved problems. Solution is (Debian 7.0 with testing and unstable repositories):

1. Problem: pipeline.compilers.CompilerError: /usr/bin/env: lessc: Nie ma takiego pliku ani katalogu
   Solution: apt-get -t testing install node-less
2. Problem: ImportError: No module named jsmin:
   Solution: pip install jsmin

Regards,
--
><> Jan Koprowski

Christian Hammond

unread,
Jun 28, 2013, 1:11:58 AM6/28/13
to reviewb...@googlegroups.com
Hi Jan. Glad you figured it out.

You don't really want to fork Review Board, though. Review Board was
built for extensibility for things like SCMTools. You should only need
to create a package that provides a Python Entrypoint for the SCMTool
(see our setup.py for how we register the existing ones). All SCMTools
go through this system.

Christian


Jan Koprowski wrote:
> Ok,
>
> I've solved problems. Solution is (Debian 7.0 with testing and
> unstable repositories):
>
> 1. Problem: pipeline.compilers.CompilerError: /usr/bin/env: lessc: Nie
> ma takiego pliku ani katalogu
> Solution: apt-get -t testing install node-less
> 2. Problem: ImportError: No module named jsmin:
> Solution: pip install jsmin
>
> Regards,
>
>
> On Fri, Jun 28, 2013 at 6:22 AM, Jan Koprowski <jan.ko...@gmail.com
> <mailto:jan.ko...@gmail.com>> wrote:
>
> Christian,
>
> I've found the problem is while "python setup.py bdist_egg"
> command. I'm sending you log file (attached).
>
> Regards,
>
>
> On Wed, Jun 19, 2013 at 7:59 AM, Christian Hammond
> <chi...@chipx86.com <mailto:chi...@chipx86.com>> wrote:
>
> Hi Jan,
>
> I don't have such an install handy. Can you show us full logs on
> what's failing?
>
> Christian
>
> --
> Christian Hammond - chi...@chipx86.com <mailto:chi...@chipx86.com>
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> On Jun 18, 2013, at 10:58 PM, Jan Koprowski
> <jan.ko...@gmail.com <mailto:jan.ko...@gmail.com>> wrote:
>
>> Hi,
>>
>> I'm still trying develop fork of Review Board support
>> Rational Team Concert version.
>> However because of very complex and not well maintained
>> dependencies running 'python setup.py install' on plain Debian
>> machine is almost impossible to finish.
>> Creating fork is so hard it is almost impossible in current
>> state of the project. I already have a client for RTC
>> integration but I cannot support them because of project
>> dependencies.
>> I need your help. Could you try run install/develop on fresh
>> up-to-date debian installation and see what is happening and
>> fix the issues?
>>
>> Regards,
>>
>> Jan
>>
>> --
>>
>> ---
>> You received this message because you are subscribed to the
>> Google Groups "reviewboard-dev" group.
>> To unsubscribe from this group and stop receiving emails from
>> it, send an email to
>> reviewboard-d...@googlegroups.com
>> <mailto:reviewboard-d...@googlegroups.com>.
>>
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>
> --
>
> ---
> You received this message because you are subscribed to a topic
> in the Google Groups "reviewboard-dev" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/reviewboard-dev/SnO9TGyqHKw/unsubscribe.
> To unsubscribe from this group and all its topics, send an email
> to reviewboard-d...@googlegroups.com
> <mailto:reviewboard-dev%2Bunsu...@googlegroups.com>.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>
>
>
> --
> ><> Jan Koprowski
>
>
>
>
> --
> ><> Jan Koprowski
>
> --
>
> ---
> You received this message because you are subscribed to the Google
> Groups "reviewboard-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to reviewboard-d...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

--

Jan Koprowski

unread,
Jun 28, 2013, 1:15:21 AM6/28/13
to reviewb...@googlegroups.com
Wonderful :) :)

  Is it documented already?!

Regards,


        <jan.ko...@gmail.com <mailto:jan.koprowski@gmail.com>> wrote:

        Hi,

          I'm still trying develop fork of Review Board support
        Rational Team Concert version.
          However because of very complex and not well maintained
        dependencies running 'python setup.py install' on plain Debian
        machine is almost impossible to finish.
          Creating fork is so hard it is almost impossible in current
        state of the project. I already have a client for RTC
        integration but I cannot support them because of project
        dependencies.
          I need your help. Could you try run install/develop on fresh
        up-to-date debian installation and see what is happening and
        fix the issues?

        Regards,

        Jan

        --

        ---
        You received this message because you are subscribed to the
        Google Groups "reviewboard-dev" group.
        To unsubscribe from this group and stop receiving emails from
        it, send an email to


        For more options, visit https://groups.google.com/groups/opt_out.



        --

        ---
        You received this message because you are subscribed to a topic
        in the Google Groups "reviewboard-dev" group.
        To unsubscribe from this topic, visit
        https://groups.google.com/d/topic/reviewboard-dev/SnO9TGyqHKw/unsubscribe.
        To unsubscribe from this group and all its topics, send an email
        <mailto:reviewboard-dev%2Bunsu...@googlegroups.com>.

        For more options, visit https://groups.google.com/groups/opt_out.





    --
    ><> Jan Koprowski




--
 ><> Jan Koprowski

--

---
You received this message because you are subscribed to the Google
Groups "reviewboard-dev" group.
To unsubscribe from this group and stop receiving emails from it, send

For more options, visit https://groups.google.com/groups/opt_out.



--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

--

--- You received this message because you are subscribed to a topic in the Google Groups "reviewboard-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard-dev/SnO9TGyqHKw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reviewboard-dev+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.





--
><> Jan Koprowski

Christian Hammond

unread,
Jun 28, 2013, 1:19:37 AM6/28/13
to reviewb...@googlegroups.com
It's not documented explicitly, but that part is pretty straight-forward
in getting it going. You can just copy the entrypoints section in your
own package. That just provides the entry in the list of repository
types when configuring a repository.

Was there another piece of integration you needed beyond this? Trying to
remember what we may have discussed in the past around this.

Christian


Jan Koprowski wrote:
> Wonderful :) :)
>
> Is it documented already?!
>
> Regards,
>
>
> On Fri, Jun 28, 2013 at 7:11 AM, Christian Hammond <chi...@chipx86.com
> <mailto:chi...@chipx86.com>> wrote:
>
> Hi Jan. Glad you figured it out.
>
> You don't really want to fork Review Board, though. Review Board was
> built for extensibility for things like SCMTools. You should only
> need to create a package that provides a Python Entrypoint for the
> SCMTool (see our setup.py for how we register the existing ones).
> All SCMTools go through this system.
>
> Christian
>
>
> Jan Koprowski wrote:
>
> Ok,
>
> I've solved problems. Solution is (Debian 7.0 with testing and
> unstable repositories):
>
> 1. Problem: pipeline.compilers.__CompilerError: /usr/bin/env:
> lessc: Nie
> ma takiego pliku ani katalogu
> Solution: apt-get -t testing install node-less
> 2. Problem: ImportError: No module named jsmin:
> Solution: pip install jsmin
>
> Regards,
>
>
> On Fri, Jun 28, 2013 at 6:22 AM, Jan Koprowski
> <jan.ko...@gmail.com <mailto:jan.ko...@gmail.com>
> <mailto:jan.koprowski@gmail.__com
> <mailto:jan.ko...@gmail.com>>> wrote:
>
> Christian,
>
> I've found the problem is while "python setup.py bdist_egg"
> command. I'm sending you log file (attached).
>
> Regards,
>
>
> On Wed, Jun 19, 2013 at 7:59 AM, Christian Hammond
> <chi...@chipx86.com <mailto:chi...@chipx86.com>
> <mailto:chi...@chipx86.com <mailto:chi...@chipx86.com>>> wrote:
>
> Hi Jan,
>
> I don't have such an install handy. Can you show us
> full logs on
> what's failing?
>
> Christian
>
> --
> Christian Hammond - chi...@chipx86.com
> <mailto:chi...@chipx86.com> <mailto:chi...@chipx86.com
> <mailto:chi...@chipx86.com>>
>
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> On Jun 18, 2013, at 10:58 PM, Jan Koprowski
> <jan.ko...@gmail.com <mailto:jan.ko...@gmail.com>
> <mailto:jan.koprowski@gmail.__com
> reviewboard-dev+unsubscribe@__googlegroups.com
> <mailto:reviewboard-dev%2Bunsu...@googlegroups.com>
> <mailto:reviewboard-de...@googlegroups.com
> <mailto:reviewboard-dev%2Bunsu...@googlegroups.com>>.
>
>
> For more options, visit
> https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>.
>
>
>
> --
>
> ---
> You received this message because you are subscribed to
> a topic
> in the Google Groups "reviewboard-dev" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/__topic/reviewboard-dev/__SnO9TGyqHKw/unsubscribe
> <https://groups.google.com/d/topic/reviewboard-dev/SnO9TGyqHKw/unsubscribe>.
> To unsubscribe from this group and all its topics, send
> an email
> to reviewboard-dev+unsubscribe@__googlegroups.com
> <mailto:reviewboard-dev%2Bunsu...@googlegroups.com>
> <mailto:reviewboard-dev%__2Buns...@googlegroups.com
> <mailto:reviewboard-dev%252Buns...@googlegroups.com>__>.
>
> For more options, visit
> https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>.
>
>
>
>
>
> --
> ><> Jan Koprowski
>
>
>
>
> --
> ><> Jan Koprowski
>
> --
>
> ---
> You received this message because you are subscribed to the Google
> Groups "reviewboard-dev" group.
> To unsubscribe from this group and stop receiving emails from
> it, send
> an email to reviewboard-dev+unsubscribe@__googlegroups.com
> <mailto:reviewboard-dev%2Bunsu...@googlegroups.com>.
> For more options, visit
> https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>.
>
>
>
> --
> Christian Hammond - chi...@chipx86.com <mailto:chi...@chipx86.com>
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> --
>
> --- You received this message because you are subscribed to a topic
> in the Google Groups "reviewboard-dev" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/__topic/reviewboard-dev/__SnO9TGyqHKw/unsubscribe
> <https://groups.google.com/d/topic/reviewboard-dev/SnO9TGyqHKw/unsubscribe>.
> To unsubscribe from this group and all its topics, send an email to
> reviewboard-dev+unsubscribe@__googlegroups.com
> <mailto:reviewboard-dev%2Bunsu...@googlegroups.com>.
> For more options, visit https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>.
>
>
>
>
>
> --
> ><> Jan Koprowski
>
> --
>
> ---
> You received this message because you are subscribed to the Google
> Groups "reviewboard-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to reviewboard-d...@googlegroups.com.

Jan Koprowski

unread,
Jun 28, 2013, 2:10:48 AM6/28/13
to reviewb...@googlegroups.com
I will try figure it out and let you know.

  Did you think about something like "Review Board Store" where you could publish, set the price and install another people extensions?

Regards,


        <jan.ko...@gmail.com <mailto:jan.koprowski@gmail.com>
        <mailto:jan.koprowski@gmail.__com

        <mailto:jan.koprowski@gmail.com>>> wrote:

             Christian,

                I've found the problem is while "python setup.py bdist_egg"
             command. I'm sending you log file (attached).

             Regards,


             On Wed, Jun 19, 2013 at 7:59 AM, Christian Hammond
        <chi...@chipx86.com <mailto:chi...@chipx86.com>
        <mailto:chi...@chipx86.com <mailto:chi...@chipx86.com>>> wrote:

                 Hi Jan,

                 I don't have such an install handy. Can you show us
        full logs on
                 what's failing?

                 Christian

                 --
                 Christian Hammond - chi...@chipx86.com
        <mailto:chi...@chipx86.com> <mailto:chi...@chipx86.com

        <mailto:chi...@chipx86.com>>

                 Review Board - http://www.reviewboard.org
                 Beanbag, Inc. - http://www.beanbaginc.com

                 On Jun 18, 2013, at 10:58 PM, Jan Koprowski
        <jan.ko...@gmail.com <mailto:jan.koprowski@gmail.com>
        <mailto:jan.koprowski@gmail.__com
            <mailto:reviewboard-dev+__unsub...@googlegroups.com

            <mailto:reviewboard-dev%2Bunsu...@googlegroups.com>>.


                     For more options, visit
            https://groups.google.com/__groups/opt_out
            <https://groups.google.com/groups/opt_out>.




                 --

                 ---
                 You received this message because you are subscribed to
        a topic
                 in the Google Groups "reviewboard-dev" group.
                 To unsubscribe from this topic, visit
        https://groups.google.com/d/__topic/reviewboard-dev/__SnO9TGyqHKw/unsubscribe
        <https://groups.google.com/d/topic/reviewboard-dev/SnO9TGyqHKw/unsubscribe>.

                 To unsubscribe from this group and all its topics, send
        an email
                 to reviewboard-dev+unsubscribe@__googlegroups.com
        <mailto:reviewboard-dev%2Bunsu...@googlegroups.com>
        <mailto:reviewboard-dev%__2Bunsu...@googlegroups.com
        <mailto:reviewboard-dev%252Bunsubscribe@googlegroups.com>__>.

For more options, visit https://groups.google.com/groups/opt_out.



--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

--

--- You received this message because you are subscribed to a topic in the Google Groups "reviewboard-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard-dev/SnO9TGyqHKw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reviewboard-dev+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.





--
><> Jan Koprowski

Christian Hammond

unread,
Jun 28, 2013, 2:14:08 AM6/28/13
to reviewb...@googlegroups.com
That's the plan!

Christian


Jan Koprowski wrote:
> I will try figure it out and let you know.
>
> Did you think about something like "Review Board Store" where you
> could publish, set the price and install another people extensions?
>
> Regards,
>
>
> On Fri, Jun 28, 2013 at 7:19 AM, Christian Hammond <chi...@chipx86.com
> <mailto:chi...@chipx86.com>> wrote:
>
> It's not documented explicitly, but that part is pretty
> straight-forward in getting it going. You can just copy the
> entrypoints section in your own package. That just provides the
> entry in the list of repository types when configuring a repository.
>
> Was there another piece of integration you needed beyond this?
> Trying to remember what we may have discussed in the past around this.
>
> Christian
>
>
> Jan Koprowski wrote:
>
> Wonderful :) :)
>
> Is it documented already?!
>
> Regards,
>
>
> On Fri, Jun 28, 2013 at 7:11 AM, Christian Hammond
> <chi...@chipx86.com <mailto:chi...@chipx86.com>
> <mailto:chi...@chipx86.com <mailto:chi...@chipx86.com>>> wrote:
>
> Hi Jan. Glad you figured it out.
>
> You don't really want to fork Review Board, though. Review
> Board was
> built for extensibility for things like SCMTools. You
> should only
> need to create a package that provides a Python Entrypoint
> for the
> SCMTool (see our setup.py for how we register the existing
> ones).
> All SCMTools go through this system.
>
> Christian
>
>
> Jan Koprowski wrote:
>
> Ok,
>
> I've solved problems. Solution is (Debian 7.0 with
> testing and
> unstable repositories):
>
> 1. Problem: pipeline.compilers.____CompilerError:
> /usr/bin/env:
>
> lessc: Nie
> ma takiego pliku ani katalogu
> Solution: apt-get -t testing install node-less
> 2. Problem: ImportError: No module named jsmin:
> Solution: pip install jsmin
>
> Regards,
>
>
> On Fri, Jun 28, 2013 at 6:22 AM, Jan Koprowski
> <mailto:jan.koprowski@gmail. <mailto:jan.koprowski@gmail.>____com
>
> <mailto:jan.koprowski@gmail.__com
> <mailto:jan.ko...@gmail.com>>>> wrote:
>
> Christian,
>
> I've found the problem is while "python
> setup.py bdist_egg"
> command. I'm sending you log file (attached).
>
> Regards,
>
>
> On Wed, Jun 19, 2013 at 7:59 AM, Christian Hammond
> <chi...@chipx86.com <mailto:chi...@chipx86.com>
> <mailto:chi...@chipx86.com <mailto:chi...@chipx86.com>>
> <mailto:chi...@chipx86.com <mailto:chi...@chipx86.com>
> <mailto:chi...@chipx86.com <mailto:chi...@chipx86.com>>>> wrote:
>
> Hi Jan,
>
> I don't have such an install handy. Can you
> show us
> full logs on
> what's failing?
>
> Christian
>
> --
> Christian Hammond - chi...@chipx86.com
> <mailto:chi...@chipx86.com>
> <mailto:chi...@chipx86.com <mailto:chi...@chipx86.com>>
> <mailto:chi...@chipx86.com <mailto:chi...@chipx86.com>
>
> <mailto:chi...@chipx86.com <mailto:chi...@chipx86.com>>>
>
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> On Jun 18, 2013, at 10:58 PM, Jan Koprowski
> <mailto:jan.koprowski@gmail. <mailto:jan.koprowski@gmail.>____com
>
> <mailto:jan.koprowski@gmail.__com
> reviewboard-dev+unsubscribe@____googlegroups.com
> <http://googlegroups.com>
> <mailto:reviewboard-dev...@googlegroups.com
> <mailto:reviewboard-dev%2B__uns...@googlegroups.com>
>
> <mailto:reviewboard-dev%__2Buns...@googlegroups.com
> <mailto:reviewboard-dev%252Buns...@googlegroups.com>__>>.
>
>
> For more options, visit
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>.
>
>
>
>
> --
>
> ---
> You received this message because you are
> subscribed to
> a topic
> in the Google Groups "reviewboard-dev" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/____topic/reviewboard-dev/____SnO9TGyqHKw/unsubscribe
> <https://groups.google.com/d/__topic/reviewboard-dev/__SnO9TGyqHKw/unsubscribe>
> reviewboard-dev+unsubscribe@____googlegroups.com
> <http://googlegroups.com>
> <mailto:reviewboard-dev%____2Bun...@googlegroups.com
> <mailto:reviewboard-dev%25__2Bun...@googlegroups.com>
> <mailto:reviewboard-dev%__252Bunsubscribe@googlegroups.__com
> <mailto:reviewboard-dev%25252Bun...@googlegroups.com>>__>.
>
> For more options, visit
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <https://groups.google.com/__groups/opt_out
> <https://groups.google.com/groups/opt_out>>.
>
>
>
>
>
>
> --
> ><> Jan Koprowski
>
>
>
>
> --
> ><> Jan Koprowski
>
> --
>
> ---
> You received this message because you are subscribed to
> the Google
> Groups "reviewboard-dev" group.
> To unsubscribe from this group and stop receiving
> emails from
> it, send
> an email to
> reviewboard-dev+unsubscribe@____googlegroups.com
> <http://googlegroups.com>
>
> <mailto:reviewboard-dev%__2Buns...@googlegroups.com
> <mailto:reviewboard-dev%252Buns...@googlegroups.com>__>.
> For more options, visit
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> <mailto:chi...@chipx86.com> <mailto:chi...@chipx86.com
> <mailto:chi...@chipx86.com>>
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> --
>
> --- You received this message because you are subscribed to
> a topic
> in the Google Groups "reviewboard-dev" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/____topic/reviewboard-dev/____SnO9TGyqHKw/unsubscribe
> <https://groups.google.com/d/__topic/reviewboard-dev/__SnO9TGyqHKw/unsubscribe>
> reviewboard-dev+unsubscribe@____googlegroups.com
> <http://googlegroups.com>
> <mailto:reviewboard-dev%__2Buns...@googlegroups.com
> <mailto:reviewboard-dev%252Buns...@googlegroups.com>__>.
> For more options, visit
> https://groups.google.com/____groups/opt_out
> <https://groups.google.com/__groups/opt_out>
> an email to reviewboard-d...@googlegroups.com.

Stephen Gallagher

unread,
Jun 28, 2013, 7:09:56 AM6/28/13
to reviewb...@googlegroups.com
On 06/28/2013 12:58 AM, Jan Koprowski wrote:
> Ok,
>
> I've solved problems. Solution is (Debian 7.0 with testing and
> unstable repositories):
>
> 1. Problem: pipeline.compilers.CompilerError: /usr/bin/env: lessc: Nie
> ma takiego pliku ani katalogu
> Solution: apt-get -t testing install node-less
> 2. Problem: ImportError: No module named jsmin:
> Solution: pip install jsmin
>


FYI, I've reported this to Christian in the past, but I'm going to bring
it up again. The Lawyers(TM) have determined that jsmin is unsuitable
for use in any open-source application because its license is non-free.
It contains a clause that makes it possible for the original author to
determine at any time of his choosing that your code is no longer
covered by his license and therefore you could be required to provide
royalties.

In Fedora, I patched out the jsmin requirement a long while ago in favor
of SlimIt (http://slimit.readthedocs.org/en/latest/) which provides
basically identical functionality with an acceptable license. It's worth
noting that switching to SlimIt also brings a performance gain, as
benchmarks show that it produces smaller minified output than jsmin as
well: http://slimit.readthedocs.org/en/latest/#benchmarks

I've submitted review request http://reviews.reviewboard.org/r/4270/
with the very small change necessary to accomplish this.

Christian Hammond

unread,
Jun 28, 2013, 2:25:54 PM6/28/13
to reviewb...@googlegroups.com
Hi Stephen,

I'm planning to get rid of jsmin in 1.8. I'm actually leaning toward
UglifyJS. See any issues with that?

Christian

Stephen Gallagher

unread,
Jun 28, 2013, 2:33:23 PM6/28/13
to reviewb...@googlegroups.com
On 06/28/2013 02:25 PM, Christian Hammond wrote:
> Hi Stephen,
>
> I'm planning to get rid of jsmin in 1.8. I'm actually leaning toward
> UglifyJS. See any issues with that?
>

Assuming you're talking about https://npmjs.org/package/uglify-js I see
no issues with it. We've got it packaged up for Fedora and the license
is cleanly BSD.
Reply all
Reply to author
Forward
0 new messages