What is the policy on Pull Requests?

[Pedro Lamas]

Greetings,

I was wondering of what is the policy over contributions as Pull
Requests?

I ask this because I have submitted two in the past (one regarding
Json.net update and another for GZip support on Windows Phone) and
they got to the main repository, but a third one I submitted regarding
some issues with cookies in Silverlight/Windows Phone hasn't been
accepted yet...

https://github.com/restsharp/RestSharp/pull/215

What do I have to do to get this in the main repository? Or did I miss
something and this fix isn't required? :)

Best regards,

Pedro Lamas

[Andrew Young]

The policies are on the wiki.  https://github.com/restsharp/RestSharp/wiki/Submission-Guidelines 

Aside from the pull request not having the right tab settings, it looks good and ready to be merged in. There's nothing you're missing. Someone just hasn't gotten around to pulling it in yet. I'll make sure it gets in within the next couple days unless someone else gets to it before I do.

[Pedro Lamas]

Cool, thank you for your help Andrew!

And I'll make sure to check the code formatting better next time! ;)

Best regards,

Pedro Lamas

On Feb 22, 5:39 pm, Andrew Young <andrewdyo...@gmail.com> wrote:
> The policies are on the wiki.https://github.com/restsharp/RestSharp/wiki/Submission-Guidelines

[John Sheehan]

The other rule that isn't there is no breaking API changes (method signatures, etc) without a big ol' discussion here first. When those go out I get tons of support email and bitter users.