Fabricatorz Big Patch: Feedback form, custom_separator, simple upload, more hooks!

[Jon Phillips]

Hi all, here is the big patch, that eyeballnyc.com has given back to
the community. I'm sorry its so big. I tried my hardest to keep code
outside of resourcespace to make a custom installation, but these
changes had to be made. They make resourcespace more configurable and
easier to use for installation which checkout the latest code from
subversion and want to use svn:externals to manage custom css,
graphics, plugins, and players. The attached readme goes over the big
patch changes, and the accompanying feedback.php should go into the
pages directory. Its a simple way to add a feedback form to get quick
feedback to the email for the configured resourcespace.

I'm hoping these changes will be applied in whole. I can take feedback
from them and tweak where needed, and then change after applied, or,
please provide me SVN access, and I can personally apply this patch
since I know it pretty well. The key piece to this patch is that it
doesn't break any old functionality, and majorly provides new
functionality. It only needs to add one option to config.default.php,
and a few strings to language/en.php

The readme explains all parts of the patch. I've also included my
public key, and my desired username is rejon.

Thanks for making cool software, and I hope this patch is accepted :)

Jon

--
Jon Phillips
http://rejon.org/
+1.415.830.3884 (sf/global)
+86.134.3957.2035 (china)
Sent from San Francisco, California, United States

[Tom Gleason]

Thanks Jon, I just applied it and nothing broke, so that's a great sign.
Allow some time for us to review these mods a bit before committing them all.

Tom

[Jon Phillips]

Awesome...if anything there needs to be some documentation added to the changes...if the whole readme can be included in changelog and svn commit notification, good idea...

Jon Phillips
+1.415.830.3884 (global)
+86.134.3957.2035 (beijing)
j...@rejon.org

On Aug 21, 2009 5:08 PM, "Tom Gleason" <theory...@gmail.com> wrote:


Thanks Jon, I just applied it and nothing broke, so that's a great sign.
Allow some time for us to review these mods a bit before committing them all.

Tom

On Fri, Aug 21, 2009 at 7:39 PM, Jon Phillips<j...@rejon.org> wrote: > Hi all, here is the big patch...

[Jon Phillips]

Any update on the big patch? I see dan must be back off vacation :) Hopefully can get it in before much more code churn, aka, a lot of work to match patch to changes each time in svn :)

be well!
Jon

[Dan Huby]

On 24 Aug, 23:02, Jon Phillips <j...@rejon.org> wrote:
> Any update on the big patch? I see dan must be back off vacation :)
> Hopefully can get it in before much more code churn, aka, a lot of work to
> match patch to changes each time in svn :)
>
> be well!
> Jon

Hi Jon - I gave you commit access to SVN and write access to the wiki
before I went away - did you get those details?

[Jon Phillips]

Oh, I didn't...could you resend? Should I just go ahead and commit my patch then?

Thanks!

Jon

--
Jon Phillips
http://rejon.org/
+1.415.830.3884 (sf/global)
+86.134.3957.2035 (china)

Sent from San Francisco, CA, United States